Skip to content

Obligatory comedi split #96

Description

@Garrafao

Running some integration tests results in the following error:

 bash -e experiments/integration_tests.sh
E
======================================================================
ERROR: test_apd_change_graded_eng_simple_arm (tests.integration.test_lscd_models.TestLSCDModels)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/users0/schlecdk/.conda/envs/lscdb/lib/python3.10/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 92, in _call_target
    return _target_(*args, **kwargs)
  File "/mount/projekte50/projekte/cik/users/dominik/LSCDBenchmark/./src/dataset.py", line 81, in __init__
    super().__init__(**data)
  File "pydantic/main.py", line 342, in pydantic.main.BaseModel.__init__
pydantic.error_wrappers.ValidationError: 2 validation errors for Dataset
standard_split -> comedi_dev
  field required (type=value_error.missing)
standard_split -> comedi_test
  field required (type=value_error.missing)

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/mount/projekte50/projekte/cik/users/dominik/LSCDBenchmark/tests/integration/test_lscd_models.py", line 50, in test_apd_change_graded_eng_simple_arm
    score, predictions = run(*instantiate(config))
  File "/mount/projekte50/projekte/cik/users/dominik/LSCDBenchmark/./src/utils/runner.py", line 74, in instantiate
    dataset = utils.instantiate(
  File "/home/users0/schlecdk/.conda/envs/lscdb/lib/python3.10/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 222, in instantiate
    return instantiate_node(
  File "/home/users0/schlecdk/.conda/envs/lscdb/lib/python3.10/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 339, in instantiate_node
    return _call_target(_target_, partial, args, kwargs, full_key)
  File "/home/users0/schlecdk/.conda/envs/lscdb/lib/python3.10/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 97, in _call_target
    raise InstantiationException(msg) from e
hydra.errors.InstantiationException: Error in call to target 'src.dataset.Dataset':
ValidationError(model='Dataset', errors=[{'loc': ('standard_split', 'comedi_dev'), 'msg': 'field required', 'type': 'value_error.missing'}, {'loc': ('standard_split', 'comedi_test'), 'msg': 'field required', 'type': 'value_error.missing'}])
full_key: dataset

----------------------------------------------------------------------
Ran 1 test in 0.448s

FAILED (errors=1)

The reason is that specifying comedi splits in dataset configuration files is now obligatory and they are not specified for some data sets used for testing such as testwug.

Metadata

Metadata

Labels

bugSomething isn't working

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions