Merge pull request #12 from GabrielMarquezMatte/develop #28
Annotations
30 warnings and 1 notice
|
Build & Test (macos-latest):
src/ExcelReader.Core/Writer/XlsbWorkbookWriter.cs#L257
'ZipArchiveEntry.Open()' synchronously blocks. Await 'ZipArchiveEntry.OpenAsync(CancellationToken)' instead. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1849)
|
|
Build & Test (macos-latest):
src/ExcelReader.Core/Writer/XlsbWorkbookWriter.cs#L259
Use Task.ConfigureAwait(false) if the current SynchronizationContext is not needed (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0004.md)
|
|
Build & Test (macos-latest):
src/ExcelReader.Core/Writer/XlsbWorkbookWriter.cs#L257
Blocking call 'entry.Open' can cause deadlocks in async code. Use 'OpenAsync' instead. (https://github.com/semihokur/AsyncFixer#asyncfixer02)
|
|
Build & Test (macos-latest):
src/ExcelReader.Core/Writer/XlsbWorkbookWriter.cs#L246
Consider using CollectionsMarshal.AsSpan() instead of foreach with List<ExcelReader.Core.Writer.XlsbSheetWriter> (https://github.com/NetFabric/NetFabric.Hyperlinq.Analyzer/tree/master/docs/reference/HLQ012_UseCollectionsMarshalAsSpanAnalyzer.md)
|
|
Build & Test (macos-latest):
src/ExcelReader.Core/Writer/XlsbWorkbookWriter.cs#L208
Loop should be simplified by calling Select(sheet => sheet.SheetId))
|
|
Build & Test (macos-latest):
src/ExcelReader.Core/Writer/XlsbWorkbookWriter.cs#L208
Consider using CollectionsMarshal.AsSpan() instead of foreach with List<ExcelReader.Core.Writer.XlsbSheetWriter> (https://github.com/NetFabric/NetFabric.Hyperlinq.Analyzer/tree/master/docs/reference/HLQ012_UseCollectionsMarshalAsSpanAnalyzer.md)
|
|
Build & Test (macos-latest):
src/ExcelReader.Core/Writer/XlsbWorkbookWriter.cs#L189
Consider using CollectionsMarshal.AsSpan() instead of foreach with List<ExcelReader.Core.Writer.XlsbSheetWriter> (https://github.com/NetFabric/NetFabric.Hyperlinq.Analyzer/tree/master/docs/reference/HLQ012_UseCollectionsMarshalAsSpanAnalyzer.md)
|
|
Build & Test (macos-latest):
src/ExcelReader.Core/Writer/XlsbWorkbookWriter.cs#L127
Consider using CollectionsMarshal.AsSpan() instead of foreach with List<ExcelReader.Core.Writer.XlsbSheetWriter> (https://github.com/NetFabric/NetFabric.Hyperlinq.Analyzer/tree/master/docs/reference/HLQ012_UseCollectionsMarshalAsSpanAnalyzer.md)
|
|
Build & Test (macos-latest):
src/ExcelReader.Core/Writer/XlsbWorkbookWriter.cs#L117
Consider using CollectionsMarshal.AsSpan() instead of foreach with List<ExcelReader.Core.Writer.XlsbSheetWriter> (https://github.com/NetFabric/NetFabric.Hyperlinq.Analyzer/tree/master/docs/reference/HLQ012_UseCollectionsMarshalAsSpanAnalyzer.md)
|
|
Build & Test (macos-latest):
src/ExcelReader.Core/Writer/XlsbSheetWriter.cs#L14
Remove this unread private field '_rowNumber' or refactor the code to use its value.
|
|
Build & Test (ubuntu-latest):
src/ExcelReader.Core/Reader/XlsReader.cs#L119
'XlsReader.GetAsyncEnumerator(CancellationToken)' synchronously blocks. Await 'XlsReader.GetAsyncEnumeratorAsync(CancellationToken)' instead. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1849)
|
|
Build & Test (ubuntu-latest):
src/ExcelReader.Core/Reader/XlsReader.cs#L114
Call System.IDisposable.Dispose on object created by 'new Enumerator(this, _sheets[_current].Offset, ct)' before all references to it are out of scope (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2000)
|
|
Build & Test (ubuntu-latest):
src/ExcelReader.Core/Writer/XlsbRowWriter.cs#L111
Use 'ArgumentOutOfRangeException.ThrowIfNegative' instead of explicitly throwing a new exception instance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1512)
|
|
Build & Test (ubuntu-latest):
src/ExcelReader.Core/Writer/XlsbSheetWriter.cs#L13
'XlsbSheetWriter' contains field '_records' that is of IDisposable type 'BiffBuffer', but it is never disposed. Change the Dispose method on 'XlsbSheetWriter' to call Close or Dispose on this field. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2213)
|
|
Build & Test (ubuntu-latest):
src/ExcelReader.Core/Writer/XlsbWorkbookWriter.cs#L127
Consider using CollectionsMarshal.AsSpan() instead of foreach with List<ExcelReader.Core.Writer.XlsbSheetWriter> (https://github.com/NetFabric/NetFabric.Hyperlinq.Analyzer/tree/master/docs/reference/HLQ012_UseCollectionsMarshalAsSpanAnalyzer.md)
|
|
Build & Test (ubuntu-latest):
src/ExcelReader.Core/Writer/XlsbWorkbookWriter.cs#L117
Consider using CollectionsMarshal.AsSpan() instead of foreach with List<ExcelReader.Core.Writer.XlsbSheetWriter> (https://github.com/NetFabric/NetFabric.Hyperlinq.Analyzer/tree/master/docs/reference/HLQ012_UseCollectionsMarshalAsSpanAnalyzer.md)
|
|
Build & Test (ubuntu-latest):
src/ExcelReader.Core/Writer/XlsbSheetWriter.cs#L58
Call System.IDisposable.Dispose on object created by 'new XlsbRowWriter(this, _records, _date1904)' before all references to it are out of scope (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2000)
|
|
Build & Test (ubuntu-latest):
src/ExcelReader.Core/Parser/Internal/ExcelEnumerable.cs#L125
Method 'ExcelReader.Core.Parser.Internal.ExcelEnumerable<T, TReader, TEnumerator>.AsyncEnumerator.AsyncEnumerator(TReader, ExcelReader.Core.Parser.Internal.TypeMapInfo<T>, System.StringComparer, ExcelReader.Core.Parser.HeaderNormalization, int, System.Threading.CancellationToken, System.IFormatProvider)' should take CancellationToken as the last parameter (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1068)
|
|
Build & Test (ubuntu-latest):
src/ExcelReader.Core/Reader/Excel.cs#L122
Use recommended dispose pattern to ensure that object created by 'new(path, FileMode.Open, FileAccess.Read, FileShare.Read, bufferSize: 65536,' is disposed on all paths. If possible, wrap the creation within a 'using' statement or a 'using' declaration. Otherwise, use a try-finally pattern, with a dedicated local variable declared before the try region and an unconditional Dispose invocation on non-null value in the 'finally' region, say 'x?.Dispose()'. If the object is explicitly disposed within the try region or the dispose ownership is transfered to another object or method, assign 'null' to the local variable just after such an operation to prevent double dispose in 'finally'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2000)
|
|
Build & Test (ubuntu-latest):
src/ExcelReader.Core/Writer/XlsbSheetWriter.cs#L14
Remove this unread private field '_rowNumber' or refactor the code to use its value.
|
|
Build & Test (windows-latest):
src/ExcelReader.Core/Writer/XlsbWorkbookWriter.cs#L269
Blocking call 'entry.Open' can cause deadlocks in async code. Use 'OpenAsync' instead. (https://github.com/semihokur/AsyncFixer#asyncfixer02)
|
|
Build & Test (windows-latest):
src/ExcelReader.Core/Writer/XlsbWorkbookWriter.cs#L257
Blocking call 'entry.Open' can cause deadlocks in async code. Use 'OpenAsync' instead. (https://github.com/semihokur/AsyncFixer#asyncfixer02)
|
|
Build & Test (windows-latest):
src/ExcelReader.Core/Writer/XlsbWorkbookWriter.cs#L246
Consider using CollectionsMarshal.AsSpan() instead of foreach with List<ExcelReader.Core.Writer.XlsbSheetWriter> (https://github.com/NetFabric/NetFabric.Hyperlinq.Analyzer/tree/master/docs/reference/HLQ012_UseCollectionsMarshalAsSpanAnalyzer.md)
|
|
Build & Test (windows-latest):
src/ExcelReader.Core/Writer/XlsbWorkbookWriter.cs#L208
Loop should be simplified by calling Select(sheet => sheet.SheetId))
|
|
Build & Test (windows-latest):
src/ExcelReader.Core/Writer/XlsbWorkbookWriter.cs#L208
Consider using CollectionsMarshal.AsSpan() instead of foreach with List<ExcelReader.Core.Writer.XlsbSheetWriter> (https://github.com/NetFabric/NetFabric.Hyperlinq.Analyzer/tree/master/docs/reference/HLQ012_UseCollectionsMarshalAsSpanAnalyzer.md)
|
|
Build & Test (windows-latest):
src/ExcelReader.Core/Writer/XlsbWorkbookWriter.cs#L189
Consider using CollectionsMarshal.AsSpan() instead of foreach with List<ExcelReader.Core.Writer.XlsbSheetWriter> (https://github.com/NetFabric/NetFabric.Hyperlinq.Analyzer/tree/master/docs/reference/HLQ012_UseCollectionsMarshalAsSpanAnalyzer.md)
|
|
Build & Test (windows-latest):
src/ExcelReader.Core/Writer/XlsbWorkbookWriter.cs#L127
Consider using CollectionsMarshal.AsSpan() instead of foreach with List<ExcelReader.Core.Writer.XlsbSheetWriter> (https://github.com/NetFabric/NetFabric.Hyperlinq.Analyzer/tree/master/docs/reference/HLQ012_UseCollectionsMarshalAsSpanAnalyzer.md)
|
|
Build & Test (windows-latest):
src/ExcelReader.Core/Writer/XlsbWorkbookWriter.cs#L117
Consider using CollectionsMarshal.AsSpan() instead of foreach with List<ExcelReader.Core.Writer.XlsbSheetWriter> (https://github.com/NetFabric/NetFabric.Hyperlinq.Analyzer/tree/master/docs/reference/HLQ012_UseCollectionsMarshalAsSpanAnalyzer.md)
|
|
Build & Test (windows-latest):
src/ExcelReader.Core/Parser/Internal/ExcelEnumerable.cs#L125
Method 'ExcelReader.Core.Parser.Internal.ExcelEnumerable<T, TReader, TEnumerator>.AsyncEnumerator.AsyncEnumerator(TReader, ExcelReader.Core.Parser.Internal.TypeMapInfo<T>, System.StringComparer, ExcelReader.Core.Parser.HeaderNormalization, int, System.Threading.CancellationToken, System.IFormatProvider)' should take CancellationToken as the last parameter (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1068)
|
|
Build & Test (windows-latest):
src/ExcelReader.Core/Writer/XlsbSheetWriter.cs#L14
Remove this unread private field '_rowNumber' or refactor the code to use its value.
|
|
Build & Test (macos-latest)
The macos-latest label will migrate to macOS 26 beginning June 15, 2026. For more information see https://github.com/actions/runner-images/issues/14167
|