☑️ Feedback and Review

[sara219]

First of all great job everyone! 👏

You should always be proud of what you made even if it not what you expected.
Everything that took your time and effort deserves to be proud of!

👉 Check this repository to see general notes that will help you when you will work on any project in the future

👇 follow the next box to read the review and feedback

[sara219]

Teamwork Feedback

• As a team, you should always trust your teammate, all of the members work together to get the final product, Therefore, harmony between team members is required.

• Always take enough time in the planning stage as it is the most important part of any project and to complete any project. All team members must participate in this stage and agree to everything that is reached.

• Always make sure that your teammate is aware of all developments that may occur during the planning.

• always go back to your lead mentors for advice when you want it.

• when you face any problem or you need help ask your teammate or ask the lead mentors (we're happy to help you anytime)

[sara219]

File Structure Review

when you start coding, the first step is to create the file structure that you already agreed on it in the planning phase.

the first pull request should be the file structure, merge it with main, and then all the team members will have it by cloning ( start coding your part after that)

index.html should be in the root only, other things should be included in folders: style (for CSS files), assets (for images)

index.html
assets/
├── img1.png
└── img.png
style/
└──style.css

[sara219]

Code Review

Code formater

Install Prettier, and make sure to activate it, it makes your code more readable and consistent with your project's style guide.

Follow one style or method to name your classes

Read this article to know more

CSS layout

when you decide to use FlexBox for layout, no need to use other methods like position or so many margins, just use it a little here and there to make the element looks good

Reset CSS

since you all want that code, push it with the file structure pull-req, to avoid duplicate and conflict