Skip to content

Commit be4b571

Browse files
committed
fix(tests): fix TypeScript errors in Skills.test.tsx
Fixed CI/CD typecheck failures caused by incorrect type imports. Changes: - Changed import from SkillData to SkillItem (correct type from @/shared/constants/skills) - Updated all SkillData[] references to SkillItem[] throughout the test file - Added explicit type annotation (: string) to keyword parameter in forEach callback Result: - TypeScript typecheck now passes (npx tsc --noEmit) - All 209 tests passing - Build successful - Lint and format checks passing
1 parent 12fb9cc commit be4b571

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

‎tests/features/skills/Skills.test.tsx‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { NextIntlClientProvider } from 'next-intl';
66
import esMessages from '../../../messages/es.json';
77
import enMessages from '../../../messages/en.json';
88
import { Skills } from '@/features/skills/Skills';
9-
import type { SkillData } from '@/shared/constants/skills';
9+
import type { SkillItem } from '@/shared/constants/skills';
1010

1111
function renderSkills(locale: 'es' | 'en' = 'es') {
1212
const messages = locale === 'es' ? esMessages : enMessages;
@@ -57,7 +57,7 @@ describe('Skills Section', () => {
5757
it('should render usage percentage label when skill has usagePercentage', () => {
5858
renderSkills();
5959
// Find skills with usagePercentage defined
60-
const skillsData = esMessages.skills.categories.flatMap((cat) => cat.skills) as SkillData[];
60+
const skillsData = esMessages.skills.categories.flatMap((cat) => cat.skills) as SkillItem[];
6161
const skillWithUsage = skillsData.find((skill) => skill.usagePercentage !== undefined);
6262

6363
if (skillWithUsage) {
@@ -77,7 +77,7 @@ describe('Skills Section', () => {
7777

7878
it('should render experience years when skill has experienceYears', () => {
7979
renderSkills();
80-
const skillsData = esMessages.skills.categories.flatMap((cat) => cat.skills) as SkillData[];
80+
const skillsData = esMessages.skills.categories.flatMap((cat) => cat.skills) as SkillItem[];
8181
const skillWithYears = skillsData.find((skill) => skill.experienceYears !== undefined);
8282

8383
if (skillWithYears) {
@@ -89,7 +89,7 @@ describe('Skills Section', () => {
8989

9090
it('should render experience projects when skill has experienceProjects', () => {
9191
renderSkills();
92-
const skillsData = esMessages.skills.categories.flatMap((cat) => cat.skills) as SkillData[];
92+
const skillsData = esMessages.skills.categories.flatMap((cat) => cat.skills) as SkillItem[];
9393
const skillWithProjects = skillsData.find((skill) => skill.experienceProjects !== undefined);
9494

9595
if (skillWithProjects) {
@@ -101,7 +101,7 @@ describe('Skills Section', () => {
101101

102102
it('should render all metadata when skill has all fields', () => {
103103
renderSkills();
104-
const skillsData = esMessages.skills.categories.flatMap((cat) => cat.skills) as SkillData[];
104+
const skillsData = esMessages.skills.categories.flatMap((cat) => cat.skills) as SkillItem[];
105105
const fullSkill = skillsData.find(
106106
(skill) =>
107107
skill.usagePercentage !== undefined &&
@@ -123,7 +123,7 @@ describe('Skills Section', () => {
123123
const { container } = renderSkills();
124124

125125
// Count how many skills have metadata sections
126-
const skillsData = esMessages.skills.categories.flatMap((cat) => cat.skills) as SkillData[];
126+
const skillsData = esMessages.skills.categories.flatMap((cat) => cat.skills) as SkillItem[];
127127
const skillsWithMetadata = skillsData.filter(
128128
(skill) =>
129129
skill.usagePercentage !== undefined ||
@@ -140,14 +140,14 @@ describe('Skills Section', () => {
140140
describe('Keywords', () => {
141141
it('should render keywords when skill has keywords array', () => {
142142
renderSkills();
143-
const skillsData = esMessages.skills.categories.flatMap((cat) => cat.skills) as SkillData[];
143+
const skillsData = esMessages.skills.categories.flatMap((cat) => cat.skills) as SkillItem[];
144144
const skillWithKeywords = skillsData.find(
145145
(skill) => skill.keywords && skill.keywords.length > 0
146146
);
147147

148148
if (skillWithKeywords) {
149149
// Should render the keyword badges
150-
skillWithKeywords.keywords?.forEach((keyword) => {
150+
skillWithKeywords.keywords?.forEach((keyword: string) => {
151151
const keywordElements = screen.queryAllByText(keyword);
152152
expect(keywordElements.length).toBeGreaterThan(0);
153153
});

0 commit comments

Comments
 (0)