remap_restarts.py error: KeyError: 'input:shared:stretch'

[metdyn]

I used main branch (7/28)
install_v5.44.4/bin/remap_restarts.py
(src/Shared/@GMAO_Shared/@GEOS_Util/pre/./remap_restart/remap_restarts.py) failed near the end (I entered the answers manually for 3 times and I didnot have a ymal file as input). I will find a yaml input to save time.

? Remap from archived GEOS-IT restarts? (Works only on NCCS/Discover.)
 No
? Enter input directory with restart files to be remapped:
 .
? Enter the restart date and hour (YYYYMMDDHH):
 2023100421
? Is the upper air input hydrostatic? (If you are not sure, don't change the default 'True')
 Yes
? Enter output directory for new restarts:
 .
? Enter atmospheric grid of input restarts:

 C12   C180    C1120
 C24   C360    C1440
 C48   C720    C2880
 C90   C1000   C5760
 C12
? Select ocean model of input restarts:
 data
? Select data ocean grid/resolution of input restarts:
 360x180   (Reynolds)
? Remap to a stretched cubed-sphere grid? No
? Enter atmospheric grid for new restarts:

 C12   C180    C1120
 C24   C360    C1440
 C48   C720    C2880
 C90   C1000   C5760
 C12
? Select ocean model for new restarts:
 data
? Select data ocean grid/resolution for new restarts:
 360x180   (Reynolds)
? Enter number of atmospheric levels for new restarts: (71 72 91 127 132 137 144 181)
 72
? Select boundary conditions (BCs) version of input restarts:


 BCs version      | ADAS tags            | GCM tags typically used with BCs version
 -----------------|----------------------|-----------------------------------------
 v12: v12         | future               | 12.0             ... present
 NL3: Icarus-NLv3 | 5_25_1 ... present   | Icarus_NL, 10.19 ... 11.7
 ICA: Icarus      | 5_17_0 ... 5_24_0_p1 | Icarus, Jason    ... 10.18
 ----------------------------------------------------------------------------------
 Other: Additional choices used in model or DAS development.
 
 NL3
? Select BCs version for new restarts:
 NL3
?
Select BCs base directory for input restarts:
 NCCS/Discover : /discover/nobackup/projects/gmao/bcs_shared/fvInput/ExtData/esm/tiles

 Intended Land BCs for input restarts: /discover/nobackup/projects/gmao/bcs_shared/fvInput/ExtData/esm/tiles/NL3/land/CF0012x6C_DE0360xPE0180

 Land BCs for input restarts: /discover/nobackup/projects/gmao/bcs_shared/fvInput/ExtData/esm/tiles/NL3/land/CF0012x6C_DE0360xPE0180
?
Select BCs base directory for new restarts:
 NCCS/Discover : /discover/nobackup/projects/gmao/bcs_shared/fvInput/ExtData/esm/tiles

 Intended Land BCs for output restarts: /discover/nobackup/projects/gmao/bcs_shared/fvInput/ExtData/esm/tiles/NL3/land/CF0012x6C_DE0360xPE0180

 Land BCs for output restarts: /discover/nobackup/projects/gmao/bcs_shared/fvInput/ExtData/esm/tiles/NL3/land/CF0012x6C_DE0360xPE0180
? Remap upper air restarts? Yes
NOTE: Different # atm levels in input and new restarts.  Cannot remap agcm_import_rst (a.k.a. IAU) file.
? Remap surface restarts? Yes
? Remap bkg files?  (Required by ADAS but not mapped onto ADAS grid; run one ADAS cycle to spin up.)  No
? Write lcv file?  (Required by ADAS.)  Yes
? Enter value of WEMIN (min. snow water equivalent parameter) used in simulation that produced input restarts.
 13
? Enter value of WEMIN (min. snow water equivalent parameter) to be used in simulation with new restarts.
 13
? Enter value of zoom parameter for surface restarts [1-8]?  (Search radius, smaller value means larger radius.)
 1
? Enter experiment ID for new restarts:  (Added as prefix to new restart file names; can leave blank.)
 C12
? Add labels for BCs version and atm/ocean resolutions to restart file names? No
? SLURM or PBS quality-of-service (qos)?      (Use default 'debug' to get resource faster; or Enter 'allnccs' for NCCS or 'normal' for NAS if resolution is c1440 o
 debug
? Select/enter SLURM or PBS account:
 yyu11
? Enter SLURM or PBS reservation: (If desired, can leave blank)
 g0613
Traceback (most recent call last):
  File "repos/br_adas/install_v5.44.4/bin/remap_restarts.py", line 139, in <module>
    main()
  File "repos/br_adas/install_v5.44.4/bin/remap_restarts.py", line 82, in main
    cmd = get_command_line_from_answers(answers)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "repos/br_adas/v5.44.4/src/Shared/@GMAO_Shared/@GEOS_Util/pre/remap_restart/remap_utils.py", line 489, in get_command_line_from_answers
    if answers["input:shared:stretch"]:
       ~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'input:shared:stretch'

[mathomp4]

@metdyn Hmm. First, it is a bit odd that your input and output directories are the same. Not the issue, but odd.

Second, I was just able to run remap_restarts just fine, but I am using what's on main. So it looks like something was fixed between then and now.

But, I took a look and I do see a possible issue. Can you try a fix? For v2.1.13 (which I think you are on), in remap_utils.py, around line 475, change:

if answers["input:shared:stretch"]:

to:

if answers.get("input:shared:stretch", False):

The complete block becomes:

in_stretch = ''
if answers.get("input:shared:stretch", False):
    in_stretch = ' -in_stretch ' + answers["input:shared:stretch"]

I think that should work? Can you test.

[metdyn]

Thank you so much, @mathomp4.
I changed the code as you suggested and the crash goes away. I got remap_params.yaml.

? Select/enter SLURM or PBS account:
 yyu11
? Enter SLURM or PBS reservation: (If desired, can leave blank)
 


 input:
    air:
       drymass: 1
       hydrostatic: True
    shared:
       MERRA-2: False
       GEOS-IT: False
       stretch: False
       omodel: data
       agrid: C12
       bc_base: discover/nobackup/projects/gmao/bcs_shared/fvInput/ExtData/esm/tiles
       bc_version: NL3
       expid: None
       ogrid: 360x180
       rst_dir: regrid_rst/temp
       yyyymmddhh: 2023100421
    surface:
       split_saltwater: True
       zoom: 1
       wemin: 13
       catch_model: False
       catch_tilefile: None
 output:
...
 slurm_pbs:
    account: yyu11
    qos: debug
    partition: compute
    reservation: 
? Above is the YAML config file, would you like to continue? (Y/n)

[mathomp4]

Hmm. Okay. So we have something. I can make a tag if needed.

Can you also try:

/discover/nobackup/mathomp4/SystemTests/builds/AGCM/CURRENT/GEOSgcm/install-Release/bin/remap_restarts.py

That's the very latest. As far as I can see, it doesn't have the "fix" I suggested for you, so it should fail, but I never see anything