From 99ff3d99ac80264e407594e4a0f0dcccf755e382 Mon Sep 17 00:00:00 2001 From: Fruktus Date: Fri, 28 Mar 2025 09:02:37 +0100 Subject: [PATCH] bugfix: fix server crash on malformed chat messages If the client sent a malformed chat message that does not match the expected pattern (username:message), the server would crash. This patch fixes it by ignoring such messages. --- server/src/QRServer/lobby/lobbyclient.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/server/src/QRServer/lobby/lobbyclient.py b/server/src/QRServer/lobby/lobbyclient.py index 74910c00..e69f6ba7 100644 --- a/server/src/QRServer/lobby/lobbyclient.py +++ b/server/src/QRServer/lobby/lobbyclient.py @@ -144,7 +144,8 @@ async def _handle_set_comment(self, message: SetCommentRequest): async def _handle_chat_message(self, message: LobbyChatMessage): await self.lobby_server.broadcast_msg(message) text = message.get_text() - message = text.split(':', 1)[1].strip() + message_parts = text.split(':', 1) + message = message_parts[1].strip() if len(message_parts) > 1 else message_parts[0].strip() if message.startswith('(COMMUNIQUE)'): return await self.webhook.invoke_webhook_lobby_message(self.player.username, message)