chore: achieve zero warnings across oxlint and typecheckers (#41)

Author: k2kirov

.changeset/hardening-phase-15-lint-hygiene.md

@@ -0,0 +1,10 @@
+---
+"@forkpoint/agent-lighthouse-core": patch
+"@forkpoint/agent-lighthouse": patch
+---
+
+Code hygiene and linter zero-warning hardening:
+- Configured `.oxlintrc.json` with ignore pattern for `.astro` templates (which are compiled and verified by `astro check`).
+- Resolved all unsafe optional chaining operations, redundant fallbacks in object spreads, and regex character escapes across core audits and test suites.
+- Removed unused imports and eliminated all compiler warnings in `content.config.ts`.
+- Brought `pnpm lint` and `pnpm typecheck` to 0 errors, 0 warnings, and 0 hints across the entire codebase.

.oxlintrc.json

@@ -0,0 +1,4 @@
+{
+  "$schema": "./node_modules/oxlint/configuration_schema.json",
+  "ignorePatterns": ["**/*.astro"]
+}

packages/cli/src/options.ts

@@ -191,7 +191,7 @@ export function parseCategoryAssertions(
   fileConfig: FileConfig & { assertCategories?: Record<string, number> } = {},
 ): Record<string, number> {
   const out: Record<string, number> = {
-    ...(fileConfig.assertCategories ?? {}),
+    ...fileConfig.assertCategories,
   };
 
   const record = (pair: string | undefined) => {

packages/core/src/audits/access-crawl-control/ai-usage-signal-coherence-across-channels.test.ts

@@ -163,7 +163,7 @@ describe("AiUsageSignalCoherenceAcrossChannelsAudit", () => {
       }),
     );
     expect(result.status).toBe("pass");
-    expect((result.details?.["notes"] as string[])[0]).toContain(
+    expect((result.details!["notes"] as string[])[0]).toContain(
       "array of rules",
     );
   });

packages/core/src/audits/access-crawl-control/aipref-content-usage-declaration-validity.test.ts

@@ -63,7 +63,7 @@ describe("AiprefContentUsageDeclarationValidityAudit", () => {
       site("User-agent: *\nAllow: /\nContent-Usage: ai-input=n\n"),
     );
     expect(result.status).toBe("fail");
-    expect((result.details?.["syntaxErrors"] as string[])[0]).toContain(
+    expect((result.details!["syntaxErrors"] as string[])[0]).toContain(
       "not an AIPREF category",
     );
   });
@@ -75,7 +75,7 @@ describe("AiprefContentUsageDeclarationValidityAudit", () => {
       site("User-agent: *\nAllow: /\nContent-Usage: train-ai=yes\n"),
     );
     expect(result.status).toBe("fail");
-    expect((result.details?.["syntaxErrors"] as string[])[0]).toContain(
+    expect((result.details!["syntaxErrors"] as string[])[0]).toContain(
       "legacy Content-Signal syntax",
     );
   });
@@ -87,7 +87,7 @@ describe("AiprefContentUsageDeclarationValidityAudit", () => {
       ),
     );
     expect(result.status).toBe("fail");
-    expect((result.details?.["inertDeclarations"] as string[])[0]).toContain(
+    expect((result.details!["inertDeclarations"] as string[])[0]).toContain(
       '"disallow: /private/"',
     );
   });
@@ -109,7 +109,7 @@ describe("AiprefContentUsageDeclarationValidityAudit", () => {
       }),
     );
     expect(result.status).toBe("fail");
-    expect((result.details?.["channelDisagreements"] as string[])[0]).toContain(
+    expect((result.details!["channelDisagreements"] as string[])[0]).toContain(
       "train-ai over /",
     );
   });

packages/core/src/audits/agent-interfaces/ai-catalog-urls.ts

@@ -56,7 +56,7 @@ async function pooled<T, R>(
   limit: number,
   worker: (item: T) => Promise<R>,
 ): Promise<R[]> {
-  const results = new Array<R>(items.length);
+  const results = Array.from<R>({ length: items.length });
   let next = 0;
   const runners = Array.from(
     { length: Math.min(limit, items.length) },

packages/core/src/audits/agent-interfaces/mcp-tool-contract-validity.ts

@@ -16,7 +16,7 @@ const MAX_PAGES = 4;
 /** Longest tool name the spec allows. */
 const MAX_NAME = 128;
 /** Tool names outside this need no escaping anywhere. */
-const NAME_PATTERN = /^[A-Za-z0-9_.\-]+$/;
+const NAME_PATTERN = /^[A-Za-z0-9_.-]+$/;
 /** RFC 9110 tchar: what a header value may be built from. */
 const TCHAR = /^[!#$%&'*+\-.^_`|~0-9A-Za-z]+$/;
 /** The only property types an `x-mcp-header` annotation may sit on. */

packages/core/src/audits/answer-readiness/chunk-boundary-referent-integrity.test.ts

@@ -100,7 +100,7 @@ describe("ChunkBoundaryReferentIntegrityAudit", () => {
     ]);
     const result = await audit.audit(ctx);
     expect(result.status).toBe("pass");
-    expect((result.details?.["entities"] as string[]).length).toBeGreaterThan(
+    expect((result.details!["entities"] as string[]).length).toBeGreaterThan(
       1,
     );
   });

packages/core/src/audits/answer-readiness/section-split-risk-profile.test.ts

@@ -101,7 +101,7 @@ describe("SectionSplitRiskProfileAudit", () => {
     const result = await audit.audit(
       page(`<h2>Boiling</h2><p>${text}</p><h2>Care</h2><p>${prose(200)}</p>`),
     );
-    const reported = Number((result.details?.["sectionTokens"] as string[])[0]);
+    const reported = Number((result.details!["sectionTokens"] as string[])[0]);
     expect(reported).toBeCloseTo(countTokens(`Boiling ${text}`), -1);
   });
 

packages/core/src/audits/answer-readiness/table-markdown-round-trip-loss.test.ts

@@ -65,7 +65,7 @@ describe("TableMarkdownRoundTripLossAudit", () => {
     );
     expect(result.status).toBe("fail");
     expect(result.details?.["headerlessNumericTables"]).toBe(1);
-    expect((result.details?.["findings"] as string[]).join(" ")).toContain(
+    expect((result.details!["findings"] as string[]).join(" ")).toContain(
       "no header cell",
     );
   });
@@ -81,7 +81,7 @@ describe("TableMarkdownRoundTripLossAudit", () => {
     );
     expect(result.status).toBe("fail");
     expect(result.details?.["strandedUnitTables"]).toBe(1);
-    expect((result.details?.["findings"] as string[]).join(" ")).toContain(
+    expect((result.details!["findings"] as string[]).join(" ")).toContain(
       "arrive unitless",
     );
   });
@@ -94,7 +94,7 @@ describe("TableMarkdownRoundTripLossAudit", () => {
       </table>`),
     );
     expect(result.details?.["blockContentCells"]).toBe(1);
-    expect((result.details?.["findings"] as string[]).join(" ")).toContain(
+    expect((result.details!["findings"] as string[]).join(" ")).toContain(
       "block content",
     );
   });
@@ -108,7 +108,7 @@ describe("TableMarkdownRoundTripLossAudit", () => {
       </table>`),
     );
     expect(result.details?.["raggedRows"]).toBe(1);
-    expect((result.details?.["findings"] as string[]).join(" ")).toContain(
+    expect((result.details!["findings"] as string[]).join(" ")).toContain(
       "declares 2 cell(s)",
     );
   });