Commit eb04dff
refactor(saml): keep the highlighted XML editor, pin it with language
Swapping the IdP metadata field to InputGroup lost syntax highlighting,
which is the reason SAML used ValueEditor in the first place: an
administrator pastes a metadata document and has to be able to read it.
Reverted, so SAML keeps the editor it has on main.
`onlyOneLang` goes instead. A caller that pins `language` has nothing to
switch to, so pinning now hides the format row and the copy control,
which is all that boolean ever did. The SAML call site loses one prop
rather than gaining one.
The InvalidJson story went with it: the warning renders against the
active format label, so a pinned story has nowhere to show it. The
browser test added in this PR covers that path instead.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent ea90fdb commit eb04dff
3 files changed
Lines changed: 41 additions & 28 deletions
File tree
- frontend
- documentation/components
- web/components
- ValueEditor
- pages/organisation-settings/tabs/sso/saml/modals
Lines changed: 12 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
55 | 54 | | |
56 | 55 | | |
57 | 56 | | |
| |||
76 | 75 | | |
77 | 76 | | |
78 | 77 | | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | 78 | | |
87 | 79 | | |
88 | 80 | | |
| |||
100 | 92 | | |
101 | 93 | | |
102 | 94 | | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
103 | 107 | | |
104 | 108 | | |
105 | 109 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | | - | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
80 | 82 | | |
81 | 83 | | |
82 | 84 | | |
| |||
Lines changed: 26 additions & 19 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
| |||
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| 19 | + | |
| 20 | + | |
18 | 21 | | |
19 | 22 | | |
20 | 23 | | |
| |||
160 | 163 | | |
161 | 164 | | |
162 | 165 | | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
172 | 185 | | |
173 | | - | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
174 | 190 | | |
175 | 191 | | |
176 | 192 | | |
| |||
204 | 220 | | |
205 | 221 | | |
206 | 222 | | |
207 | | - | |
208 | | - | |
209 | | - | |
210 | | - | |
211 | | - | |
212 | | - | |
213 | | - | |
214 | | - | |
215 | | - | |
216 | 223 | | |
217 | 224 | | |
218 | 225 | | |
| |||
0 commit comments