Skip to content

Commit ce728b4

Browse files
committed
feat: allow uppercase characters in trait keys
The trait key input rewrote keys to lowercase as you type, while the API, Edge, the engine and every SDK store and match trait keys case-sensitively. Keep replacing spaces with underscores but preserve the casing the user types, so keys like appVersion can be created and corrected from the dashboard.
1 parent e252a36 commit ce728b4

1 file changed

Lines changed: 1 addition & 7 deletions

File tree

frontend/web/components/modals/CreateTrait.tsx

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,8 @@ import React, {
88
} from 'react'
99
import Highlight from 'components/Highlight'
1010
import Constants from 'common/constants'
11-
import Format from 'common/utils/format'
1211
import ErrorMessage from 'components/ErrorMessage'
1312
import ModalHR from './ModalHR'
14-
import IdentityProvider from 'common/providers/IdentityProvider'
1513
import find from 'lodash/find'
1614
import ProjectProvider from 'common/providers/ProjectProvider'
1715
import Button from 'components/base/forms/Button'
@@ -122,11 +120,7 @@ const CreateTrait: FC<CreateTraitProps> = ({
122120
}}
123121
value={traitKey}
124122
onChange={(e: ChangeEvent<HTMLInputElement>) =>
125-
setTraitKey(
126-
Format.enumeration
127-
.set(Utils.safeParseEventValue(e))
128-
.toLowerCase(),
129-
)
123+
setTraitKey(Utils.safeParseEventValue(e).replace(/ /g, '_'))
130124
}
131125
isValid={!!traitKey && traitKey.length > 0}
132126
type='text'

0 commit comments

Comments
 (0)