Skip to content

Commit 971c82d

Browse files
talissoncostaclaude
andcommitted
fix(saml): remove the label the ValueEditor now renders
CreateSAML already had a raw <label> above the metadata editor, so giving ValueEditor a label prop rendered it twice. The raw one was decorative anyway: no htmlFor, so it named nothing. The Row keeps the download action and right-aligns it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 72b0984 commit 971c82d

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

  • frontend/web/components/pages/organisation-settings/tabs/sso/saml/modals

‎frontend/web/components/pages/organisation-settings/tabs/sso/saml/modals/CreateSAML.tsx‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -159,10 +159,9 @@ const CreateSAML: FC<CreateSAML> = ({ organisationId, samlName }) => {
159159
</div>
160160
<FormGroup className='mb-1'>
161161
<div className='mt-2 p-0'>
162-
<Row>
163-
<label className='form-label'>IdP metadata XML</label>
162+
<Row className='justify-content-end'>
164163
{data?.idp_metadata_xml && (
165-
<div className='ml-2 clickable' onClick={downloadIDPMetadata}>
164+
<div className='clickable' onClick={downloadIDPMetadata}>
166165
<Tooltip
167166
title={
168167
<IonIcon
@@ -183,7 +182,7 @@ const CreateSAML: FC<CreateSAML> = ({ organisationId, samlName }) => {
183182
((data.name && !data.idp_metadata_xml) ||
184183
data.idp_metadata_xml))) && (
185184
<ValueEditor
186-
label='IDP metadata XML'
185+
label='IdP metadata XML'
187186
data-test='featureValue'
188187
name='featureValue'
189188
className='full-width'

0 commit comments

Comments
 (0)