Fix scan timestamp

Author: emyller

api/projects/code_references/migrations/0003_introduce_per_feature_scanned_references.py

@@ -35,7 +35,6 @@ def migrate_scans_forward(apps: Apps, _: object) -> None:
     PerFeatureScan = apps.get_model("code_references", "ScannedCodeReferences")
     Repository = apps.get_model("code_references", "VCSRepository")
     Feature = apps.get_model("features", "Feature")
-    PerFeatureScan._meta.get_field("created_at").auto_now_add = False
 
     legacy_scans_summaries = LegacyScan.objects.values(
         "project_id",
@@ -179,7 +178,7 @@ class Migration(migrations.Migration):
                         verbose_name="ID",
                     ),
                 ),
-                ("created_at", models.DateTimeField(auto_now_add=True)),
+                ("created_at", models.DateTimeField()),
                 ("revision", models.CharField(max_length=100)),
                 ("code_references", models.JSONField(default=list)),
                 ("code_references_hash", models.CharField(max_length=32)),

api/projects/code_references/models.py

@@ -40,7 +40,7 @@ class ScannedCodeReferences(models.Model):
     A list of code references for a feature scanned from a VCS repository
     """
 
-    created_at = models.DateTimeField(auto_now_add=True)
+    created_at = models.DateTimeField()
 
     feature = models.ForeignKey(
         "features.Feature",

api/projects/code_references/services.py

@@ -141,6 +141,7 @@ def record_scan(
                 revision=revision,
                 code_references=references,
                 code_references_hash=_hash_references(references),
+                created_at=scanned_at,
             )
             for feature_name, references in references_by_feature.items()
             if (feature := features_by_name.get(feature_name)) is not None

api/tests/unit/features/test_unit_features_views.py

@@ -3670,41 +3670,39 @@ def test_list_features__with_code_references__returns_counts(
 ) -> None:
     # Given
     with_project_permissions([VIEW_PROJECT])  # type: ignore[call-arg]
-    with freeze_time("2099-01-01T10:00:00-0300"):
-        github_repository = VCSRepository.objects.create(
-            project=project,
-            url="https://github.flagsmith.com/backend/",
-            vcs_provider="github",
-            last_scanned_at=timezone.now(),
-        )
-        ScannedCodeReferences.objects.create(
-            feature=feature,
-            repository=github_repository,
-            revision="backend-1",
-            code_references=[
-                {"file_path": "path/to/file.py", "line_number": 42},
-            ],
-            code_references_hash="hash-backend-1",
-        )
-    with freeze_time("2099-01-02T11:00:00-0300"):
-        github_repository.last_scanned_at = timezone.now()
-        github_repository.save()
-        gitlab_repository = VCSRepository.objects.create(
-            project=project,
-            url="https://gitlab.flagsmith.com/frontend/",
-            vcs_provider="github",
-            last_scanned_at=timezone.now(),
-        )
-        ScannedCodeReferences.objects.create(
-            feature=feature,
-            repository=gitlab_repository,
-            revision="frontend-2",
-            code_references=[
-                {"file_path": "path/to/file.js", "line_number": 23},
-                {"file_path": "path/to/another/file.js", "line_number": 50},
-            ],
-            code_references_hash="hash-frontend-2",
-        )
+    github_repository = VCSRepository.objects.create(
+        project=project,
+        url="https://github.flagsmith.com/backend/",
+        vcs_provider="github",
+        last_scanned_at="2099-01-02T14:00:00+00:00",
+    )
+    ScannedCodeReferences.objects.create(
+        feature=feature,
+        repository=github_repository,
+        revision="backend-1",
+        code_references=[
+            {"file_path": "path/to/file.py", "line_number": 42},
+        ],
+        code_references_hash="hash-backend-1",
+        created_at="2099-01-01T13:00:00+00:00",
+    )
+    gitlab_repository = VCSRepository.objects.create(
+        project=project,
+        url="https://gitlab.flagsmith.com/frontend/",
+        vcs_provider="github",
+        last_scanned_at="2099-01-02T14:00:00+00:00",
+    )
+    ScannedCodeReferences.objects.create(
+        feature=feature,
+        repository=gitlab_repository,
+        revision="frontend-2",
+        code_references=[
+            {"file_path": "path/to/file.js", "line_number": 23},
+            {"file_path": "path/to/another/file.js", "line_number": 50},
+        ],
+        code_references_hash="hash-frontend-2",
+        created_at="2099-01-02T14:00:00+00:00",
+    )
 
     # When
     response = staff_client.get(f"/api/v1/projects/{project.pk}/features/")
@@ -3727,6 +3725,42 @@ def test_list_features__with_code_references__returns_counts(
     ]
 
 
+def test_list_features__scan_recorded_via_api__count_reflects_references(
+    feature: Feature,
+    project: Project,
+    admin_client_new: APIClient,
+    staff_client: APIClient,
+    with_project_permissions: WithProjectPermissionsCallable,
+) -> None:
+    # Given
+    with_project_permissions([VIEW_PROJECT])  # type: ignore[call-arg]
+    admin_client_new.post(
+        f"/api/v1/projects/{project.pk}/code-references/",
+        data={
+            "repository_url": "https://github.flagsmith.com/backend/",
+            "revision": "rev-1",
+            "code_references": [
+                {
+                    "feature_name": feature.name,
+                    "file_path": "path/to/file.py",
+                    "line_number": 42,
+                },
+            ],
+        },
+        format="json",
+    )
+
+    # When
+    response = staff_client.get(f"/api/v1/projects/{project.pk}/features/")
+
+    # Then
+    assert response.status_code == status.HTTP_200_OK
+    counts = response.json()["results"][0]["code_references_counts"]
+    assert len(counts) == 1
+    assert counts[0]["repository_url"] == "https://github.flagsmith.com/backend/"
+    assert counts[0]["count"] == 1
+
+
 @pytest.mark.usefixtures("feature")
 def test_list_features__without_code_references__returns_empty_counts(
     environment: Environment,

api/tests/unit/projects/code_references/test_unit_projects_code_references_0003_introduce_per_feature_scanned_references.py

@@ -374,6 +374,7 @@ def test_introduce_per_feature_scanned_references_backward__per_feature_row__reb
             revision="rev-1",
             code_references=[{"file_path": file_path, "line_number": 1}],
             code_references_hash=hash_id,
+            created_at=timezone.now(),
         )
 
     # When
@@ -428,14 +429,14 @@ def test_introduce_per_feature_scanned_references_backward__legacy_row__preserve
         url="https://github.flagsmith.com/backend",
         vcs_provider="github",
     )
-    with freezegun.freeze_time("2099-01-01T10:00:00+00:00"):
-        PerFeatureScan.objects.create(
-            feature=feature,
-            repository=repository,
-            revision="rev-1",
-            code_references=[{"file_path": "a.py", "line_number": 1}],
-            code_references_hash="hash-1",
-        )
+    PerFeatureScan.objects.create(
+        feature=feature,
+        repository=repository,
+        revision="rev-1",
+        code_references=[{"file_path": "a.py", "line_number": 1}],
+        code_references_hash="hash-1",
+        created_at="2099-01-01T10:00:00+00:00",
+    )
 
     # When
     reverted_state = migrator.apply_tested_migration(_INITIAL)

api/tests/unit/projects/code_references/test_unit_projects_code_references_views.py

@@ -239,6 +239,7 @@ def test_get_feature_code_references__multiple_scans_exist__returns_latest_per_r
                 {"file_path": "backend/file1.py", "line_number": 20},
             ],
             code_references_hash="hash-backend-1",
+            created_at=timezone.now(),
         )
     with freezegun.freeze_time("2099-01-02T11:00:00-0300"):
         frontend_repository = VCSRepository.objects.create(
@@ -256,6 +257,7 @@ def test_get_feature_code_references__multiple_scans_exist__returns_latest_per_r
                 {"file_path": "frontend/file2.js", "line_number": 5},
             ],
             code_references_hash="hash-frontend-2",
+            created_at=timezone.now(),
         )
 
     # When
@@ -332,6 +334,7 @@ def test_get_feature_code_references__feature_flag_removed__returns_no_entry(
                 {"file_path": "path/to/file1.py", "line_number": 10},
             ],
             code_references_hash="hash-1",
+            created_at=timezone.now(),
         )
     with freezegun.freeze_time("2099-01-02T11:00:00-0300"):
         repository.last_scanned_at = timezone.now()