Archive deprecated LaunchDarkly flags on import

Author: emyller

api/integrations/launch_darkly/constants.py

@@ -6,6 +6,7 @@
 
 LAUNCH_DARKLY_IMPORTED_TAG_COLOR = "#3d4db6"
 LAUNCH_DARKLY_IMPORTED_DEFAULT_TAG_LABEL = "Imported"
+LAUNCH_DARKLY_IMPORTED_DEPRECATED_TAG_LABEL = "Deprecated"
 
 BACKOFF_MAX_RETRIES = 5
 BACKOFF_DEFAULT_RETRY_AFTER_SECONDS = 10

api/integrations/launch_darkly/services.py

@@ -27,6 +27,7 @@
 from integrations.launch_darkly.client import LaunchDarklyClient
 from integrations.launch_darkly.constants import (
     LAUNCH_DARKLY_IMPORTED_DEFAULT_TAG_LABEL,
+    LAUNCH_DARKLY_IMPORTED_DEPRECATED_TAG_LABEL,
     LAUNCH_DARKLY_IMPORTED_TAG_COLOR,
 )
 from integrations.launch_darkly.exceptions import LaunchDarklyRateLimitError
@@ -117,7 +118,11 @@ def _create_tags_from_ld(
 ) -> dict[str, Tag]:
     tags_by_ld_tag = {}
 
-    for ld_tag in (*ld_tags, LAUNCH_DARKLY_IMPORTED_DEFAULT_TAG_LABEL):
+    for ld_tag in (
+        *ld_tags,
+        LAUNCH_DARKLY_IMPORTED_DEFAULT_TAG_LABEL,
+        LAUNCH_DARKLY_IMPORTED_DEPRECATED_TAG_LABEL,
+    ):
         tags_by_ld_tag[ld_tag], _ = Tag.objects.update_or_create(
             label=ld_tag,
             project_id=project_id,
@@ -894,6 +899,8 @@ def _create_feature_from_ld(
         tags_by_ld_tag[LAUNCH_DARKLY_IMPORTED_DEFAULT_TAG_LABEL],
         *(tags_by_ld_tag[ld_tag] for ld_tag in ld_flag["tags"]),
     ]
+    if ld_flag["deprecated"]:
+        tags.append(tags_by_ld_tag[LAUNCH_DARKLY_IMPORTED_DEPRECATED_TAG_LABEL])
 
     feature, _ = Feature.objects.update_or_create(
         project_id=project_id,
@@ -902,7 +909,7 @@ def _create_feature_from_ld(
             "description": ld_flag.get("description"),
             "default_enabled": False,
             "type": feature_type,
-            "is_archived": ld_flag["archived"],
+            "is_archived": ld_flag["archived"] or ld_flag["deprecated"],
         },
     )
     feature.tags.set(tags)

api/tests/unit/integrations/launch_darkly/client_responses/get_flags.json

@@ -35,6 +35,7 @@
       "offVariation": 1,
       "onVariation": 0
     },
+    "deprecated": true,
     "description": "",
     "environments": {
       "production": {
@@ -162,6 +163,7 @@
       "offVariation": 1,
       "onVariation": 0
     },
+    "deprecated": false,
     "description": "",
     "environments": {
       "production": {
@@ -289,6 +291,7 @@
       "offVariation": 1,
       "onVariation": 0
     },
+    "deprecated": false,
     "description": "",
     "environments": {
       "production": {
@@ -420,6 +423,7 @@
       "offVariation": 1,
       "onVariation": 0
     },
+    "deprecated": false,
     "description": "",
     "environments": {
       "production": {
@@ -558,6 +562,7 @@
       "offVariation": 1,
       "onVariation": 0
     },
+    "deprecated": false,
     "description": "",
     "environments": {
       "production": {

api/tests/unit/integrations/launch_darkly/test_services.py

@@ -141,11 +141,13 @@ def test_process_import_request__success__expected_status(  # type: ignore[no-un
         ("testtag", "#3d4db6"),
         ("testtag2", "#3d4db6"),
         ("Imported", "#3d4db6"),
+        ("Deprecated", "#3d4db6"),
     }
     assert set(
         Feature.objects.filter(project=project).values_list("name", "tags__label")
     ) == {
         ("flag1", "Imported"),
+        ("flag1", "Deprecated"),
         ("flag2_value", "Imported"),
         ("flag3_multivalue", "Imported"),
         ("flag4_multivalue", "Imported"),
@@ -158,6 +160,10 @@ def test_process_import_request__success__expected_status(  # type: ignore[no-un
         ("TEST_COMBINED_TARGET", "Imported"),
     }
 
+    # Deprecated flags are archived.
+    deprecated_feature = Feature.objects.get(project=project, name="flag1")
+    assert deprecated_feature.is_archived is True
+
     # Standard feature states have expected values.
     boolean_standard_feature = Feature.objects.get(project=project, name="flag1")
     boolean_standard_feature_states_by_env_name = {

docs/docs/administration-and-security/data-management/import-from-launchdarkly.md

@@ -65,3 +65,15 @@ Multivariate LaunchDarkly flags will be imported into Flagsmith as MultiVariate
 Multivariate values will be taken from the `variations` field of within LaunchDarkly.
 
 Values set to serve when targeting is off will be imported as control values.
+
+#### Archived and deprecated flags
+
+Archived flags in LaunchDarkly are imported as archived flags in Flagsmith.
+
+Deprecated flags in LaunchDarkly are also imported as archived flags in Flagsmith. They receive a "Deprecated" tag to distinguish them from flags that were archived in LaunchDarkly.
+
+:::warning
+
+In LaunchDarkly, deprecated flags continue to evaluate normally. In Flagsmith, archived flags return fallback values. Unarchive deprecated flags after import if older application versions still request them.
+
+:::