Improve max file path setting

Author: emyller

api/projects/code_references/constants.py

@@ -1,2 +1,5 @@
 # TODO: Implement history cleanup?
 FEATURE_FLAG_CODE_REFERENCES_RETENTION_DAYS = 30
+
+# Linux maximum file path length, as per limits.h/PATH_MAX
+MAX_FILE_PATH_LENGTH = 4096

api/projects/code_references/serializers.py

@@ -1,5 +1,6 @@
 from rest_framework import serializers
 
+from projects.code_references.constants import MAX_FILE_PATH_LENGTH
 from projects.code_references.models import FeatureFlagCodeReferencesScan
 from projects.code_references.types import (
     CodeReference,
@@ -10,7 +11,7 @@
 
 
 class _BaseCodeReferenceSerializer(serializers.Serializer[CodeReference]):
-    file_path = serializers.CharField(max_length=260)  # Windows' MAX_PATH
+    file_path = serializers.CharField(max_length=MAX_FILE_PATH_LENGTH)
     line_number = serializers.IntegerField(min_value=1)
 
 

api/tests/unit/projects/code_references/test_unit_projects_code_references_views.py

@@ -146,7 +146,7 @@ def test_CodeReferenceCreateAPIView__responds_400_when_file_path_too_long(
             "code_references": [
                 {
                     "feature_name": "feature-1",
-                    "file_path": "windows/limit/" * 100 + "file.py",
+                    "file_path": "would/you/even/" * 1000 + "file.py",
                     "line_number": 10,
                 },
             ],
@@ -158,7 +158,7 @@ def test_CodeReferenceCreateAPIView__responds_400_when_file_path_too_long(
     assert response.status_code == 400
     assert response.data == {
         "code_references": [
-            {"file_path": ["Ensure this field has no more than 260 characters."]}
+            {"file_path": ["Ensure this field has no more than 4096 characters."]}
         ],
     }
     assert not FeatureFlagCodeReferencesScan.objects.exists()