fix: queue membership count refreshes for cohort segments (#8438)

Co-authored-by: flagsmith-engineering[bot] <flagsmith-engineering[bot]@users.noreply.github.com>

Author: gagantrivedi

api/cohorts/services.py

@@ -4,6 +4,7 @@
 from uuid import UUID
 
 import structlog
+from django.conf import settings
 from django.db import transaction
 from django.db.models import F, QuerySet
 from django.utils import timezone
@@ -158,6 +159,13 @@ def create_cohort(
         project__id=environment.project_id,
         organisation__id=environment.project.organisation_id,
     )
+    if settings.CLICKHOUSE_ENABLED:
+        from segment_membership.services import enqueue_membership_refresh
+
+        # The segment is created directly rather than through the segment
+        # serializer, which is where membership count refreshes are normally
+        # queued from.
+        enqueue_membership_refresh(environment.project)
     return cohort
 
 

api/tests/unit/cohorts/test_services.py

@@ -2,6 +2,7 @@
 
 import pytest
 from flag_engine.segments.constants import IS_SET
+from pytest_django.fixtures import SettingsWrapper
 from pytest_mock import MockerFixture
 from pytest_structlog import StructuredLogCapture
 from rest_framework.exceptions import ValidationError
@@ -546,3 +547,21 @@ def test_sync_cohort_memberships_from_csv__edge_cohort__applies_traits(
     assert document["system_traits"] == {edge_cohort.system_trait_key: True}
     membership = CohortMembership.objects.get(cohort=edge_cohort)
     assert membership.state == CohortMembershipState.APPLIED
+
+
+def test_create_cohort__clickhouse_enabled__queues_membership_refresh(
+    environment: Environment,
+    settings: SettingsWrapper,
+    mocker: MockerFixture,
+) -> None:
+    # Given
+    settings.CLICKHOUSE_ENABLED = True
+    enqueue_mock = mocker.patch(
+        "segment_membership.services.enqueue_membership_refresh"
+    )
+
+    # When
+    create_cohort(environment=environment, name="Beta users")
+
+    # Then
+    enqueue_mock.assert_called_once_with(environment.project)

docs/docs/deployment-self-hosting/observability/_events-catalogue.md

@@ -74,7 +74,7 @@ Attributes:
 ### `cohorts.cohort.created`
 
 Logged at `info` from:
- - `api/cohorts/services.py:153`
+ - `api/cohorts/services.py:154`
 
 Attributes:
  - `cohort.id`
@@ -86,7 +86,7 @@ Attributes:
 ### `cohorts.cohort.deleted`
 
 Logged at `info` from:
- - `api/cohorts/services.py:459`
+ - `api/cohorts/services.py:467`
 
 Attributes:
  - `cohort.id`
@@ -95,7 +95,7 @@ Attributes:
 ### `cohorts.cohort.deletion_requested`
 
 Logged at `info` from:
- - `api/cohorts/services.py:443`
+ - `api/cohorts/services.py:451`
 
 Attributes:
  - `cohort.id`
@@ -104,7 +104,7 @@ Attributes:
 ### `cohorts.csv.synced`
 
 Logged at `info` from:
- - `api/cohorts/services.py:415`
+ - `api/cohorts/services.py:423`
 
 Attributes:
  - `adds.count`
@@ -117,7 +117,7 @@ Attributes:
 ### `cohorts.membership.adds_received`
 
 Logged at `info` from:
- - `api/cohorts/services.py:266`
+ - `api/cohorts/services.py:274`
 
 Attributes:
  - `cohort.id`
@@ -127,7 +127,7 @@ Attributes:
 ### `cohorts.membership.applied`
 
 Logged at `info` from:
- - `api/cohorts/services.py:104`
+ - `api/cohorts/services.py:105`
 
 Attributes:
  - `adds.count`
@@ -155,7 +155,7 @@ Attributes:
 ### `cohorts.membership.removals_received`
 
 Logged at `info` from:
- - `api/cohorts/services.py:291`
+ - `api/cohorts/services.py:299`
 
 Attributes:
  - `cohort.id`