feat: replaced-flagsmith-id-with-id

Author: Zaimwa9

lib/flagsmith.rb

@@ -214,8 +214,8 @@ def get_identity_segments(identifier, traits = {})
 
       evaluation_result = Flagsmith::Engine.get_evaluation_result(context)
       evaluation_result[:segments].filter_map do |segment_result|
-        flagsmith_id = segment_result.dig(:metadata, :flagsmith_id)
-        Flagsmith::Segments::Segment.new(id: flagsmith_id, name: segment_result[:name]) if flagsmith_id
+        id = segment_result.dig(:metadata, :id)
+        Flagsmith::Segments::Segment.new(id: id, name: segment_result[:name]) if id
       end
     end
 

lib/flagsmith/engine/mappers/environment.rb

@@ -26,7 +26,7 @@ def self.build_feature_hash(feature_state)
             name: feature_state.feature.name,
             enabled: feature_state.enabled,
             value: feature_state.get_value,
-            metadata: { flagsmith_id: feature_state.feature.id }
+            metadata: { id: feature_state.feature.id }
           }
           add_variants_to_feature(feature_hash, feature_state)
           add_priority_to_feature(feature_hash, feature_state)

lib/flagsmith/engine/mappers/identity.rb

@@ -52,7 +52,7 @@ def self.build_overrides_key(identity_features)
               enabled: feature_state.enabled,
               value: feature_state.get_value,
               priority: Mappers::STRONGEST_PRIORITY,
-              metadata: { flagsmith_id: feature_state.feature.id }
+              metadata: { id: feature_state.feature.id }
             }
           end
         end

lib/flagsmith/engine/mappers/segments.rb

@@ -21,7 +21,7 @@ def self.build_segment_hash(segment)
             overrides: build_overrides(segment.feature_states),
             metadata: {
               source: 'API',
-              flagsmith_id: segment.id
+              id: segment.id
             }
           }
         end
@@ -33,7 +33,7 @@ def self.build_overrides(feature_states) # rubocop:disable Metrics/MethodLength
               name: feature_state.feature.name,
               enabled: feature_state.enabled,
               value: feature_state.get_value,
-              metadata: { flagsmith_id: feature_state.feature.id }
+              metadata: { id: feature_state.feature.id }
             }
             add_priority_to_override(override_hash, feature_state)
             override_hash

lib/flagsmith/sdk/models/flags.rb

@@ -176,24 +176,24 @@ def from_api(json_data, **args)
 
         def from_evaluation_result(evaluation_result, **args)
           to_flag_object = lambda { |flag_result, acc|
-            flagsmith_id = flag_result.dig(:metadata, :flagsmith_id)
-            if flagsmith_id.nil?
+            id = flag_result.dig(:metadata, :id)
+            if id.nil?
               raise Flagsmith::ClientError,
-                    "FlagResult metadata.flagsmith_id is missing for feature \"#{flag_result[:name]}\". This indicates a bug in the SDK, please report it."
+                    "FlagResult metadata.id is missing for feature \"#{flag_result[:name]}\". This indicates a bug in the SDK, please report it."
             end
 
-            acc[flag_result[:name]] = Collection.map_evaluated_flag_to_flag_result(flag_result, flagsmith_id)
+            acc[flag_result[:name]] = Collection.map_evaluated_flag_to_flag_result(flag_result, id)
           }
 
           new(evaluation_result[:flags].each_value.each_with_object({}, &to_flag_object), **args)
         end
 
-        def map_evaluated_flag_to_flag_result(flag_result, flagsmith_id)
+        def map_evaluated_flag_to_flag_result(flag_result, id)
           Flagsmith::Flags::Flag.new(
             feature_name: flag_result[:name],
             enabled: flag_result[:enabled],
             value: flag_result[:value],
-            feature_id: flagsmith_id,
+            feature_id: id,
             reason: flag_result[:reason]
           )
         end

spec/engine/unit/evaluation_context_mappers_spec.rb

@@ -33,7 +33,7 @@
       expect(segment[:rules].length).to eq(1)
       expect(segment[:overrides]).to be_empty.or be_an(Array)
       expect(segment[:metadata][:source]).to eq('API')
-      expect(segment[:metadata][:flagsmith_id]).to eq(1)
+      expect(segment[:metadata][:id]).to eq(1)
 
       # Verify segment rules
       expect(segment[:rules][0][:type]).to eq('ALL')
@@ -72,7 +72,7 @@
       expect(override[:enabled]).to be false
       expect(override[:value]).to eq('some-overridden-value')
       expect(override[:priority]).to eq(Flagsmith::Engine::Mappers::STRONGEST_PRIORITY)
-      expect(override[:metadata][:flagsmith_id]).to eq(1)
+      expect(override[:metadata][:id]).to eq(1)
 
       # Verify features
       expect(context[:features]).to be_a(Hash)
@@ -83,7 +83,7 @@
       expect(some_feature[:enabled]).to be true
       expect(some_feature[:value]).to eq('some-value')
       expect(some_feature[:priority]).to be_nil
-      expect(some_feature[:metadata][:flagsmith_id]).to eq(1)
+      expect(some_feature[:metadata][:id]).to eq(1)
 
       # Verify multivariate feature
       expect(context[:features]).to have_key('test_mv')