fix: flag list display polish

Address flag list feedback (applied consistently to flag get and segment
detail where the same fields appear):

- feature type shown lower-case (standard/multivariate, not STANDARD)
- the ENABLED true/false column is now STATE on/off
- long values are truncated in the table (values can be huge); the detail
  views still show the full value
- a null identity-override count (Edge/Dynamo projects) shows 0, not -

beep boop

Author: khvn26

internal/cmd/cmd_test.go

@@ -1637,8 +1637,8 @@ func TestFlagsList(t *testing.T) {
 			t.Fatalf("flags list: %v\noutput: %s", err, out)
 		}
 		for _, want := range []string{
-			"NAME", "TYPE", "ENABLED", "VALUE", "LIFECYCLE",
-			"onboarding_banner", "STANDARD", "true", "live",
+			"NAME", "TYPE", "STATE", "VALUE", "LIFECYCLE",
+			"onboarding_banner", "standard", "on", "live",
 			"max_items", "25", "2 flags",
 		} {
 			if !strings.Contains(out, want) {
@@ -1732,6 +1732,34 @@ func TestFlagsList(t *testing.T) {
 			t.Errorf("err = %v, want a missing-environment error", err)
 		}
 	})
+
+	t.Run("off state and a truncated long value", func(t *testing.T) {
+		// Given a disabled flag with a very long value
+		isolateStorage(t)
+		f := newFakeInstance(t)
+		long := strings.Repeat("x", 200)
+		f.features["101"] = []map[string]any{{
+			"id": 1, "name": "blob", "type": "MULTIVARIATE",
+			"environment_feature_state": map[string]any{"enabled": false, "feature_state_value": long},
+		}}
+		root := tempRepo(t)
+		writeConfig(t, root, `{"project": 101, "environment": "WqXhZk8sVY3dGgTqZ9pJmN", "apiUrl": "`+f.srv.URL+`"}`)
+		t.Setenv("FLAGSMITH_API_KEY", masterKey)
+
+		// When
+		out, err := run("", "flag", "list")
+
+		// Then — off, lower-case type, and no full 200-char value
+		if err != nil {
+			t.Fatalf("flags list: %v", err)
+		}
+		if !strings.Contains(out, "off") || !strings.Contains(out, "multivariate") || !strings.Contains(out, "…") {
+			t.Errorf("output = %q, want off/multivariate/truncation", out)
+		}
+		if strings.Contains(out, long) {
+			t.Errorf("output = %q, want the long value truncated", out)
+		}
+	})
 }
 
 func TestFlagGet(t *testing.T) {
@@ -1800,6 +1828,31 @@ func TestFlagGet(t *testing.T) {
 			t.Errorf("err = %v, want a not-found error naming the feature", err)
 		}
 	})
+
+	t.Run("a null identity-override count shows 0", func(t *testing.T) {
+		// Given num_identity_overrides is null (Edge/Dynamo projects)
+		isolateStorage(t)
+		f := newFakeInstance(t)
+		f.features["101"] = []map[string]any{{
+			"id": 1, "name": "edgeflag", "type": "STANDARD",
+			"num_segment_overrides": 0, "num_identity_overrides": nil,
+			"environment_feature_state": map[string]any{"enabled": true, "feature_state_value": "x"},
+		}}
+		root := tempRepo(t)
+		writeConfig(t, root, `{"project": 101, "environment": "WqXhZk8sVY3dGgTqZ9pJmN", "apiUrl": "`+f.srv.URL+`"}`)
+		t.Setenv("FLAGSMITH_API_KEY", masterKey)
+
+		// When
+		out, err := run("", "flag", "get", "edgeflag")
+
+		// Then — shown as 0, not "-"
+		if err != nil {
+			t.Fatalf("flag get: %v", err)
+		}
+		if !strings.Contains(out, "Identity overrides") || !strings.Contains(out, "0") {
+			t.Errorf("output = %q, want Identity overrides 0", out)
+		}
+	})
 }
 
 // flagUpdateEnv writes a config bound to project 101 / Development and returns
@@ -1959,7 +2012,7 @@ func TestFlagGetSegment(t *testing.T) {
 		if got := f.featuresSeg(); got != "12" {
 			t.Errorf("features segment = %q, want 12", got)
 		}
-		for _, want := range []string{"Segment", "12", "special", "true"} {
+		for _, want := range []string{"Segment", "12", "special", "on"} {
 			if !strings.Contains(out, want) {
 				t.Errorf("output = %q, want %q", out, want)
 			}

internal/cmd/flags.go

@@ -28,6 +28,33 @@ func flagEnabled(fs *api.FeatureState) bool {
 	return fs != nil && fs.Enabled
 }
 
+// stateLabel renders a flag's on/off state.
+func stateLabel(fs *api.FeatureState) string {
+	if flagEnabled(fs) {
+		return "on"
+	}
+	return "off"
+}
+
+// featureTypeLabel lower-cases the feature type for display (the API returns
+// e.g. STANDARD / MULTIVARIATE).
+func featureTypeLabel(t string) string {
+	return strings.ToLower(t)
+}
+
+// valueDisplayMax bounds how wide a flag value is shown in the list table;
+// values can be very large (JSON blobs, long strings).
+const valueDisplayMax = 40
+
+// truncateValue shortens an over-long value for table display, marking the cut.
+func truncateValue(s string) string {
+	r := []rune(s)
+	if len(r) <= valueDisplayMax {
+		return s
+	}
+	return string(r[:valueDisplayMax-1]) + "…"
+}
+
 // flagContext resolves the credential, project, and environment every flag
 // command needs.
 func flagContext(cmd *cobra.Command) (*projectContext, *activeCredential, int, api.Environment, error) {
@@ -71,13 +98,13 @@ var flagListCmd = &cobra.Command{
 			for i, f := range features {
 				rows[i] = []string{
 					f.Name,
-					f.Type,
-					strconv.FormatBool(flagEnabled(f.EnvironmentState)),
-					flagValue(f.EnvironmentState),
+					featureTypeLabel(f.Type),
+					stateLabel(f.EnvironmentState),
+					truncateValue(flagValue(f.EnvironmentState)),
 					lifecycleOrDash(f.LifecycleStage),
 				}
 			}
-			if err := output.Table(w, []string{"NAME", "TYPE", "ENABLED", "VALUE", "LIFECYCLE"}, rows); err != nil {
+			if err := output.Table(w, []string{"NAME", "TYPE", "STATE", "VALUE", "LIFECYCLE"}, rows); err != nil {
 				return err
 			}
 			fmt.Fprintf(w, "\n%d %s\n", len(features), plural(len(features), "flag", "flags"))
@@ -134,9 +161,9 @@ func renderSegmentDetail(cmd *cobra.Command, feature *api.Feature, segmentID int
 	return output.Render(cmd.OutOrStdout(), feature, outputOpts(), func(w io.Writer) error {
 		return output.Detail(w, []output.Field{
 			{Label: "Feature", Value: feature.Name},
-			{Label: "Type", Value: feature.Type},
+			{Label: "Type", Value: featureTypeLabel(feature.Type)},
 			{Label: "Segment", Value: strconv.Itoa(segmentID)},
-			{Label: "Enabled", Value: strconv.FormatBool(flagEnabled(feature.SegmentState))},
+			{Label: "State", Value: stateLabel(feature.SegmentState)},
 			{Label: "Value", Value: flagValue(feature.SegmentState)},
 		})
 	})
@@ -148,8 +175,8 @@ func renderFlagDetail(cmd *cobra.Command, feature *api.Feature) error {
 		return output.Detail(w, []output.Field{
 			{Label: "Feature", Value: feature.Name},
 			{Label: "Description", Value: feature.Description},
-			{Label: "Type", Value: feature.Type},
-			{Label: "Enabled", Value: strconv.FormatBool(flagEnabled(feature.EnvironmentState))},
+			{Label: "Type", Value: featureTypeLabel(feature.Type)},
+			{Label: "State", Value: stateLabel(feature.EnvironmentState)},
 			{Label: "Value", Value: flagValue(feature.EnvironmentState)},
 			{Label: "Segment overrides", Value: strconv.Itoa(feature.NumSegmentOverrides)},
 			{Label: "Identity overrides", Value: identityOverrides(feature.NumIdentityOverrides)},
@@ -168,7 +195,7 @@ func lifecycleOrDash(stage string) string {
 
 func identityOverrides(n *int) string {
 	if n == nil {
-		return "-" // Edge/Dynamo projects do not report this
+		return "0" // Edge/Dynamo projects do not report a count
 	}
 	return strconv.Itoa(*n)
 }