Do not contribute code that was AI-generated or written with heavy AI-assistance. No exceptions. This plugin directly controls player actions in game and AI-generated code could cause player actions that are non-compliant with the FFXIV server.
Adding new methods/functions should be done in their proper sections to allow for broader use across the plugin. For example; A method for tracking party buffs would go in CustomRotation_OtherInfo to allow other rotations to take advantage of that code.
Plugin code outside of actual rotation logic effects all job and duty rotations, please avoid making broad changes to those systems without extensive testing.
Changes to code in RebornRotations should be tested with the Stone Sky Sea trials at level 60, 70, 80, 90 and 100, as RebornRotations need to be functional and performant at all levels.
Building the solution after making changes should not add any Errors, Warnings, or Messages in your IDE. No major code style changes please.
Please feel free to:
- Status ID corrections
- Additions to the various lists for Invuln, AOE, Pyretic, etc.
- Spelling corrections in UI
When opening a pull request for the first time please note that you've read and acknowledged this document.