Skip to content

PHP-Doc-Tags #57

Description

@Gummibeer
  • FACT-Finder PHP Library version: 1.2.5+src

  • PHP version: PHP 7.0.25

  • Expected behavior:
    PhpStorm, doc-tag for \FACTFinder\Adapter\Suggest::getSuggestions() returns \FACTFinder\Data\SuggestQuery[].

  • Actual behavior:
    PhpStorm, doc-tag for \FACTFinder\Adapter\Suggest::getSuggestions() returns \FACTFinder\Adapter\FACTFinder\Data\SuggestQuery[].

Expected \FACTFinder\Data\SuggestQuery[], got \FACTFinder\Adapter\FACTFinder\Data\SuggestQuery[]

  • Steps to reproduce:
use FACTFinder\Data\SuggestQuery;

class MyClass {
    /**
     * @param SuggestQuery[] $suggestions
     */
    private function myFnc1($suggestions)
    {
        // ...
    }

    private function myFnc2()
    {
        $suggest = new Suggest();
        $this->myFnc1($suggest->getSuggestions());
    }
}

In general are a lot of the doc-tags not right:

  • namespaces relative for php-doc-tag but absolute written
  • missing @param and @return but sometimes also too much from older versions

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions