perf(init): drop redundant setAllKeys() before cache.hydrate()

Author: WojtekBoman

lib/Onyx.ts

@@ -109,7 +109,7 @@ function init({
 
     // Initialize all of our keys with data provided then give green light to any pending connections.
     // addEvictableKeysToRecentlyAccessedList must run after initializeWithDefaultKeyStates because
-    // eager cache loading populates the key index (cache.setAllKeys) inside initializeWithDefaultKeyStates,
+    // eager cache loading populates the key index (cache.hydrate) inside initializeWithDefaultKeyStates,
     // and the evictable keys list depends on that index being populated.
     OnyxUtils.initializeWithDefaultKeyStates()
         .then(() => cache.addEvictableKeysToRecentlyAccessedList(OnyxKeys.isCollectionKey, OnyxUtils.getAllKeys))

lib/OnyxUtils.ts

@@ -1042,7 +1042,8 @@ function initializeWithDefaultKeyStates(): Promise<void> {
             // Load all storage data into cache silently (no subscriber notifications).
             // hydrate() rather than merge(): the cache is empty at this point, so a per-key fastMerge
             // would only deep-clone every row it was handed.
-            cache.setAllKeys(Object.keys(allDataFromStorage));
+            // No setAllKeys() call is needed: hydrate() calls addKey() for every key, which populates the
+            // key index and registers collection member keys itself.
             cache.hydrate(allDataFromStorage);
 
             // For keys that have a developer-defined default (via `initialKeyStates`), merge the