Adapt app to the Onyx store-based engine swap (PR 5)

Point at the PR 5 library (engine swap onto OnyxStore) and reconcile the two
options it removes:
- Drop `reuseConnection` from the SequentialQueue connect (the new registry does
  not pool connections).
- Remove the remaining `waitForCollectionCallback` usages in the snapshot-mode
  connects that landed on main after the PR 1 migration.

The PR 1/2/3 app migrations (waitForCollectionCallback, sourceValue, dependencies)
are cherry-picked onto this branch since the PR 5 library stacks them.

(cherry picked from commit 14395d8)

Author: fabioh8010

package-lock.json

@@ -198,7 +198,7 @@
     "react-native-nitro-fetch": "1.5.4",
     "react-native-nitro-modules": "0.36.3",
     "react-native-nitro-sqlite": "9.6.0",
-    "react-native-onyx": "3.0.95",
+    "react-native-onyx": "git+https://github.com/Expensify/react-native-onyx.git#86e4d308c3a3dc80c0d8eb55076feb61fbdf5be6",
     "react-native-pager-view": "8.0.0",
     "react-native-pdf": "7.0.2",
     "react-native-permissions": "^5.4.0",

package.json

@@ -512,9 +512,6 @@ function flush(shouldResetPromise = true) {
     // Use connectWithoutView since this is for network queue and don't affect to any UI
     const connection = Onyx.connectWithoutView({
         key: ONYXKEYS.PERSISTED_REQUESTS,
-        // We exceptionally opt out of reusing the connection here to avoid extra callback calls due to
-        // an existing connection already made in PersistedRequests.ts.
-        reuseConnection: false,
         callback: () => {
             Log.info('[SequentialQueue] PERSISTED_REQUESTS loaded, starting process()', false, {
                 requestsLength: getAllPersistedRequests().length,

src/libs/Network/SequentialQueue.ts

@@ -719,8 +719,9 @@ describe('actions/IOU', () => {
             resetDraftTransactionsCustomUnit(undefined);
             await waitForBatchedUpdates();
             const allDraftTransactions = await getOnyxValue(ONYXKEYS.COLLECTION.TRANSACTION_DRAFT);
-            // Assuming there are no draft transactions, this should be undefined or an empty object
-            expect(allDraftTransactions).toBeUndefined();
+            // Post-init, a known-but-empty collection resolves to the frozen `{}` (the legacy
+            // `undefined`-for-empty-collection shim was removed in Onyx).
+            expect(allDraftTransactions).toEqual({});
         });
         it('should reset custom unit for a transaction', async () => {
             const transactionID = 'transaction_reset_001';

tests/actions/IOU/MoneyRequestSettersTest.ts

@@ -404,7 +404,9 @@ describe('actions/IOU', () => {
                                     Onyx.disconnect(connection);
 
                                     // Snapshot data shouldn't be updated optimistically for requestMoney when the current search query type is invoice.
-                                    expect(snapshotData).toBeUndefined();
+                                    // Post-init, a known-but-empty collection resolves to the frozen `{}` (the legacy
+                                    // `undefined`-for-empty-collection shim was removed in Onyx).
+                                    expect(snapshotData).toEqual({});
                                     resolve();
                                 },
                             });

tests/actions/IOU/RequestMoneyTest.ts

@@ -5251,7 +5251,10 @@ describe('actions/Report', () => {
 
             const reportsCollectionAfter = await getOnyxValue(`${ONYXKEYS.COLLECTION.REPORT}`);
 
-            expect(reportsCollectionAfter).toBeUndefined();
+            // Post-init, a known-but-empty collection resolves to the frozen `{}` (the legacy
+            // `undefined`-for-empty-collection shim was removed in Onyx). What we want to assert
+            // here is that no report was created — the collection has zero members.
+            expect(reportsCollectionAfter).toEqual({});
         });
     });
 

tests/actions/ReportTest.ts

@@ -76,7 +76,9 @@ describe('actions/TransactionEdit', () => {
 
                 const backups = await getOnyxValue(`${ONYXKEYS.COLLECTION.TRANSACTION_BACKUP}`);
 
-                expect(backups).toBeUndefined();
+                // Post-init, a known-but-empty collection resolves to the frozen `{}` (the legacy
+                // `undefined`-for-empty-collection shim was removed in Onyx).
+                expect(backups).toEqual({});
             });
         });
 
@@ -136,7 +138,9 @@ describe('actions/TransactionEdit', () => {
 
                 const transactions = await getOnyxValue(`${ONYXKEYS.COLLECTION.TRANSACTION}`);
 
-                expect(transactions).toBeUndefined();
+                // Post-init, a known-but-empty collection resolves to the frozen `{}` (the legacy
+                // `undefined`-for-empty-collection shim was removed in Onyx).
+                expect(transactions).toEqual({});
             });
         });