Extract getChatReportWithFallback helper

Author: VickyStash

src/components/Search/SearchList/ListItem/ActionCell/PayActionCell.tsx

@@ -14,7 +14,7 @@ import useThemeStyles from '@hooks/useThemeStyles';
 
 import {payInvoice, payMoneyRequest} from '@libs/actions/IOU/PayMoneyRequest';
 import {canIOUBePaid} from '@libs/actions/IOU/ReportWorkflow';
-import {getSearchPayOnyxData} from '@libs/actions/Search';
+import {getChatReportWithFallback, getSearchPayOnyxData} from '@libs/actions/Search';
 import getNonEmptyStringOnyxID from '@libs/getNonEmptyStringOnyxID';
 import Log from '@libs/Log';
 import {getReimbursableTotal, isIndividualInvoiceRoom, isInvoiceReport} from '@libs/ReportUtils';
@@ -150,8 +150,8 @@ function PayActionCell({isLoading, policyID, reportID, hash, amount, shouldDisab
         // The chat report is only needed for optimistic chat updates, so when it isn't loaded, pay with a fallback
         // built from the known IDs and let the server fill in the chat data.
         const fallbackChatReportID = iouReport?.chatReportID ?? iouReport?.parentReportID;
-        const fallbackChatReport = fallbackChatReportID ? {reportID: fallbackChatReportID, policyID: iouReport?.policyID ?? policyID} : undefined;
-        const chatReportForPayment = chatReport ?? fallbackChatReport;
+        const fallbackPolicyID = iouReport?.policyID ?? policyID;
+        const {chatReport: chatReportForPayment, isFallbackChatReport} = getChatReportWithFallback(chatReport, fallbackChatReportID, fallbackPolicyID);
         if (!chatReportForPayment) {
             Log.info('[SearchPay] Dropping row pay: chat report is not loaded and no chatReportID is available', false, {reportID});
             return;
@@ -161,7 +161,7 @@ function PayActionCell({isLoading, policyID, reportID, hash, amount, shouldDisab
             getCurrencyDecimals,
             paymentType: type,
             chatReport: chatReportForPayment,
-            isFallbackChatReport: !chatReport,
+            isFallbackChatReport,
             iouReport,
             introSelected,
             currentUserAccountID,

src/hooks/useSearchBulkActions.ts

@@ -25,6 +25,7 @@ import {
     getPolicyFromSearchSnapshot,
     getReportFromSearchSnapshot,
     getReportType,
+    getChatReportWithFallback,
     getSearchApproveOnyxData,
     getSearchPayOnyxData,
     getTotalFormattedAmount,
@@ -1400,23 +1401,22 @@ function useSearchBulkActions({queryJSON}: UseSearchBulkActionsParams) {
                 }
 
                 const isItemInvoice = isInvoiceReport(iouReport);
-                let chatReport = getChatReportForBulkPay(iouReport, item.chatReportID, searchData, allReports);
-                let isFallbackChatReport = false;
-                if (!chatReport) {
-                    // The chat report is only needed for optimistic chat updates, so when it isn't loaded, pay with a fallback
-                    // built from the known IDs and let the server fill in the chat data.
-                    // Invoices are the exception. They genuinely need the invoice room data such as receiver type and pay-as-business.
-                    const fallbackChatReportID = item.chatReportID ?? iouReport.chatReportID ?? iouReport.parentReportID;
-                    if (isItemInvoice || !fallbackChatReportID) {
-                        Log.info('[BulkPay] Skipping report: chat report not found in the search snapshot or Onyx', false, {
-                            reportID: item.reportID,
-                            chatReportID: fallbackChatReportID,
-                            isItemInvoice,
-                        });
-                        continue;
-                    }
-                    chatReport = {reportID: fallbackChatReportID, policyID: item.policyID ?? iouReport.policyID};
-                    isFallbackChatReport = true;
+                const fallbackChatReportID = item.chatReportID ?? iouReport.chatReportID ?? iouReport.parentReportID;
+                const fallbackPolicyID = iouReport.policyID ?? item.policyID;
+                const {chatReport, isFallbackChatReport} = getChatReportWithFallback(
+                    getChatReportForBulkPay(iouReport, item.chatReportID, searchData, allReports),
+                    fallbackChatReportID,
+                    fallbackPolicyID,
+                );
+                // The fallback covers money requests only. Invoices genuinely need the invoice room data such as
+                // receiver type and pay-as-business, so skip them when the chat isn't loaded.
+                if (!chatReport || (isItemInvoice && isFallbackChatReport)) {
+                    Log.info('[BulkPay] Skipping report: chat report not found in the search snapshot or Onyx', false, {
+                        reportID: item.reportID,
+                        chatReportID: fallbackChatReportID,
+                        isItemInvoice,
+                    });
+                    continue;
                 }
 
                 const rawPaymentMethod = paymentMethod ?? getLastPolicyPaymentMethod(item.policyID, personalPolicyID, lastPaymentMethods, undefined, isIOUReportUtil(item.reportID));

src/libs/actions/Search.ts

@@ -129,6 +129,24 @@ function getChatReportForSearchPay(chatReport: OnyxEntry<Report>, snapshotReport
     return chatReport ?? snapshotChatReport ?? (chatReportID ? getReportOrDraftReport(chatReportID) : undefined);
 }
 
+/**
+ * Returns the chat report to pay with. When the chat isn't loaded, builds a fallback from the known IDs so the
+ * payment isn't blocked; isFallbackChatReport tells payMoneyRequest to skip the optimistic chat updates.
+ */
+function getChatReportWithFallback(
+    loadedChatReport: OnyxEntry<Report>,
+    fallbackChatReportID: string | undefined,
+    fallbackPolicyID: string | undefined,
+): {chatReport: OnyxEntry<Report>; isFallbackChatReport: boolean} {
+    if (loadedChatReport) {
+        return {chatReport: loadedChatReport, isFallbackChatReport: false};
+    }
+    if (!fallbackChatReportID) {
+        return {chatReport: undefined, isFallbackChatReport: false};
+    }
+    return {chatReport: {reportID: fallbackChatReportID, policyID: fallbackPolicyID}, isFallbackChatReport: true};
+}
+
 function getReportFromSearchSnapshot(reportID: string | undefined, searchData: SearchResultDataType | undefined, allReports: OnyxCollection<Report> | undefined): OnyxEntry<Report> {
     if (!reportID) {
         return undefined;
@@ -2183,6 +2201,7 @@ export {
     setSearchContext,
     deleteSavedSearch,
     getSearchPayOnyxData,
+    getChatReportWithFallback,
     getSearchApproveOnyxData,
     handleActionButtonPress,
     submitMoneyRequestOnSearch,