Merge branch 'main' into helpsite-rename-perk

Author: stephanieelliott

.claude/skills/coding-standards/SKILL.md

@@ -44,6 +44,7 @@ Coding standards for the Expensify App. Each standard is a standalone file in `r
 - [CONSISTENCY-6](rules/consistency-6-proper-error-handling.md) — Proper error handling
 
 ### Clean React Patterns
+- [CLEAN-REACT-PATTERNS-0](rules/clean-react-0-compiler.md) — React Compiler compliance
 - [CLEAN-REACT-PATTERNS-1](rules/clean-react-1-composition-over-config.md) — Composition over configuration
 - [CLEAN-REACT-PATTERNS-2](rules/clean-react-2-own-behavior.md) — Components own their behavior
 - [CLEAN-REACT-PATTERNS-3](rules/clean-react-3-context-free-contracts.md) — Context-free component contracts

.claude/skills/coding-standards/rules/clean-react-0-compiler.md

@@ -0,0 +1,127 @@
+---
+ruleId: CLEAN-REACT-PATTERNS-0
+title: React Compiler compliance
+---
+
+## [CLEAN-REACT-PATTERNS-0] React Compiler compliance
+
+### Reasoning
+
+React Compiler is enabled in this codebase (`babel-plugin-react-compiler` runs first in both webpack and metro configs). It automatically memoizes components and hooks at the AST level — analyzing data flow, tracking dependencies, and inserting fine-grained caching that is more precise than any hand-written `useMemo`, `useCallback`, or `React.memo`.
+
+Manual memoization is therefore:
+
+1. **Redundant** — the compiler already handles it, so the manual wrapper adds zero value
+2. **Harmful** — it interferes with the compiler's optimization model, potentially preventing it from applying its own caching strategy or causing double-wrapping
+3. **Noisy** — it clutters the codebase with dependency arrays that must be maintained, reviewed, and debugged
+
+The codebase enforces this via:
+- **Babel plugin**: `babel-plugin-react-compiler` in `babel.config.js`
+- **ESLint processor**: `eslint-plugin-react-compiler-compat` suppresses redundant lint rules when files compile successfully
+- **CI compliance check**: `scripts/react-compiler-compliance-check.ts` blocks PRs with manual memoization in new files
+
+Reference: [React Compiler documentation](https://react.dev/learn/react-compiler)
+
+### Incorrect
+
+#### Incorrect (useCallback)
+
+```tsx
+function ReportScreen({reportID}: {reportID: string}) {
+    const handlePress = useCallback(() => {
+        Navigation.navigate(ROUTES.REPORT_DETAILS.getRoute(reportID));
+    }, [reportID]);
+
+    return <Button onPress={handlePress} />;
+}
+```
+
+#### Incorrect (useMemo)
+
+```tsx
+function PolicyList({policies}: {policies: Policy[]}) {
+    const sortedPolicies = useMemo(
+        () => policies.sort((a, b) => a.name.localeCompare(b.name)),
+        [policies],
+    );
+
+    return <FlatList data={sortedPolicies} renderItem={renderItem} />;
+}
+```
+
+#### Incorrect (React.memo)
+
+```tsx
+const Avatar = React.memo(function Avatar({source, size}: AvatarProps) {
+    return <Image source={source} style={getAvatarStyle(size)} />;
+});
+```
+
+### Correct
+
+#### Correct (plain function — compiler memoizes automatically)
+
+```tsx
+function ReportScreen({reportID}: {reportID: string}) {
+    const handlePress = () => {
+        Navigation.navigate(ROUTES.REPORT_DETAILS.getRoute(reportID));
+    };
+
+    return <Button onPress={handlePress} />;
+}
+```
+
+#### Correct (plain expression — compiler memoizes automatically)
+
+```tsx
+function PolicyList({policies}: {policies: Policy[]}) {
+    const sortedPolicies = policies.sort((a, b) => a.name.localeCompare(b.name));
+
+    return <FlatList data={sortedPolicies} renderItem={renderItem} />;
+}
+```
+
+#### Correct (plain component — compiler memoizes automatically)
+
+```tsx
+function Avatar({source, size}: AvatarProps) {
+    return <Image source={source} style={getAvatarStyle(size)} />;
+}
+```
+
+---
+
+### Review Metadata
+
+#### Verification
+
+Before flagging, verify that the file actually compiles with React Compiler:
+
+```bash
+npx react-compiler-healthcheck --src "<filepath>" --verbose
+```
+
+If the output contains **"Failed to compile"** for the file under review, the rule **does not apply** — the author may have no alternative to manual memoization until the compilation issue is resolved.
+
+#### Condition
+
+The verification step above is a prerequisite. Only flag when the file compiles successfully AND any of these are true in new or modified code:
+
+1. **`useCallback`** — A function is wrapped in `useCallback`. The compiler automatically memoizes closures based on their captured variables.
+2. **`useMemo`** — A value is wrapped in `useMemo`. The compiler automatically caches derived values.
+3. **`React.memo`** — A component is wrapped in `React.memo` (or `memo` imported from React). The compiler automatically skips re-rendering components whose props haven't changed.
+
+**Response:** Challenge the author: "React Compiler is enabled — remove the manual memoization and restructure the code so the compiler can handle it."
+
+The goal is to fix the root cause (make code compiler-friendly) rather than slap on manual memoization as a workaround.
+
+**Search Patterns:**
+- `useCallback\s*\(` — manual callback memoization
+- `useMemo\s*\(` — manual value memoization
+- `React\.memo\s*\(` or `memo\s*\(` — manual component memoization
+- Import statements: `useCallback`, `useMemo` from `react`
+
+**DO NOT flag if:**
+- The file does not compile with React Compiler (verified by the compliance check in the Verification section above)
+- The code is inside `node_modules/`, `patches/`, or test fixtures
+- The manual memoization exists in unchanged lines (pre-existing code not touched by the diff)

.github/ISSUE_TEMPLATE/OnboardOffboardExpertContributor.md

@@ -34,4 +34,6 @@ Which action do you wish to take for this team member (select one):
 ### Ring0 Tasks
 
 - [ ] If adding, add to the appropriate GitHub child team of [external-expert-contributors](https://github.com/orgs/Expensify/teams/external-expert-contributors/teams) (each agency must have its own child team)
+- [ ] If adding, create an [IdentityDot account](https://stackoverflowteams.com/c/expensify/questions/22914) for the contributor
 - [ ] If removing, remove from our organization [here](https://github.com/orgs/Expensify/people)
+- [ ] If removing, delete the contributor's [IdentityDot account](https://stackoverflowteams.com/c/expensify/questions/22914)

.github/actions/javascript/getPullRequestIncrementalChanges/getPullRequestIncrementalChanges.ts

@@ -1,5 +1,6 @@
 import * as core from '@actions/core';
 import {context} from '@actions/github';
+import {RequestError} from '@octokit/request-error';
 import type {PullRequestEvent, PullRequestSynchronizeEvent} from '@octokit/webhooks-types';
 import {getJSONInput} from '@github/libs/ActionUtils';
 import CONST from '@github/libs/CONST';
@@ -89,7 +90,29 @@ async function run(): Promise<void> {
 
         // Now we know there are local changes - get PR diff from the GitHub API to compare
         console.log(`🌐 Using GitHub API to validate ${localChangedFiles.size} files with local changes`);
-        const prDiff = Git.parseDiff(await GitHubUtils.getPullRequestDiff(prNumber));
+
+        let prDiffString: string;
+        try {
+            prDiffString = await GitHubUtils.getPullRequestDiff(prNumber);
+        } catch (error) {
+            const isTooLarge =
+                error instanceof RequestError &&
+                typeof error.response?.data === 'object' &&
+                error.response.data !== null &&
+                'errors' in error.response.data &&
+                ((error.response.data as {errors?: Array<{code?: string}>}).errors ?? []).some((e) => e.code === 'too_large');
+
+            if (!isTooLarge) {
+                throw error;
+            }
+
+            core.warning(`PR #${prNumber} diff is too large for the GitHub API. Skipping incremental change detection.`);
+            core.setOutput('CHANGED_FILES', JSON.stringify([]));
+            core.setOutput('HAS_CHANGES', false);
+            return;
+        }
+
+        const prDiff = Git.parseDiff(prDiffString);
 
         // Compare the local push diff with the PR diff and collect changed files, checking for overlapping content changes at the line level
         for (const prFileDiff of prDiff.files) {

.github/actions/javascript/getPullRequestIncrementalChanges/index.js

@@ -11582,6 +11582,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 const core = __importStar(__nccwpck_require__(2186));
 const github_1 = __nccwpck_require__(5438);
+const request_error_1 = __nccwpck_require__(537);
 const ActionUtils_1 = __nccwpck_require__(6981);
 const CONST_1 = __importDefault(__nccwpck_require__(9873));
 const GithubUtils_1 = __importDefault(__nccwpck_require__(9296));
@@ -11655,7 +11656,25 @@ async function run() {
         }
         // Now we know there are local changes - get PR diff from the GitHub API to compare
         console.log(`🌐 Using GitHub API to validate ${localChangedFiles.size} files with local changes`);
-        const prDiff = Git_1.default.parseDiff(await GithubUtils_1.default.getPullRequestDiff(prNumber));
+        let prDiffString;
+        try {
+            prDiffString = await GithubUtils_1.default.getPullRequestDiff(prNumber);
+        }
+        catch (error) {
+            const isTooLarge = error instanceof request_error_1.RequestError &&
+                typeof error.response?.data === 'object' &&
+                error.response.data !== null &&
+                'errors' in error.response.data &&
+                (error.response.data.errors ?? []).some((e) => e.code === 'too_large');
+            if (!isTooLarge) {
+                throw error;
+            }
+            core.warning(`PR #${prNumber} diff is too large for the GitHub API. Skipping incremental change detection.`);
+            core.setOutput('CHANGED_FILES', JSON.stringify([]));
+            core.setOutput('HAS_CHANGES', false);
+            return;
+        }
+        const prDiff = Git_1.default.parseDiff(prDiffString);
         // Compare the local push diff with the PR diff and collect changed files, checking for overlapping content changes at the line level
         for (const prFileDiff of prDiff.files) {
             const filePath = prFileDiff.filePath;

.github/scripts/createDocsRoutes.ts

@@ -12,6 +12,7 @@ type Section = {
     href: string;
     title: string;
     articles?: Article[];
+    sections?: Section[];
 };
 
 type Hub = {
@@ -61,6 +62,7 @@ function toTitleCase(str: string): string {
 
 /**
  * @param filename - The name of the file
+ * @param order - Optional order from front matter
  */
 function getArticleObj(filename: string, order?: number): Article {
     const href = filename.replace('.md', '');
@@ -94,46 +96,87 @@ function pushOrCreateEntry<TKey extends HubEntriesKey>(hubs: Hub[], hub: string,
 }
 
 function getOrderFromArticleFrontMatter(path: string): number | undefined {
-    const frontmatter = fs.readFileSync(path, 'utf8').split('---').at(1);
-    if (!frontmatter) {
-        return;
+    try {
+        const frontmatter = fs.readFileSync(path, 'utf8').split('---').at(1);
+        if (!frontmatter) {
+            return undefined;
+        }
+        const frontmatterObject = yaml.load(frontmatter) as Record<string, unknown>;
+        return frontmatterObject.order as number | undefined;
+    } catch {
+        return undefined;
+    }
+}
+
+/**
+ * Build a section from a directory path, with optional parent path for nested href
+ */
+function buildSection(platformName: string, hub: string, sectionPath: string, parentHref: string): Section {
+    const sectionName = sectionPath.split('/').pop() ?? sectionPath;
+    const fullPath = `${docsDir}/articles/${platformName}/${hub}/${sectionPath}`;
+    const articles: Article[] = [];
+    const childSections: Section[] = [];
+    const href = parentHref ? `${parentHref}/${sectionName}` : sectionName;
+
+    for (const entry of fs.readdirSync(fullPath)) {
+        const entryPath = `${fullPath}/${entry}`;
+        if (entry.endsWith('.md')) {
+            const order = getOrderFromArticleFrontMatter(entryPath);
+            articles.push(getArticleObj(entry, order));
+        } else if (fs.statSync(entryPath).isDirectory()) {
+            childSections.push(buildSection(platformName, hub, `${sectionPath}/${entry}`, href));
+        }
+    }
+
+    const section: Section = {
+        href,
+        title: toTitleCase(sectionName.replaceAll('-', ' ')),
+        ...(articles.length > 0 && {articles}),
+        ...(childSections.length > 0 && {sections: childSections}),
+    };
+    return section;
+}
+
+/**
+ * Flatten sections for lookup by full path (e.g. netsuite/troubleshooting/connection-errors)
+ */
+function flattenSections(sections: Section[]): Section[] {
+    const result: Section[] = [];
+    for (const s of sections) {
+        result.push(s);
+        if (s.sections?.length) {
+            result.push(...flattenSections(s.sections));
+        }
     }
-    const frontmatterObject = yaml.load(frontmatter) as Record<string, unknown>;
-    return frontmatterObject.order as number | undefined;
+    return result;
 }
 
 /**
  * Add articles and sections to hubs
  * @param hubs - The hubs inside docs/articles/ for a platform
  * @param platformName - Expensify Classic or New Expensify
- * @param routeHubs - The hubs insude docs/data/_routes.yml for a platform
+ * @param routeHubs - The hubs inside docs/data/_routes.yml for a platform
  */
 function createHubsWithArticles(hubs: string[], platformName: ValueOf<typeof platformNames>, routeHubs: Hub[]) {
     for (const hub of hubs) {
-        // Iterate through each directory in articles
-        for (const fileOrFolder of fs.readdirSync(`${docsDir}/articles/${platformName}/${hub}`)) {
-            // If the directory content is a markdown file, then it is an article
+        const basePath = `${docsDir}/articles/${platformName}/${hub}`;
+
+        for (const fileOrFolder of fs.readdirSync(basePath)) {
             if (fileOrFolder.endsWith('.md')) {
                 const articleObj = getArticleObj(fileOrFolder);
                 pushOrCreateEntry(routeHubs, hub, 'articles', articleObj);
                 continue;
             }
 
-            // For readability, we will use the term section to refer to subfolders
-            const section = fileOrFolder;
-            const articles: Article[] = [];
-
-            // Each subfolder will be a section containing articles
-            for (const subArticle of fs.readdirSync(`${docsDir}/articles/${platformName}/${hub}/${section}`)) {
-                const order = getOrderFromArticleFrontMatter(`${docsDir}/articles/${platformName}/${hub}/${section}/${subArticle}`);
-                articles.push(getArticleObj(subArticle, order));
-            }
+            const sectionPath = fileOrFolder;
+            const section = buildSection(platformName, hub, sectionPath, '');
+            pushOrCreateEntry(routeHubs, hub, 'sections', section);
+        }
 
-            pushOrCreateEntry(routeHubs, hub, 'sections', {
-                href: section,
-                title: toTitleCase(section.replaceAll('-', ' ')),
-                articles,
-            });
+        // Add flat section list for nested section page lookup
+        const hubObj = routeHubs.find((obj) => obj.href === hub);
+        if (hubObj?.sections?.length) {
+            (hubObj as Hub & {flatSections?: Section[]}).flatSections = flattenSections(hubObj.sections);
         }
     }
 }

.github/workflows/README.md

@@ -8,7 +8,7 @@ name: CI
 on: pull_request
 jobs:
   validate:
-    runs-on: ubuntu-latest
+    runs-on: blacksmith-2vcpu-ubuntu-2404
     steps:
       - id: myTrueAction
         uses: Expensify/my-action-outputs-true@main

.github/workflows/buildAndroid.yml

@@ -183,7 +183,7 @@ jobs:
           comment-bot: false
           rock-build-extra-params: ${{ inputs.variant == 'Adhoc' && '--extra-params "-PreactNativeArchitectures=arm64-v8a,x86_64 --profile"' || '--extra-params "--profile"' }}
           custom-identifier: ${{ steps.computeIdentifier.outputs.IDENTIFIER }}
-          validate-elf-alignment: true
+          validate-elf-alignment: ${{ inputs.variant != 'Release' && 'true' || 'false' }}
 
       - name: Upload Gradle profile report
         if: always()
@@ -283,6 +283,10 @@ jobs:
             --key-pass=pass:${{ steps.load-credentials.outputs.ANDROID_UPLOAD_KEY_PASSWORD }}
           unzip -p Expensify.apks universal.apk > Expensify.apk
 
+      - name: Validate ELF alignment for Release APK
+        if: ${{ inputs.variant == 'Release' && steps.collectArtifacts.outputs.HAS_AAB == 'true' }}
+        run: npx rock validate-elf-alignment "Expensify.apk"
+
       - name: Upload Android APK build artifact
         if: steps.collectArtifacts.outputs.HAS_AAB == 'true'
         # v6