Merge pull request #97849 from Expensify/claude-fixAIFeaturesPromoSecurityError

Fix AI Features Promo modal SecurityError from doubled-slash path and re-entrancy

Author: mountiny

src/hooks/useAIFeaturesPromoModal.ts

@@ -98,6 +98,13 @@ function useAIFeaturesPromoModal(session: OnyxEntry<Session>) {
                     if (lastRoute === NAVIGATORS.SHARE_MODAL_NAVIGATOR || lastRoute === SCREENS.NOT_FOUND) {
                         return;
                     }
+                    if (lastRoute === NAVIGATORS.AI_FEATURES_PROMO_MODAL_NAVIGATOR) {
+                        // The promo modal is already the active route (e.g. deep-linked directly). Re-navigating would
+                        // append the suffix onto a base that already ends in it, producing a duplicated
+                        // `…/ai-features-promo/ai-features-promo` path. Treat it as already shown and bail out.
+                        hasRedirectedToAIFeaturesPromoModal = true;
+                        return;
+                    }
                     Log.info('[useAIFeaturesPromoModal] Navigating to AI features promo modal');
                     hasRedirectedToAIFeaturesPromoModal = true;
                     Navigation.navigate(createDynamicRoute(DYNAMIC_ROUTES.AI_FEATURES_PROMO.path, Navigation.getActiveRoute() || ROUTES.HOME));

src/libs/Navigation/helpers/getPathFromState.ts

@@ -141,7 +141,8 @@ function getPathFromStateWithDynamicRoute(state: State): string {
             const tabPath = focusedTab && isScreen(focusedTab.name) ? normalizedConfigs[focusedTab.name]?.path : undefined;
             if (tabPath) {
                 const [suffixPathOnly, suffixQueryOnly] = splitPathAndQuery(actualSuffix);
-                actualSuffix = `${suffixPathOnly}/${tabPath}${suffixQueryOnly ? `?${suffixQueryOnly}` : ''}`;
+                const combinedSuffixPath = suffixPathOnly === '/' ? `/${tabPath}` : `${suffixPathOnly}/${tabPath}`;
+                actualSuffix = `${combinedSuffixPath}${suffixQueryOnly ? `?${suffixQueryOnly}` : ''}`;
             }
         }
     }
@@ -163,7 +164,12 @@ function getPathFromStateWithDynamicRoute(state: State): string {
     }
     const queryString = mergedParams.toString();
 
-    return `${basePathWithoutQuery}/${suffixPath}${queryString ? `?${queryString}` : ''}`;
+    // Mirror createDynamicRoute's slash handling: a root base (`/`) must not be concatenated with a leading slash,
+    // otherwise the result is a `//`-prefixed path that the browser parses as protocol-relative (host = first segment),
+    // making `history.pushState` throw a SecurityError.
+    const combinedPath = basePathWithoutQuery === '/' ? `/${suffixPath}` : `${basePathWithoutQuery}/${suffixPath}`;
+
+    return `${combinedPath}${queryString ? `?${queryString}` : ''}`;
 }
 
 function getPathFromState(state: State): string {

tests/navigation/getPathFromStateTests.ts

@@ -89,6 +89,17 @@ describe('getPathFromState', () => {
         expect(result).toBe('/settings/wallet/test-dynamic');
     });
 
+    it('root base path does not produce a doubled leading slash', () => {
+        // A base screen that resolves to root ('/') must not be concatenated with a leading slash,
+        // otherwise the result is a '//'-prefixed protocol-relative URL that makes history.pushState
+        // throw a SecurityError. Regression test for the AI Features Promo crash (issue #97470).
+        mockRNGetPathFromState.mockReturnValue('/');
+
+        const state = buildState([{name: 'StandardScreen'}, {name: 'TestDynamicScreen'}]);
+
+        expect(getPathFromState(state as PartialState<NavigationState>)).toBe('/test-dynamic');
+    });
+
     it('should use RN getPathFromState for standard screens', () => {
         const expectedPath = '/standard/path';
         mockRNGetPathFromState.mockReturnValue(expectedPath);