refactor: drop the orientation tracking from the window size change store

Author: dariusz-biela

src/libs/Navigation/PlatformStackNavigation/createPlatformStackNavigatorComponent/ScreenActivityWrapper/useIsWindowSizeChanging.ts

@@ -3,7 +3,7 @@ import {useSyncExternalStore} from 'react';
 import {getSnapshot, subscribe} from './windowSizeChangeStore';
 
 /**
- * Reports whether the window width or the orientation is changing, on both platforms. A screen hidden by
+ * Reports whether the window width is changing, on both platforms. A screen hidden by
  * <Activity> has no mounted effects, so it reads this flag to become visible for the duration of the change and
  * lay itself out while still covered. The existing useIsResizing does not fit here, because it is web only and
  * also counts the height changes the soft keyboard causes. The hook lives apart from windowSizeChangeStore because

src/libs/Navigation/PlatformStackNavigation/createPlatformStackNavigatorComponent/ScreenActivityWrapper/windowSizeChangeStore.ts

@@ -12,7 +12,6 @@ const WINDOW_SIZE_CHANGE_DURATION_MS = 250;
 
 let isWindowSizeChanging = false;
 let lastWidth = 0;
-let lastIsPortrait = true;
 let stopTimeoutID: NodeJS.Timeout | undefined;
 let dimensionsSubscription: EmitterSubscription | undefined;
 
@@ -32,31 +31,23 @@ function setIsWindowSizeChanging(value: boolean) {
     notify();
 }
 
-function isPortrait(size: ScaledSize) {
-    return size.height >= size.width;
-}
-
-function rememberWindowSize(size: ScaledSize) {
-    lastWidth = size.width;
-    lastIsPortrait = isPortrait(size);
-}
-
 function handleDimensionsChange({window}: {window: ScaledSize}) {
-    // Only width and orientation changes count, because the soft keyboard changes the window height on Android and
-    // on mobile web, and reacting to that would remount the effects of every hidden screen on each keyboard toggle.
-    if (window.width === lastWidth && isPortrait(window) === lastIsPortrait) {
+    // Only width changes count, which also covers a rotation. The soft keyboard changes the window height on
+    // Android and on mobile web, and reacting to that would remount the effects of every hidden screen on each
+    // keyboard toggle.
+    if (window.width === lastWidth) {
         return;
     }
 
-    rememberWindowSize(window);
+    lastWidth = window.width;
     setIsWindowSizeChanging(true);
     clearTimeout(stopTimeoutID);
     stopTimeoutID = setTimeout(() => setIsWindowSizeChanging(false), WINDOW_SIZE_CHANGE_DURATION_MS);
 }
 
 function subscribe(listener: () => void) {
     if (listeners.size === 0) {
-        rememberWindowSize(Dimensions.get('window'));
+        lastWidth = Dimensions.get('window').width;
         dimensionsSubscription = Dimensions.addEventListener('change', handleDimensionsChange);
     }
     listeners.add(listener);