Skip to content

Commit 94474db

Browse files
committed
fix: conflicts
2 parents 9a60915 + eb861f7 commit 94474db

647 files changed

Lines changed: 17791 additions & 7122 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/actions/javascript/markPullRequestsAsDeployed/index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12707,7 +12707,7 @@ function wrappy (fn, cb) {
1270712707
/***/ }),
1270812708

1270912709
/***/ 2483:
12710-
/***/ (function(module, exports, __nccwpck_require__) {
12710+
/***/ (function(__unused_webpack_module, exports, __nccwpck_require__) {
1271112711

1271212712
"use strict";
1271312713

@@ -12748,7 +12748,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
1274812748
return (mod && mod.__esModule) ? mod : { "default": mod };
1274912749
};
1275012750
Object.defineProperty(exports, "__esModule", ({ value: true }));
12751-
/* eslint-disable @typescript-eslint/naming-convention, import/no-import-module-exports */
12751+
/* eslint-disable @typescript-eslint/naming-convention */
1275212752
const ActionUtils = __importStar(__nccwpck_require__(6981));
1275312753
const CONST_1 = __importDefault(__nccwpck_require__(9873));
1275412754
const GithubUtils_1 = __importDefault(__nccwpck_require__(9296));
@@ -12937,7 +12937,7 @@ async function run() {
1293712937
if (require.main === require.cache[eval('__filename')]) {
1293812938
run();
1293912939
}
12940-
module.exports = run;
12940+
exports["default"] = run;
1294112941

1294212942

1294312943
/***/ }),

.github/actions/javascript/markPullRequestsAsDeployed/markPullRequestsAsDeployed.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* eslint-disable @typescript-eslint/naming-convention, import/no-import-module-exports */
1+
/* eslint-disable @typescript-eslint/naming-convention */
22
import * as ActionUtils from '@github/libs/ActionUtils';
33
import CONST from '@github/libs/CONST';
44
import GithubUtils from '@github/libs/GithubUtils';
@@ -219,4 +219,4 @@ if (require.main === module) {
219219
run();
220220
}
221221

222-
module.exports = run;
222+
export default run;

.github/workflows/authorChecklist.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
if: |
1717
github.actor != 'OSBotify'
1818
&& github.actor != 'imgbot[bot]'
19-
&& github.actor != 'melvin-bot[bot]'
19+
&& github.actor != 'MelvinBot'
2020
steps:
2121
- name: Checkout
2222
uses: useblacksmith/checkout@1c9394c220d293645707b625ba9d79685f093a8f # v1

.github/workflows/bunTests.yml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,27 @@
11
name: Bun tests
22

33
on:
4+
workflow_call:
45
pull_request:
56
types: [opened, synchronize]
67
branches-ignore: [staging, production]
78
paths:
89
- 'server/**'
910
- 'src/**'
11+
- 'tests/tooling/**'
12+
- 'tests/utils/**'
13+
- '.github/actions/javascript/**'
14+
- '.github/libs/**'
15+
- '.github/scripts/**'
16+
- 'scripts/**'
1017
- 'bunfig.toml'
1118
- '.bun-version'
1219
- 'package.json'
1320
- 'package-lock.json'
1421
- '.github/workflows/bunTests.yml'
1522

1623
concurrency:
17-
group: ${{ github.ref }}-bun-tests
24+
group: ${{ github.ref == 'refs/heads/main' && format('{0}-{1}', github.ref, github.sha) || github.ref }}-bun-tests
1825
cancel-in-progress: true
1926

2027
jobs:

.github/workflows/lint.yml

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,21 @@ on:
66
types: [opened, synchronize]
77
branches-ignore: [staging, production]
88
paths:
9-
['**.js', '**.ts', '**.tsx', '**.json', '**.mjs', '**.cjs', 'config/.editorconfig', 'config/eslint/**', 'scripts/lint.sh', 'scripts/lintChanged.sh', '.watchmanconfig', '.imgbotconfig']
9+
[
10+
'**.js',
11+
'**.ts',
12+
'**.tsx',
13+
'**.json',
14+
'**.mjs',
15+
'**.cjs',
16+
'config/.editorconfig',
17+
'config/eslint/**',
18+
'scripts/lint.ts',
19+
'scripts/lintChanged.sh',
20+
'.watchmanconfig',
21+
'.imgbotconfig',
22+
'.github/workflows/lint.yml',
23+
]
1024

1125
concurrency:
1226
group: ${{ github.ref == 'refs/heads/main' && format('{0}-{1}', github.ref, github.sha) || github.ref }}-lint
@@ -16,10 +30,9 @@ jobs:
1630
lint:
1731
name: ESLint check
1832
if: ${{ github.event.head_commit.author.name != 'OSBotify' || github.event_name == 'push' }}
19-
# A cold-cache run lints the whole repo with type-aware rules, which loads the full TypeScript
20-
# program in every worker (~12GB of heap each, regardless of how files are split between workers).
21-
# 2 workers with a 14GB heap cap need ~30GB of memory, so this requires the 32GB (8vcpu) runner.
22-
runs-on: blacksmith-8vcpu-ubuntu-2404
33+
# A cold-cache run loads the full TypeScript program into every worker (~12GB each), plus any extra
34+
# tsconfig project a file is mapped to. 2 workers need more than the 32GB an 8vcpu runner has.
35+
runs-on: blacksmith-16vcpu-ubuntu-2404
2336
steps:
2437
- name: Checkout
2538
uses: useblacksmith/checkout@1c9394c220d293645707b625ba9d79685f093a8f # v1

.github/workflows/preDeploy.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,18 +21,21 @@ jobs:
2121
uses: ./.github/workflows/test.yml
2222
secrets: inherit
2323

24+
bunTests:
25+
uses: ./.github/workflows/bunTests.yml
26+
2427
confirmPassingBuild:
2528
runs-on: blacksmith-4vcpu-ubuntu-2404
26-
needs: [typecheck, lint, test]
29+
needs: [typecheck, lint, test, bunTests]
2730
if: ${{ always() }}
2831

2932
steps:
3033
- uses: useblacksmith/checkout@1c9394c220d293645707b625ba9d79685f093a8f # v1
3134

3235
- name: Exit failed workflow
33-
if: ${{ needs.typecheck.result == 'failure' || needs.lint.result == 'failure' || needs.test.result == 'failure' }}
36+
if: ${{ needs.typecheck.result == 'failure' || needs.lint.result == 'failure' || needs.test.result == 'failure' || needs.bunTests.result == 'failure' }}
3437
run: |
35-
echo "Checks failed, exiting ~ typecheck: ${{ needs.typecheck.result }}, lint: ${{ needs.lint.result }}, test: ${{ needs.test.result }}"
38+
echo "Checks failed, exiting ~ typecheck: ${{ needs.typecheck.result }}, lint: ${{ needs.lint.result }}, test: ${{ needs.test.result }}, bunTests: ${{ needs.bunTests.result }}"
3639
exit 1
3740
3841
chooseDeployActions:

.github/workflows/typecheck.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ on:
55
pull_request:
66
types: [opened, synchronize]
77
branches-ignore: [staging, production]
8-
paths: ['**.js', '**.ts', '**.tsx', 'package.json', 'package-lock.json', 'tsconfig.json']
8+
paths: ['**.js', '**.ts', '**.tsx', 'package.json', 'package-lock.json', '**/tsconfig.json']
99

1010
concurrency:
1111
group: ${{ github.ref == 'refs/heads/main' && format('{0}-{1}', github.ref, github.sha) || github.ref }}-typecheck

.oxfmtrc.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
"ignoreCase": true,
1212
"customGroups": [
1313
{
14-
"groupName": "jest",
15-
"elementNamePattern": ["@jest/globals", "@testing-library/**"]
14+
"groupName": "test-runner",
15+
"elementNamePattern": ["@jest/globals", "@testing-library/**", "bun:test"]
1616
},
1717
{"groupName": "assets", "elementNamePattern": ["@assets/**"]},
1818
{"groupName": "components", "elementNamePattern": ["@components/**"]},
@@ -28,7 +28,7 @@
2828
{"groupName": "src", "elementNamePattern": ["@src/**"]}
2929
],
3030
"groups": [
31-
"jest",
31+
"test-runner",
3232
"assets",
3333
"components",
3434
"github",

CLAUDE.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,8 @@ React Compiler auto-memoizes object literals, callbacks, JSX, and derived values
231231

232232
### Testing
233233

234-
- **Unit Tests**: Jest with React Native Testing Library
234+
- **Unit Tests**: Jest with React Native Testing Library. Tests for `.github/` and `scripts/` live in
235+
`tests/tooling/` and run under `bun:test` (`npm run test:bun`) — see `tests/tooling/README.md`.
235236
- **Performance Tests**: Reassure framework
236237

237238
## Special Considerations
@@ -292,6 +293,9 @@ npm run fmt
292293

293294
# Testing
294295
npm run test
296+
297+
# Bun tests: server/ plus the repo's own tooling (.github/ and scripts/)
298+
npm run test:bun
295299
```
296300

297301
### Platform Builds

Mobile-Expensify

0 commit comments

Comments
 (0)