Update docs for skeleton span removal

Author: TMisiukiewicz

contributingGuides/LOADING_STATE.md

@@ -57,9 +57,7 @@ const shouldShowLoadingIndicator = isAppLoadPending && !isOffline;
 
 // ...
 {shouldShowLoadingIndicator ? (
-    <ActivityIndicator
-        reasonAttributes={{context: 'WorkspacesListPage', isOffline} satisfies SkeletonSpanReasonAttributes}
-    />
+    <ActivityIndicator />
 ) : (
     <WorkspaceListTable workspaces={workspaceRows} />
 )}
@@ -172,5 +170,3 @@ Keep `HAS_LOADED_APP` and the cold-restart fallback. The queue hook is the prima
 Report skeleton consumers use `useIsReportLoadPending(reportID)` wherever pending `OpenReport` work is part of the loading decision. They keep existing readiness checks, including `hasOnceLoadedReportActions`, report data completeness, and offline behavior. A stranded `isLoadingInitialReportActions` value without a matching queue request or in-memory latch must not show a skeleton.
 
 Do not remove the legacy fields as part of this migration. `IS_LOADING_APP` and report loading state still support recovery, report positioning, navigation guards, and the deferred-flush bridge. Skeleton consumers should use the public hooks. Full flag deletion is outside this plan.
-
-**Keep telemetry for a terminal request that still shows a skeleton.** `useSkeletonSpan` in `src/libs/telemetry/useSkeletonSpan.ts` and the `reasonAttributes` prop on `ActivityIndicator` record a span while a skeleton is mounted. They flag skeletons that remain past `CONST.TELEMETRY.CONFIG.SKELETON_MIN_DURATION`. Pass `SkeletonSpanReasonAttributes` with a `context` for the screen and any state that explains the render, such as `isOffline`. This makes the case queryable under the `skeleton.` namespace.

contributingGuides/OBSERVABILITY.md

@@ -37,17 +37,6 @@ Minimum set of parameters required to create a span:
 
 **Span configuration**: Set of parameters passed to `Sentry.startInteractiveSpan`. See the [Sentry docs](https://docs.sentry.io/platforms/react-native/tracing/instrumentation/custom-instrumentation/#starting-inactive-spans-startinactivespan) for more details.
 
-Additional parameters can be added as a config object (third parameter):
-
-**Minimum Duration**: what's the minimum duration of a span. Spans shorter than this duration are discarded.
-
-```typescript
-startSpan(CONST.TELEMETRY.SPAN_SKELETON, {
-    name: CONST.TELEMETRY.SPAN_SKELETON,
-    op: CONST.TELEMETRY.SPAN_SKELETON,
-}, {minDuration: CONST.TELEMETRY.CONFIG.SKELETON_MIN_DURATION});
-```
-
 #### Finishing a Span
 
 There are two ways to finish a span:
@@ -72,7 +61,7 @@ Defined in `src/CONST/index.ts` under `CONST.TELEMETRY`:
 - Span names: `SPAN_OPEN_REPORT`, `SPAN_SEND_MESSAGE`
 - Tag names: `TAGS.ACTIVE_POLICY`, `TAGS.AUTHENTICATION_ERROR_TYPE`
 - Attribute names: `ATTRIBUTE_REPORT_ID`, `ATTRIBUTE_MESSAGE_LENGTH`
-- Configuration: `CONFIG.SKELETON_MIN_DURATION`
+- Configuration: `CONFIG.MEMORY_TRACKING_INTERVAL`
 
 #### Naming Conventions
 
@@ -86,7 +75,7 @@ Defined in `src/CONST/index.ts` under `CONST.TELEMETRY`:
 ### Middleware
 
 Process events before sending to Sentry:
-- **minDurationFilter** - Discards spans shorter than a specified duration
+- **maxDurationFilter** - Discards spans longer than a specified duration
 - **scopeTagsEnricher** - Adds cohort and policy tags
 - **emailDomainFilter** - Removes accounts we don't want to send telemetry for
 
@@ -115,7 +104,6 @@ Error conditions tracked for trend analysis:
 
 - **ANRs**: number of "Application Not Responding" errors
 - **404 pages**: number of user actions other than deep links that result in 404
-- **Infinite skeletons**: Skeleton visible 10+ seconds
 - **Authentication failures**: number of authentication errors other than wrong credentials 
 
 ### Feature Health

contributingGuides/OBSERVABILITY_METRICS.md

@@ -172,17 +172,6 @@ This document lists all implemented telemetry metrics in the Expensify App.
 **End**: Immediately after start (tracking occurrence, not duration) ([`src/libs/telemetry/useAbsentPageSpan.ts`](https://github.com/Expensify/App/blob/8f123f449f1a4533830b18a1040c9a5f1949821d/src/libs/telemetry/useAbsentPageSpan.ts#L39))
 **Attributes**: `url`, `navigationSource: 'deeplink' | 'button'`
 
-### Infinite Skeletons
-
-**Constant**: `CONST.TELEMETRY.SPAN_SKELETON`
-**Sentry Name**: `ManualSkeleton`
-**Threshold**: 10s minimum duration (only sent if visible 10+ seconds)
-**What's Measured**: Number of skeleton components visible longer than expected
-**Start**: Skeleton component mounted ([`src/libs/telemetry/useSkeletonSpan.ts`](https://github.com/Expensify/App/blob/8f123f449f1a4533830b18a1040c9a5f1949821d/src/libs/telemetry/useSkeletonSpan.ts#L13))
-**End**: Component unmounts ([`src/libs/telemetry/useSkeletonSpan.ts`](https://github.com/Expensify/App/blob/8f123f449f1a4533830b18a1040c9a5f1949821d/src/libs/telemetry/useSkeletonSpan.ts#L24))
-**Span ID**: `${CONST.TELEMETRY.SPAN_SKELETON}_${component}_${reactId}`
-**Minimum Duration**: `CONST.TELEMETRY.CONFIG.SKELETON_MIN_DURATION` (10s)
-
 ### Authentication Failures
 
 **Constants**: `CONST.TELEMETRY.TAGS.AUTHENTICATION_FUNCTION`, `CONST.TELEMETRY.TAGS.AUTHENTICATION_ERROR_TYPE`, `CONST.TELEMETRY.TAGS.AUTHENTICATION_JSON_CODE` ([`src/CONST/index.ts`](https://github.com/Expensify/App/blob/8f123f449f1a4533830b18a1040c9a5f1949821d/src/CONST/index.ts#L1700-L1702))