Merge branch 'main' into refactor/66418-remove-deprecatedReportsTransactions-in-hasNonReimbursableTransactions-p1

# Conflicts:
#	src/libs/ReportNameUtils.ts
#	src/libs/ReportUtils.ts
#	src/pages/inbox/report/SearchActionHeader.tsx
#	tests/unit/ReportNameUtilsTest.ts
#	tests/unit/ReportUtilsTest.ts

Author: linhvovan29546

.github/actions/javascript/getPullRequestIncrementalChanges/index.js

@@ -12887,7 +12887,7 @@ exports["default"] = Git;
 "use strict";
 
 Object.defineProperty(exports, "__esModule", ({ value: true }));
-exports.bold = exports.formatLink = exports.success = exports.errorDetail = exports.error = exports.note = exports.warn = exports.info = void 0;
+exports.setOutputStream = exports.bold = exports.formatLink = exports.success = exports.errorDetail = exports.error = exports.note = exports.warn = exports.info = void 0;
 const COLOR_DIM = '\x1b[2m';
 const COLOR_RESET = '\x1b[0m';
 const COLOR_YELLOW = '\x1b[33m';
@@ -12902,32 +12902,58 @@ const EMOJIS = {
     SUCCESS: '✅',
     ERROR: '🔴',
 };
+/** Mirrors the console API: informational levels on stdout, warnings and errors on stderr. */
+const outputStreams = {
+    info: 'stdout',
+    bold: 'stdout',
+    success: 'stdout',
+    note: 'stdout',
+    warn: 'stderr',
+    error: 'stderr',
+    errorDetail: 'stderr',
+};
+/**
+ * Redirects individual levels; levels left out keep whatever they are set to. Call this at startup
+ * from a script whose stdout carries machine-readable output (e.g. JSON parsed by another process),
+ * where a stray log line would corrupt the payload: `setOutputStream({info: 'stderr'})`.
+ */
+const setOutputStream = (streams) => {
+    Object.assign(outputStreams, streams);
+};
+exports.setOutputStream = setOutputStream;
+const write = (level, ...args) => {
+    if (outputStreams[level] === 'stderr') {
+        console.error(...args);
+        return;
+    }
+    console.log(...args);
+};
 const info = (...args) => {
-    console.log(EMOJIS.INFO, ...args);
+    write('info', EMOJIS.INFO, ...args);
 };
 exports.info = info;
 const bold = (...args) => {
-    console.log(COLOR_BOLD, ...args, COLOR_RESET);
+    write('bold', COLOR_BOLD, ...args, COLOR_RESET);
 };
 exports.bold = bold;
 const success = (...args) => {
-    console.log(`${EMOJIS.SUCCESS}${COLOR_GREEN}`, ...args, COLOR_RESET);
+    write('success', `${EMOJIS.SUCCESS}${COLOR_GREEN}`, ...args, COLOR_RESET);
 };
 exports.success = success;
 const warn = (...args) => {
-    console.warn(`${EMOJIS.WARN}${COLOR_YELLOW}`, ...args, COLOR_RESET);
+    write('warn', `${EMOJIS.WARN}${COLOR_YELLOW}`, ...args, COLOR_RESET);
 };
 exports.warn = warn;
 const note = (...args) => {
-    console.log(COLOR_DIM, ...args, COLOR_RESET);
+    write('note', COLOR_DIM, ...args, COLOR_RESET);
 };
 exports.note = note;
 const error = (...args) => {
-    console.error(`${EMOJIS.ERROR}${COLOR_RED}`, ...args, COLOR_RESET);
+    write('error', `${EMOJIS.ERROR}${COLOR_RED}`, ...args, COLOR_RESET);
 };
 exports.error = error;
 const errorDetail = (...args) => {
-    console.error(`   ${COLOR_RED}↳`, ...args, COLOR_RESET);
+    write('errorDetail', `   ${COLOR_RED}↳`, ...args, COLOR_RESET);
 };
 exports.errorDetail = errorDetail;
 const formatLink = (name, url) => `\x1b]8;;${url}\x1b\\${name}\x1b]8;;\x1b\\`;

.github/workflows/publishReactNativeAndroidArtifacts.yml

@@ -59,9 +59,9 @@ jobs:
         id: computePatchesHash
         run: |
           if [[ '${{ matrix.is_hybrid }}' == 'true' ]]; then
-            echo "PATCHES_HASH=$(./scripts/compute-patches-hash.sh patches Mobile-Expensify/patches)" >> "$GITHUB_OUTPUT"
+            echo "PATCHES_HASH=$(./scripts/artifacts-utils/compute-patches-hash.sh patches Mobile-Expensify/patches)" >> "$GITHUB_OUTPUT"
           else
-            echo "PATCHES_HASH=$(./scripts/compute-patches-hash.sh patches)" >> "$GITHUB_OUTPUT"
+            echo "PATCHES_HASH=$(./scripts/artifacts-utils/compute-patches-hash.sh patches)" >> "$GITHUB_OUTPUT"
           fi
 
       - name: Setup Node

.github/workflows/publishReactNativeArtifacts.yml

@@ -38,7 +38,7 @@ on:
       - patches/react-native/react-native+*.patch
       - patches/react-native/@react-native+*.patch
       - Mobile-Expensify
-      - scripts/compute-patches-hash.sh
+      - scripts/artifacts-utils/compute-patches-hash.sh
 
 jobs:
   verifyPatches:
@@ -62,8 +62,8 @@ jobs:
         if: ${{ github.event.after != '' }}
         id: getOldPatchesHash
         run: |
-          echo "HYBRID_APP_HASH=$(./scripts/compute-patches-hash.sh patches Mobile-Expensify/patches)" >> "$GITHUB_OUTPUT"
-          echo "STANDALONE_APP_HASH=$(./scripts/compute-patches-hash.sh patches)" >> "$GITHUB_OUTPUT"
+          echo "HYBRID_APP_HASH=$(./scripts/artifacts-utils/compute-patches-hash.sh patches Mobile-Expensify/patches)" >> "$GITHUB_OUTPUT"
+          echo "STANDALONE_APP_HASH=$(./scripts/artifacts-utils/compute-patches-hash.sh patches)" >> "$GITHUB_OUTPUT"
 
       - name: Get previous react-native version
         if: ${{ github.event.after != '' }}
@@ -80,8 +80,8 @@ jobs:
       - name: Get new patches hash
         id: getNewPatchesHash
         run: |
-          echo "HYBRID_APP_HASH=$(./scripts/compute-patches-hash.sh patches Mobile-Expensify/patches)" >> "$GITHUB_OUTPUT"
-          echo "STANDALONE_APP_HASH=$(./scripts/compute-patches-hash.sh patches)" >> "$GITHUB_OUTPUT"
+          echo "HYBRID_APP_HASH=$(./scripts/artifacts-utils/compute-patches-hash.sh patches Mobile-Expensify/patches)" >> "$GITHUB_OUTPUT"
+          echo "STANDALONE_APP_HASH=$(./scripts/artifacts-utils/compute-patches-hash.sh patches)" >> "$GITHUB_OUTPUT"
 
       - name: Get new react-native version
         if: ${{ github.event.after != '' }}

.github/workflows/publishReactNativeiOSArtifacts.yml

@@ -211,9 +211,9 @@ jobs:
         id: computePatchesHash
         run: |
           if [[ '${{ matrix.is_hybrid }}' == 'true' ]]; then
-            echo "PATCHES_HASH=$(./scripts/compute-patches-hash.sh patches Mobile-Expensify/patches)" >> "$GITHUB_OUTPUT"
+            echo "PATCHES_HASH=$(./scripts/artifacts-utils/compute-patches-hash.sh patches Mobile-Expensify/patches)" >> "$GITHUB_OUTPUT"
           else
-            echo "PATCHES_HASH=$(./scripts/compute-patches-hash.sh patches)" >> "$GITHUB_OUTPUT"
+            echo "PATCHES_HASH=$(./scripts/artifacts-utils/compute-patches-hash.sh patches)" >> "$GITHUB_OUTPUT"
           fi
 
       - name: Determine new patched RN version

android/build.gradle

@@ -16,7 +16,7 @@ buildscript {
         // "mapbox" indicates the usage of the Mapbox SDK.
         RNMapboxMapsImpl = "mapbox"
         reactNativeIncludedBuild = gradle.getIncludedBuilds().find { it.name == 'react-native' }
-        // This is our custom extension that we defined in gradleUtils/PatchedArtifactsSettings.gradle
+        // This is our custom extension that we defined in scripts/artifacts-utils/android/PatchedArtifactsSettings.gradle
         // It enables us to use custom artifacts of patched react-native
         patchedArtifactsConfig = project.gradle.settings.extensions.findByName('patchedArtifacts')
     }

android/settings.gradle

@@ -6,7 +6,7 @@ plugins {
     id("com.facebook.react.settings")
     id("expo-autolinking-settings")
 }
-apply from: "${rootDir}/../gradleUtils/PatchedArtifactsSettings.gradle"
+apply from: "${rootDir}/../scripts/artifacts-utils/android/PatchedArtifactsSettings.gradle"
 
 extensions.configure(com.facebook.react.ReactSettingsExtension){ ex -> ex.autolinkLibrariesFromCommand(['npx', 'rock', 'config', '-p', 'android']) }
 rootProject.name = 'NewExpensify'

assets/images/integrationicons/dualentry-icon-square.svg

@@ -103,7 +103,6 @@
 "../../src/components/AutoCompleteSuggestions/index.tsx"	"react-hooks/set-state-in-effect"	1
 "../../src/components/AutoSubmitModal.tsx"	"@typescript-eslint/no-unsafe-type-assertion"	2
 "../../src/components/Avatar.tsx"	"@typescript-eslint/no-unsafe-type-assertion"	1
-"../../src/components/AvatarButtonWithIcon.tsx"	"react-hooks/static-components"	1
 "../../src/components/AvatarCropModal/AvatarCropModal.tsx"	"no-restricted-imports"	1
 "../../src/components/AvatarCropModal/ImageCropView.tsx"	"@typescript-eslint/no-unsafe-type-assertion"	1
 "../../src/components/AvatarCropModal/Slider.tsx"	"@typescript-eslint/no-unsafe-type-assertion"	1

config/eslint/eslint.seatbelt.tsv

@@ -0,0 +1,91 @@
+# Prebuilt React Native Artifacts
+
+We ship a few [patches](PATCHES.md) on top of `react-native`, so the copy we build against is not the
+one published on npm. To avoid every developer compiling it locally, CI builds `react-native` with our
+patches applied and publishes it to our private GitHub Packages Maven repository.
+
+At build time a resolver hashes the local patches and looks for a published artifact tagged with the
+same hash. On a match the build downloads `react-native` instead of compiling it. If nothing matches —
+because you added or edited a patch locally, or because credentials are missing — the build logs a
+warning and compiles `react-native` from source, so a miss slows the build down but never fails it.
+
+> [!NOTE]
+> These are not the remote builds described in the "Running the mobile application using Rock" sections
+> of the [iOS](SETUP_IOS.md) and [Android](SETUP_ANDROID.md) setup guides. Rock downloads a complete
+> prebuilt app from S3; the artifacts described here are only the `react-native` core, and the two are
+> independent of each other.
+
+## Configuring GitHub CLI
+
+The artifacts live in a private package registry, so a build has to authenticate. Locally the
+credentials come from the GitHub CLI:
+
+1. **Install GitHub CLI**
+   - Install GitHub CLI by following the instructions from [cli.github.com](https://cli.github.com/)
+
+2. **Create a GitHub Personal Access Token**
+   - Go to [GitHub Settings > Developer Settings > Personal Access Tokens](https://github.com/settings/tokens)
+   - Click "Generate new token (classic)"
+   - Select the following scopes:
+     - `repo`
+     - `read:org`
+     - `gist`
+     - `read:packages`
+   - Copy the generated token
+
+3. **Login to GitHub CLI**
+   ```bash
+   echo "YOUR_TOKEN" | gh auth login --with-token
+   ```
+
+4. **Verify Login**
+   ```bash
+   gh auth status
+   ```
+   You should see a message confirming you are authenticated with your GitHub account, and
+   `read:packages` among the token scopes.
+
+Without a usable token the build still works, it just compiles `react-native` from source. The
+resolver says which part of the setup is missing, so check the build log if you expected a prebuilt.
+
+In CI there is no GitHub CLI: the credentials are taken from the `GITHUB_TOKEN` and `GITHUB_ACTOR`
+environment variables that the workflow provides.
+
+## Disabling prebuilt artifacts on Android
+
+Prebuilt artifacts are enabled by default. To compile `react-native` from source instead:
+
+- Open `android/gradle.properties` (for standalone NewDot) or `Mobile-Expensify/Android/gradle.properties`
+  (for HybridApp)
+- Set `patchedArtifacts.forceBuildFromSource=true`
+
+To force it for a single Gradle invocation, without editing the properties file:
+
+<!-- cspell:ignore Ppatched -- Gradle's -P flag makes `-PpatchedArtifacts` tokenize as Ppatched + Artifacts -->
+
+```bash
+./gradlew <task> -PpatchedArtifacts.forceBuildFromSource=true
+```
+
+## Disabling prebuilt artifacts on iOS
+
+Prebuilt artifacts are enabled by default for HybridApp. Standalone NewDot always compiles
+`react-native` from source: under `use_frameworks! :linkage => :static` (required by Firebase) the
+prebuilt React Core cannot expose `React_RCTAppDelegate` as an importable Swift module, which the
+standalone Swift `AppDelegate` needs. HybridApp is unaffected, because its `AppDelegate` is written in
+Objective-C and imports that header directly.
+
+To compile `react-native` from source in HybridApp, set `BUILD_RN_FROM_SOURCE` when installing pods:
+
+```bash
+BUILD_RN_FROM_SOURCE=1 npm run pod-install
+```
+
+The flag is read during `pod install`, so switching it requires reinstalling the pods, not just
+rebuilding.
+
+To get symbolicated native stack traces from a prebuilt React Core, install the pods with the dSYMs:
+
+```bash
+RCT_SYMBOLICATE_PREBUILT_FRAMEWORKS=1 npm run pod-install
+```

contributingGuides/PREBUILT_REACT_NATIVE_ARTIFACTS.md

@@ -76,43 +76,11 @@ If you haven't done any intentional edits outside of `src/` (like adding new dep
 - To point the **Development Emulator** at your local VM, follow [these steps](https://stackoverflow.com/c/expensify/questions/7699).
 - You must configure the local dev email account; follow [these instructions](https://stackoverflowteams.com/c/expensify/questions/23537/23538#23538).
 
-## Enabling Prebuilt React Native Artifacts
+## Prebuilt React Native Artifacts
 
-By default, `react-native` is built from source when building the Android app. However, you can enable prebuilt artifacts to speed up the build process:
-
-### Disabling Build from Source
-- Open `android/gradle.properties` (for Standalone NewDot) or `Mobile-Expensify/Android/gradle.properties` (for HybridApp)
-- Set `patchedArtifacts.forceBuildFromSource=false`
-
-### Configuring GitHub CLI
-
-To use prebuilt artifacts, you need to have GitHub CLI installed and configured:
-
-1. **Install GitHub CLI**
-   - Install GitHub CLI by following the instructions from [cli.github.com](https://cli.github.com/)
-
-2. **Create a GitHub Personal Access Token**
-   - Go to [GitHub Settings > Developer Settings > Personal Access Tokens](https://github.com/settings/tokens)
-   - Click "Generate new token (classic)"
-   - Select the following scopes:
-     - `repo`
-     - `read:org`
-     - `gist`
-     - `read:packages`
-   - Copy the generated token
-
-3. **Login to GitHub CLI**
-   ```bash
-   echo "YOUR_TOKEN" | gh auth login --with-token
-   ```
-
-4. **Verify Login**
-   ```bash
-   gh auth status
-   ```
-   You should see a message confirming you are authenticated with your GitHub account.
-
-After completing these steps, you should be able to build Android apps with prebuilt `react-native` artifacts.
+Android builds download a prebuilt `react-native` from GitHub Packages instead of compiling it, which
+requires an authenticated GitHub CLI. See [Prebuilt React Native Artifacts](PREBUILT_REACT_NATIVE_ARTIFACTS.md)
+for the setup and for how to compile from source instead.
 
 ## Push Notifications Setup