Fix native deeplink paths for the Submit onboarding intent

Custom-scheme links like new-expensify://onboarding?intent=submit put the route
where a host would sit, so stripping the origin discarded the route and the
intent was lost. Links opened while the app was already running were missed too,
since the latched URL is stale by then and only secure links were recorded.

Author: abzokhattab

src/DeepLinkHandler.tsx

@@ -11,6 +11,7 @@ import useOnyx from './hooks/useOnyx';
 import {openReportFromDeepLink} from './libs/actions/Link';
 import * as Report from './libs/actions/Report';
 import {hasAuthToken, isAnonymousUser} from './libs/actions/Session';
+import getOnboardingIntentFromUrl from './libs/getOnboardingIntentFromUrl';
 import Log from './libs/Log';
 import {getReportIDFromLink} from './libs/ReportUtils';
 import {endSpan} from './libs/telemetry/activeSpans';
@@ -141,10 +142,11 @@ function DeepLinkHandler({onInitialUrl}: DeepLinkHandlerProps) {
                 Log.info('[Deep link] introSelected is undefined when processing URL change', false, {url: state.url});
             }
             const isCurrentlyAuthenticated = hasAuthToken();
-            // A Submit-via-PDF secure access link can arrive while the app is already running (warm), where
-            // getInitialURL() is empty. Record it so onboarding suppression has a session-sticky signal, the same
-            // way the cold path does via onInitialUrl above. Scoped to secure links so other deep links are unaffected.
-            if (hasSecureLinkKey(state.url)) {
+            // A Submit-via-PDF secure access link, or an onboarding deeplink carrying an intent, can arrive while the
+            // app is already running (warm), where getInitialURL() is empty. Record it so the handlers reading the
+            // initial URL have a session-sticky signal, the same way the cold path does via onInitialUrl above.
+            // Scoped to those two link shapes so other deep links are unaffected.
+            if (hasSecureLinkKey(state.url) || getOnboardingIntentFromUrl(state.url)) {
                 onInitialUrl(state.url as Route);
             }
             openReportFromDeepLink(state.url, allReports, isCurrentlyAuthenticated, conciergeReportID, introSelected, isSelfTourViewed, betas, session?.accountID ?? CONST.DEFAULT_NUMBER_ID);

src/hooks/useOnboardingDeeplinkIntent.ts

@@ -12,7 +12,8 @@ import {useState} from 'react';
  *
  * The URL is latched at mount because the app rewrites it as soon as it navigates, which happens well before the
  * intent has been acted on. The initial URL is the only source on native, where the browser URL is empty and the
- * deeplink resolves asynchronously.
+ * deeplink resolves asynchronously. It also covers links opened while the app is already running, which DeepLinkHandler
+ * records there because the latched URL is stale by then.
  */
 function useOnboardingDeeplinkIntent(): OnboardingIntent | undefined {
     const {initialURL} = useInitialURLState();

src/libs/getOnboardingIntentFromUrl.ts

@@ -22,10 +22,17 @@ function isOnboardingIntent(value: string | null): value is OnboardingIntent {
     return !!value && ONBOARDING_INTENT_VALUES.has(value);
 }
 
-/** Strips the scheme and host so absolute URLs and in-app paths can be inspected the same way. */
+/**
+ * Strips the scheme and, for web URLs, the host, so absolute URLs and in-app paths can be inspected the same way.
+ *
+ * Custom schemes have to keep the segment straight after `://`. In `new-expensify://onboarding?intent=submit` that
+ * segment is the route rather than a host, so dropping it the way we drop `new.expensify.com` would discard the
+ * route and lose the intent. The `app://-/` prefix puts a placeholder host there instead, which is dropped.
+ */
 function getPathWithQuery(url: string): string {
-    const [withoutHash] = url.replace(/^[a-z][\w+.-]*:\/\/[^/]*/i, '').split('#', 2);
-    return withoutHash.replace(/^\/+/, '');
+    const [withoutHash] = url.split('#', 2);
+    const withoutOrigin = /^https?:\/\//i.test(withoutHash) ? withoutHash.replace(/^https?:\/\/[^/?#]*/i, '') : withoutHash.replace(/^[a-z][\w+.-]*:\/\//i, '');
+    return withoutOrigin.replace(/^(-\/)?\/*/, '');
 }
 
 function getOnboardingIntentFromUrl(url: string | null | undefined): OnboardingIntent | undefined {

tests/unit/getOnboardingIntentFromUrlTest.ts

@@ -7,6 +7,22 @@ describe('getOnboardingIntentFromUrl', () => {
         expect(getOnboardingIntentFromUrl('https://new.expensify.com/onboarding?intent=submit')).toBe(CONST.ONBOARDING_INTENTS.SUBMIT);
     });
 
+    it('reads the intent from a custom scheme link, where the route sits where a host would', () => {
+        expect(getOnboardingIntentFromUrl('new-expensify://onboarding?intent=submit')).toBe(CONST.ONBOARDING_INTENTS.SUBMIT);
+    });
+
+    it('reads the intent from a custom scheme link with a placeholder host', () => {
+        expect(getOnboardingIntentFromUrl('app://-/onboarding?intent=submit')).toBe(CONST.ONBOARDING_INTENTS.SUBMIT);
+    });
+
+    it('reads the intent from the exitTo of a custom scheme magic link', () => {
+        expect(getOnboardingIntentFromUrl('new-expensify://v/12345/678910?exitTo=onboarding%3Fintent%3Dsubmit')).toBe(CONST.ONBOARDING_INTENTS.SUBMIT);
+    });
+
+    it('reads the intent from a link served on a port, as the dev server does', () => {
+        expect(getOnboardingIntentFromUrl('https://dev.new.expensify.com:8082/onboarding?intent=submit')).toBe(CONST.ONBOARDING_INTENTS.SUBMIT);
+    });
+
     it('reads the intent from an in-app path without an origin', () => {
         expect(getOnboardingIntentFromUrl('/onboarding?intent=submit')).toBe(CONST.ONBOARDING_INTENTS.SUBMIT);
     });