fix: cancellation date locale-driven order/clock + splash gate requires non-empty cache

Author: TaduJR

src/languages/IntlStore.ts

@@ -295,7 +295,8 @@ class IntlStore {
                 Log.warn('[IntlStore] locale chunk failed to load', {locale, error});
             })
             .finally(() => {
-                if (IntlStore.loadToken === token) {
+                // Non-empty cache required — else a rejected first-load would open the splash to raw path strings.
+                if (IntlStore.loadToken === token && IntlStore.cache.size > 0) {
                     setAreTranslationsLoading(false);
                 }
                 if (!localeSpan) {

src/libs/DateUtils.ts

@@ -966,13 +966,11 @@ function getFormattedCancellationDate(isoDateString: string, locale: Locale): st
     if (Number.isNaN(instant.getTime())) {
         return '';
     }
-    // Manual venue-wall-clock shift + format-in-UTC — sidesteps `formatInTimeZone`'s raw-offset rejection AND guarantees the rendered time can't contradict `venueTimezoneLabel`.
+    // Pre-shifted venue instant + Intl in UTC — sidesteps raw-offset rejection, can't contradict `venueTimezoneLabel`, and lets locale drive order + clock.
     const venueInstant = new Date(instant.getTime() + offsetMinutes * 60_000);
     const nowInVenue = new Date(Date.now() + offsetMinutes * 60_000);
-    const pattern = venueInstant.getUTCFullYear() === nowInVenue.getUTCFullYear() ? 'EEEE, MMM d h:mm a' : 'EEEE, MMM d, yyyy h:mm a';
-    // Explicit `enUS` (never `undefined`) so a chunk-load race can't silently leak through to date-fns's global default.
-    const dateFnsLocale = IntlStore.getDateFnsLocale(locale) ?? enUS;
-    return `${formatInTimeZoneWithFallback(venueInstant, 'UTC', pattern, {locale: dateFnsLocale})}, ${venueTimezoneLabel}`;
+    const datePreset = venueInstant.getUTCFullYear() === nowInVenue.getUTCFullYear() ? 'WEEKDAY_MONTH_DAY' : 'WEEKDAY_MONTH_DAY_YEAR';
+    return `${formatIntl(locale, datePreset, venueInstant, 'UTC')} ${formatIntl(locale, 'SHORT_TIME', venueInstant, 'UTC')}, ${venueTimezoneLabel}`;
 }
 
 /**

tests/unit/DateUtilsTest.ts

@@ -933,6 +933,16 @@ describe('DateUtils', () => {
             const result = DateUtils.getFormattedCancellationDate('2026-04-19', CONST.LOCALES.EN);
             expect(result).toBe('Sunday, Apr 19, 2026 12:00 AM, UTC');
         });
+
+        it('renders non-English locales with locale-driven field order + clock (not just token translation)', () => {
+            jest.useFakeTimers();
+            jest.setSystemTime(new Date('2025-01-01T00:00:00Z'));
+            const es = DateUtils.getFormattedCancellationDate('2026-04-19T15:00:00+07:00', CONST.LOCALES.ES);
+            // Spanish convention is day-before-month + 24h clock — a date-fns pattern would keep the English order and 12h "3:00 PM".
+            expect(es).not.toMatch(/AM|PM/);
+            expect(es).toContain('15:00');
+            expect(es).toContain('GMT+7');
+        });
     });
 
     // CI's TZ=UTC hides "forgot the timeZone arg" regressions from output-based tests; isolate the module for a fresh memoize cache so the spy actually sees the constructor call.