From c5ce5d7e46d0052395400abaee813347e3aa5bc0 Mon Sep 17 00:00:00 2001 From: jcant0n Date: Sat, 8 Aug 2026 13:14:05 +0200 Subject: [PATCH] fix: the smoke test passed a property name the project does not read The workflow passed -p:JoltPhysicsVersion and the project read $(JoltVersion), so the PackageReference got an empty version and all five legs died on NU1015 pointing at the csproj, which is nowhere near the mistake. The project now uses the name the workflow passes, and the step that reads the version off the .nupkg refuses to continue when it comes out empty. The point is where the failure is reported: a restore error naming the project sends you looking at the project, and this one was never there. --- .github/workflows/package-smoke.yml | 9 +++++++++ DesktopSmokeTest/DesktopSmokeTest.csproj | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/.github/workflows/package-smoke.yml b/.github/workflows/package-smoke.yml index 8a3d1d3..a02fd7d 100644 --- a/.github/workflows/package-smoke.yml +++ b/.github/workflows/package-smoke.yml @@ -142,6 +142,15 @@ jobs: pkg=$(ls DesktopSmokeTest/local-packages/*.nupkg | head -1) version=$(basename "$pkg" .nupkg | sed 's/^Evergine\.Bindings\.JoltPhysics\.//') + + # Said out loud, because the failure it prevents does not look like this step's fault. + # An empty version reaches the project as an empty PackageReference and NuGet reports + # NU1015 from the restore, five legs at once, pointing at the csproj. + if [ -z "$version" ] || [ "$version" = "$(basename "$pkg" .nupkg)" ]; then + echo "::error::could not read a version out of '$(basename "$pkg")'" + exit 1 + fi + echo "JOLT_VERSION=$version" >> "$GITHUB_ENV" echo "testing $version on ${{ matrix.rid }}" diff --git a/DesktopSmokeTest/DesktopSmokeTest.csproj b/DesktopSmokeTest/DesktopSmokeTest.csproj index ce27a3a..469d315 100644 --- a/DesktopSmokeTest/DesktopSmokeTest.csproj +++ b/DesktopSmokeTest/DesktopSmokeTest.csproj @@ -14,7 +14,7 @@ project reference bypasses all of it and would pass against a package shipping nothing. --> - +