when is not highlighted

[ShalokShalom]

Environment

• OS: Linux

• OS Version Garuda

• VS Code Version 1.106.0

• Racket version 9.0

• Racket Langserver checksum

  Despite successful installation:

  Installation-wide:
  [none]
  User-specific for installation "9.0":
  [none]
  

• Magic Racket version 0.8.0

The when form is not highlighted.

[jryans]

I believe adding it to the control keywords

magic-racket/syntaxes/src/rhombus.yaml

Lines 435 to 436 in 0918b01

	- name: keyword.control.rhombus
	match: (?<=^|\W)(match|cond|for|if|each|keep_when)(?=\W|$)

would resolve this.

The Rhombus syntax currently has a much smaller set of known keywords than the Racket equivalent. Perhaps there's a good way to gather even more of them...?

[mflatt]

At the Racket level, you could use

(module-declared? 'rhombus #t) ; loads the module declaration
(module->exports 'rhombus)

Or you might want 'rhombus/and_meta, or you might want 'rhombus/meta separately.

[jryans]

Thanks @mflatt! I've also noticed in the past that we're missing some of the newer Racket builtin forms as well, so it probably does make sense to script gathering such things for both languages at some point.

As for this issue, I'd be happy to take a one-off change just for when or alternatively a more holistic fix that gathers many others as well (perhaps using a scripted approach as outlined). It might be a little while until I get around to it myself, so anyone feel free to work on this if your feel inclined to do so.