[Bug] - Trouble converting dates

[Minus10Celcius]

Describe the bug

A clear and concise description of what the bug is.

I can't convert the dates in the date converter

To Reproduce

Steps to reproduce the behavior:

• Ribbon Diarian button
• Go to "Date Converter"

Expected behavior

A clear and concise description of what you expected to happen.

I expected my daily notes to convert.

Screenshots

If applicable, add screenshots to help explain your problem.
Screen recording 2024-10-04 1.17.14 PM.webm

Specs

• Platform: Linux
• Plugin version: 1.2.9

Additional context

Add any other context about the problem here.

[winged-voices]

Hi, I'm having this issue as well! Or rather, it'll convert some but not all of the notes and I'm not sure what exactly the pattern is.

Timeline:

1. I initially was converting everything from YYYY-MM-DD to YYYY/M-MMM/ddd MMM Do [at] h.mm A
   • It created the year folder and two new month folders, and converted a couple of files, but got stuck there.
2. I made the journal folders for it, dragged everything into the right folder.
3. Told it to convert:
   From YYYY/M-MMM/YYYY-MM-DD
   To: YYYY/M-MMM/ddd MMM Do [at] h.mm A
   • It got about....half of them? No rhyme or reason.

So then I decided I'd do it myself later. Unfortunately, I realized that my Mood Tracker plugin couldn't find time-dated Daily Notes, because it has its own timestamp, so when I told it to expect a date with the time on it for the note, it wanted the exact time I added the mood. OOF.¹

So, I changed things to YYYY/M-MMM/ddd MMM Do [no time], and tried to convert again.

4. When I did it this time, I gave it a shot at converting both the ones that had been converted to the new style...:
   From: YYYY/M-MMM/ddd MMM Do [at] h.mm A
   To: YYYY/M-MMM/ddd MMM Do
5. and then the ones still in YYYY-MM-DD
   From: YYYY/M-MMM/YYYY-MM-DD
   To: YYYY/M-MMM/ddd MMM Do
   • Once again it got a handful of them right each time, but got stuck somewhere both times.

Right now it's functional -- new ones are created right, and show up on the calendar; I assume I can't create multiple a day since I nixed the time stamp. And I can go back and manually change the old ones if I want to.
But it's WEIRD that the converter never gets all of them. Any idea what could be tripping it up?

I've tried to find spaces or anything in the path that could be making it stumble, and no dice. Especially weird because some that wouldn't convert the first time would get converted the next time etc.

Footnotes

1. I could theoretically have gotten around this by adding a new entry for mood tracking, and I still might get rid of mood tracker to just use the rating tool, but Mood Tracker has more data [individual emotions, shows you what emotions are coming up the most, its own graphs etc], which I don't think this one does, correct me if I'm wrong? So for now...I'll keep as is ↩

[winged-voices]

(I know that was a TON of text there -- I'm hoping exactness helps, but if it actually made things more confusing please let me know if you need anything!)

[Minus10Celcius]

So I'm not the only one! Haha...

[Erallie]

@Minus10Celcius So are you trying to convert notes that are in the parent folder Journal and the format MMMM D, YYYY and not in the parent folder Journal and the format YYYY/MMMM/MMMM D, YYYY into the new format?

@winged-voices I will need to check my code again. I will get back to you. I know that there are issues with similar formats not being converted because of the way I check which notes to change, but I didn't think it would have issues with different folders. I guess I might have not tested it thoroughly enough.

[Erallie]

@winged-voices It's weird, because with an empty vault, I'm replicating your step 1 exactly with the same date format and everything, but for some reason, It's still behaving as expected. I'm not getting the same issue where it's only converting half of them.

Just to be certain, what folder are you using both times, and just making sure you're using version 1.2.9?

[Erallie]

@khanhtoan529 Sorry I'm moving the issue over here, since someone created a new issue on it before I saw your comment. What are the daily notes settings before and after your conversion?

@winged-voices and @Minus10Celcius Do you get any error messages from the developer console (Ctrl + I) when you run the converter? Can you send me screenshots?

[khanhtoan529]

What are the daily notes settings before and after your conversion?

I'm not sure because my step is quite complicate. I will try my best to listing here:

1. Create a new folder name "Old Daily Notes"
2. Go to file explorer, go to "Daily Notes" folder
3. Copy and cut all files there, move to the folder "Old Daily Notes".
4. Go to the Daily Notes core plugin setting.
5. Set the new daily notes format: YYYY-MM-DD HH.mmA
6. Open Diarian format converter
7. Set old date format to "YYYY-MM-DD"
8. Set old folder note to "Old Daily Notes"
9. Start convert and observe the progress

Expected result: All my old daily notes should be created in the new format
Actual result: Plugin only convert few recent daily notes, and the progress bar freezing

[Erallie]

@khanhtoan529 You should not need to manually cut and paste all the files from the old folder to the new folder. By doing that, you don't need to actually use the converter at all, but just need to trigger Settings → Diarian → Danger zone → Refresh daily notes, and it should all show up in the calendar.

The Old date format and the Old daily note folder should both point to where the daily notes currently are at the moment you press Start conversion. Because of this, if you just had all your daily notes in the folder "Old Daily Notes" at the time your press Start conversion, it should take the daily notes in that folder and move them to the location specified under Settings → Daily notes → New file location and with the format specified under Settings → Daily notes → Date format.

Please try it that way and let me know if you are still having issues.