Skip to content

Improve range handling for price aggregation #585

Description

@shochdoerfer

Given I have a product with a price of 68.13 synced to Gally, the Gally response for the price aggregation filter will contain 68 as the maximum value. When sending the max value of 68 back to Gally, the product with the 68.13 price gets filtered out (since I am using a "lte" filter with 68).

My current "fix" in the Sylius connector is to add 1 to the max value sent by Gally. But I feel this is something that should not be the responsibility of the connector, but rather Gally should round up or add 1 to the max value.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions