fix HttpServerRequest.toWeb missing duplex option for streaming bodies

Author: kitlangton

.changeset/tall-buses-sing.md

@@ -0,0 +1,5 @@
+---
+"@effect/platform": patch
+---
+
+fix HttpServerRequest.toWeb missing duplex option for streaming bodies in Node

packages/platform-node/test/HttpServer.test.ts

@@ -755,4 +755,30 @@ describe("HttpServer", () => {
       )
       expect(root).toEqual("root")
     }).pipe(Effect.provide(NodeHttpServer.layerTest)))
+
+  describe("HttpServerRequest.toWeb", () => {
+    it.scoped("converts POST request with body", () =>
+      Effect.gen(function*() {
+        yield* HttpRouter.empty.pipe(
+          HttpRouter.post(
+            "/echo",
+            Effect.gen(function*() {
+              const request = yield* HttpServerRequest.HttpServerRequest
+              const webRequest = HttpServerRequest.toWeb(request)
+              assert(webRequest !== undefined, "toWeb returned undefined")
+              const body = yield* Effect.promise(() => webRequest.json())
+              return HttpServerResponse.unsafeJson({ received: body })
+            })
+          ),
+          HttpServer.serveEffect()
+        )
+        const client = yield* HttpClient.HttpClient
+        const res = yield* client.post("/echo", {
+          body: HttpBody.unsafeJson({ message: "hello" })
+        })
+        assert.strictEqual(res.status, 200)
+        const json = yield* res.json
+        assert.deepStrictEqual(json, { received: { message: "hello" } })
+      }).pipe(Effect.provide(NodeHttpServer.layerTest)))
+  })
 })

packages/platform/src/HttpServerRequest.ts

@@ -241,10 +241,13 @@ export const toWeb = (self: HttpServerRequest): Request | undefined => {
   }
   const ourl = toURL(self)
   if (Option.isNone(ourl)) return undefined
+  const body = hasBody(self.method) ? Stream.toReadableStream(self.stream) : undefined
   return new Request(ourl.value, {
     method: self.method,
-    body: hasBody(self.method) ? Stream.toReadableStream(self.stream) : undefined,
-    headers: self.headers
+    body,
+    headers: self.headers,
+    // @ts-expect-error - duplex is required for streaming bodies in Node 18+
+    duplex: body !== undefined ? "half" : undefined
   })
 }