Horus X12S externalaccessmod compatibility

[Unb0rn]

I have an extensively modified Horus X12S (ISRM module, Para Bluetooth, touchscreen, fast inverter, external access), I've been waiting for 2.8 release to have the touchscreen enabled in the official build but got a bit impatient and built it myself. The problem is - my R9M 2019 ACCESS (Flex) no longer works...
I lost my previous build but managed to find one in this discussion, reflashed it and it looks like access works fine in 2.7.1 but is not detected in own-built firmware from master branch - the option is there but the module is not detected.
I feel a bit lost - are there any new requirements for this mod? Has anyone else tried this configuration?

[raphaelcoeffic]

Regarding external ACCESS, it works for me on a modded T16. If the compilation options are correct, it should work.

Now the question is, what in your particular case does the module prevent from working properly.

As it seems to work for you on 2.7.1 (with the same compilation options?), the question would be, what exactly changed here. I must admit it is hard to debug remotely.

[Unb0rn]

I had no time to do a normal bisect, but I can confirm that:

• externalaccessmod works fine on latest commit on 2.7 branch (0713f10)
• externalaccessmod works fine with touchscreen display mod on main branch when the touchscreen was added (7a6d623) <Apr 23>
• externalaccessmod works fine on commit 162880b <Jun 12>
• externalaccessmod does NOT work on the latest main commit (40149c4) <Sep 22>
• it was not working like a week ago
  So the problem is somewhere between June 12th and September 16th...

[Unb0rn]

Made a couple more builds and narrowed the problem down to 3 commits - it turns out the problem is somewhere between commits ab6033e (working fine) and db73e4c (broken).
Most probably its this one: f952c5f
@raphaelcoeffic do I have to create an issue?

[pfeerick]

All three of those commits are from #2100, so it's no real surprise to find it was the cuplrit... it seems to have been the PR that keeps on giving! 😆

[raphaelcoeffic]

So possibly related to internal module RX DMA? If this is the case, I should be able to test this with my T16-ISRM.

[raphaelcoeffic]

@Unb0rn i believe this is fixed and should work with 2.8.0-RC3. I tested it several times lately.