#2383 - Fixed issue where VLOOKUP and HLOOKUP sometimes returned wrong value on unsorted data.#2384
Open
swmal wants to merge 1 commit into
Open
#2383 - Fixed issue where VLOOKUP and HLOOKUP sometimes returned wrong value on unsorted data.#2384swmal wants to merge 1 commit into
swmal wants to merge 1 commit into
Conversation
…g value on unsorted data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes incorrect results from
VLOOKUPandHLOOKUPwith approximate match (range_lookup= TRUE or omitted).Problem
The approximate-match binary search ran over a value-trimmed range with all blank cells removed (
GetRangeInfoByValue+GetLookupRange). This shifted the search midpoints relative to Excel, producing wrong values (sometimes0) — especially on unsorted data or ranges containing blank cells.Fix
Added
SearchAscFullRange, which searches the range while only skipping leading blanks (kept performant for whole-column references via the value edge). Inner/trailing blanks retain their positions, matching Excel's partitioning.VLOOKUPandHLOOKUPnow use this path.