From 2ca59540c4404f8130495398094558c0e755f8c9 Mon Sep 17 00:00:00 2001 From: Ania Date: Wed, 15 Apr 2020 12:19:59 +0200 Subject: [PATCH 01/28] refactor: version upgrade --- packages/commercetools/theme/package.json | 2 +- yarn.lock | 26 +++++++++++++++++++++++ 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/packages/commercetools/theme/package.json b/packages/commercetools/theme/package.json index fe27b097e..01474b490 100644 --- a/packages/commercetools/theme/package.json +++ b/packages/commercetools/theme/package.json @@ -13,7 +13,7 @@ "test": "jest" }, "dependencies": { - "@storefront-ui/vue": "^0.6.4", + "@storefront-ui/vue": "^0.7.0", "@vue-storefront/commercetools": "^0.0.3", "@vue-storefront/commercetools-api": "^0.0.3", "@vue-storefront/nuxt": "^0.0.3", diff --git a/yarn.lock b/yarn.lock index 932647334..5725c1279 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2179,6 +2179,11 @@ resolved "https://registry.yarnpkg.com/@storefront-ui/shared/-/shared-0.6.4.tgz#8e8582673d7739df76cce044ef2a12bec0ec1694" integrity sha512-gqv+l6Yl/55RtaQc26Ek0W6LW+s5Hhn7n13mC0qdtwkhmfwFnnr6wjonrvwcS5K2NvfRNug5Q1/At4UXGb6LHw== +"@storefront-ui/shared@^0.7.1": + version "0.7.1" + resolved "https://registry.yarnpkg.com/@storefront-ui/shared/-/shared-0.7.1.tgz#299105a9ff010277658a52de93ae623ed8778867" + integrity sha512-FF/JzUAjHNRY8gpzJRnj+/OpeshGQIRyvdHIXDJI7LQQ8a7gj6PurOhKly1+9+cTY015rvDoaaisox/YSmX4Ng== + "@storefront-ui/vue@^0.5.1": version "0.5.1" resolved "https://registry.yarnpkg.com/@storefront-ui/vue/-/vue-0.5.1.tgz#62c69d204232bd4050beb01963829fc4a4fbf751" @@ -2221,6 +2226,27 @@ vue2-leaflet "^2.1.1" webpack-dev-middleware "3.6.0" +"@storefront-ui/vue@^0.7.0": + version "0.7.1" + resolved "https://registry.yarnpkg.com/@storefront-ui/vue/-/vue-0.7.1.tgz#5ddccb5902689dbb59cdb0d008c65fe82c61ba40" + integrity sha512-lpOG1f8z6Ue80zsbAJ2CEalv9wpvTY6rVILL7ePT+J5J/IL6IFwlJ8GFFKE2bCk6FF4u2vswu8QL4ihfePs5Jg== + dependencies: + "@glidejs/glide" "^3.3.0" + "@storefront-ui/shared" "^0.7.1" + "@vue/babel-preset-app" "^4.0.0-alpha.1" + body-scroll-lock "^2.6.4" + core-js "^3.1.3" + hammerjs "^2.0.8" + leaflet "^1.5.1" + lozad "^1.9.0" + node-sass "^4.12.0" + sass-loader "^7.1.0" + simplebar-vue "^1.4.0" + vue-drag-drop "^1.1.4" + vue-fragment "^1.5.1" + vue2-leaflet "^2.1.1" + webpack-dev-middleware "3.6.0" + "@szmarczak/http-timer@^1.1.2": version "1.1.2" resolved "https://registry.yarnpkg.com/@szmarczak/http-timer/-/http-timer-1.1.2.tgz#b1665e2c461a2cd92f4c1bbf50d5454de0d4b421" From 40aab3a4973a0ec5deb1d275fd8ea0d9913bc616 Mon Sep 17 00:00:00 2001 From: Ania Date: Wed, 15 Apr 2020 12:36:57 +0200 Subject: [PATCH 02/28] chore: renamed spacing variables --- .../theme/components/CartSidebar.vue | 12 ++--- .../theme/components/InstagramFeed.vue | 8 ++-- .../theme/components/LoginModal.vue | 10 ++-- .../theme/components/checkout/CartPreview.vue | 20 ++++---- .../theme/components/checkout/OrderReview.vue | 10 ++-- .../theme-module/theme/pages/Category.vue | 44 ++++++++--------- .../theme-module/theme/pages/Checkout.vue | 2 +- .../theme/pages/Checkout/OrderReview.vue | 34 ++++++------- .../theme/pages/Checkout/Payment.vue | 18 +++---- .../theme/pages/Checkout/PersonalDetails.vue | 14 +++--- .../theme/pages/Checkout/Shipping.vue | 12 ++--- .../core/theme-module/theme/pages/Home.vue | 28 +++++------ .../theme-module/theme/pages/MyAccount.vue | 4 +- .../theme/pages/MyAccount/LoyaltyCard.vue | 2 +- .../theme/pages/MyAccount/MyNewsletter.vue | 18 +++---- .../theme/pages/MyAccount/MyProfile.vue | 8 ++-- .../theme/pages/MyAccount/MyReviews.vue | 2 +- .../theme/pages/MyAccount/OrderHistory.vue | 6 +-- .../theme/pages/MyAccount/ShippingDetails.vue | 14 +++--- .../core/theme-module/theme/pages/Product.vue | 48 +++++++++---------- .../core/theme-module/theme/pages/index.vue | 20 ++++---- 21 files changed, 167 insertions(+), 167 deletions(-) diff --git a/packages/core/theme-module/theme/components/CartSidebar.vue b/packages/core/theme-module/theme/components/CartSidebar.vue index 692fa3930..a1b4531b2 100644 --- a/packages/core/theme-module/theme/components/CartSidebar.vue +++ b/packages/core/theme-module/theme/components/CartSidebar.vue @@ -123,7 +123,7 @@ export default { margin: 0; } &__total-price { - margin: 0 0 var(--spacer-big) 0; + margin: 0 0 var(--spacer-xl) 0; } } .empty-cart { @@ -142,11 +142,11 @@ export default { text-align: center; } &__label { - margin: var(--spacer-extra-big) 0 0 0; + margin: var(--spacer-2xl) 0 0 0; font: 400 var(--font-size-big) / 1.6 var(--body-font-family-secondary); } &__description { - margin: var(--spacer-big) 0 0 0; + margin: var(--spacer-xl) 0 0 0; font: 300 var(--font-size-regular) / 1.6 var(--body-font-family-primary); } &__icon { @@ -160,13 +160,13 @@ export default { } .collected-product-list { flex: 1; - margin: var(--spacer-big) calc(var(--spacer-big) * -1); + margin: var(--spacer-xl) calc(var(--spacer-xl) * -1); } .collected-product { - margin: var(--spacer-big) 0; + margin: var(--spacer-xl) 0; font: 300 var(--font-size-extra-small) / 1.6 var(--body-font-family-secondary); &__properties { - margin: var(--spacer-big) 0 0 0; + margin: var(--spacer-xl) 0 0 0; } &__actions { transition: opacity 150ms ease-in-out; diff --git a/packages/core/theme-module/theme/components/InstagramFeed.vue b/packages/core/theme-module/theme/components/InstagramFeed.vue index 975e989eb..72c18705c 100644 --- a/packages/core/theme-module/theme/components/InstagramFeed.vue +++ b/packages/core/theme-module/theme/components/InstagramFeed.vue @@ -46,9 +46,9 @@ export default { &__row { display: flex; & + & { - margin-top: calc(var(--spacer-big) / 2); + margin-top: calc(var(--spacer-xl) / 2); @include for-desktop { - margin-top: var(--spacer-big); + margin-top: var(--spacer-xl); } } } @@ -56,9 +56,9 @@ export default { margin: 0; flex: 1; & + & { - margin-left: calc(var(--spacer-big) / 2); + margin-left: calc(var(--spacer-xl) / 2); @include for-desktop { - margin-left: var(--spacer-big); + margin-left: var(--spacer-xl); } } } diff --git a/packages/core/theme-module/theme/components/LoginModal.vue b/packages/core/theme-module/theme/components/LoginModal.vue index 38dc931dd..b65323fdb 100644 --- a/packages/core/theme-module/theme/components/LoginModal.vue +++ b/packages/core/theme-module/theme/components/LoginModal.vue @@ -197,7 +197,7 @@ export default { .form { &__element { - margin: 0 0 var(--spacer-extra-big) 0; + margin: 0 0 var(--spacer-2xl) 0; } } .action, @@ -205,18 +205,18 @@ export default { display: flex; align-items: center; justify-content: center; - margin: var(--spacer-big) 0 var(--spacer-big) 0; + margin: var(--spacer-xl) 0 var(--spacer-xl) 0; font: 300 var(--font-size-regular) / 1.6 var(--body-font-family-secondary); & > * { margin: 0 0 0 var(--spacer); } } .action { - margin: var(--spacer-big) 0 var(--spacer-big) 0; + margin: var(--spacer-xl) 0 var(--spacer-xl) 0; } .bottom { - padding: var(--spacer-extra-big) 0 0 0; - margin: var(--spacer-extra-big) 0 0 0; + padding: var(--spacer-2xl) 0 0 0; + margin: var(--spacer-2xl) 0 0 0; border: 1px solid var(--c-light); border-width: 1px 0 0 0; } diff --git a/packages/core/theme-module/theme/components/checkout/CartPreview.vue b/packages/core/theme-module/theme/components/checkout/CartPreview.vue index 030dc87ac..380082c33 100644 --- a/packages/core/theme-module/theme/components/checkout/CartPreview.vue +++ b/packages/core/theme-module/theme/components/checkout/CartPreview.vue @@ -175,8 +175,8 @@ export default { box-sizing: border-box; width: 100%; background-color: #f1f2f3; - padding: var(--spacer-extra-big); - margin-bottom: var(--spacer-big); + padding: var(--spacer-2xl); + margin-bottom: var(--spacer-xl); &:last-child { margin-bottom: 0; } @@ -185,13 +185,13 @@ export default { } } .title { - margin-bottom: var(--spacer-extra-big); + margin-bottom: var(--spacer-2xl); } .total-items { display: flex; justify-content: space-between; align-items: center; - margin-bottom: var(--spacer-big); + margin-bottom: var(--spacer-xl); } .property { margin-bottom: var(--spacer); @@ -200,7 +200,7 @@ export default { } } .property-total { - margin-top: var(--spacer-extra-big); + margin-top: var(--spacer-2xl); font-size: var(--font-size-extra-big-desktop); font-weight: 500; ::v-deep .sf-property__name { @@ -212,12 +212,12 @@ export default { } .collected-product { &:not(:last-child) { - margin-bottom: var(--spacer-big); + margin-bottom: var(--spacer-xl); } } .characteristic { &:not(:last-child) { - margin-bottom: var(--spacer-big); + margin-bottom: var(--spacer-xl); } } .promo-code { @@ -228,7 +228,7 @@ export default { font-size: var(--font-size-big-desktop); } &__input { - margin: var(--spacer-big) 0; + margin: var(--spacer-xl) 0; ::v-deep input { border-color: var(--c-gray-variant); } @@ -236,7 +236,7 @@ export default { } .product { &__properties { - margin: var(--spacer-big) 0 0 0; + margin: var(--spacer-xl) 0 0 0; } &__property, &__action { @@ -245,7 +245,7 @@ export default { &__action { color: var(--c-gray-variant); font-size: var(--font-size-extra-small-desktop); - margin: 0 0 var(--spacer-small) 0; + margin: 0 0 var(--spacer-sm) 0; &:last-child { margin: 0; } diff --git a/packages/core/theme-module/theme/components/checkout/OrderReview.vue b/packages/core/theme-module/theme/components/checkout/OrderReview.vue index 5febde615..431f8cd19 100644 --- a/packages/core/theme-module/theme/components/checkout/OrderReview.vue +++ b/packages/core/theme-module/theme/components/checkout/OrderReview.vue @@ -84,8 +84,8 @@ export default { box-sizing: border-box; width: 100%; background-color: #f1f2f3; - padding: var(--spacer-extra-big); - margin-bottom: var(--spacer-big); + padding: var(--spacer-2xl); + margin-bottom: var(--spacer-xl); &:last-child { margin-bottom: 0; } @@ -96,7 +96,7 @@ export default { display: flex; justify-content: space-between; align-items: center; - margin-bottom: var(--spacer-big); + margin-bottom: var(--spacer-xl); } &__title { font-family: var(--body-font-family-primary); @@ -105,10 +105,10 @@ export default { } } .title { - margin-bottom: var(--spacer-extra-big); + margin-bottom: var(--spacer-2xl); } .content { - margin: 0 0 var(--spacer-big) 0; + margin: 0 0 var(--spacer-xl) 0; color: var(--c-text); font-size: var(--font-size-extra-small-desktop); font-weight: 300; diff --git a/packages/core/theme-module/theme/pages/Category.vue b/packages/core/theme-module/theme/pages/Category.vue index d825662bd..7945ef441 100644 --- a/packages/core/theme-module/theme/pages/Category.vue +++ b/packages/core/theme-module/theme/pages/Category.vue @@ -478,19 +478,19 @@ export default { } } .section { - padding: 0 var(--spacer-big); + padding: 0 var(--spacer-xl); @include for-desktop { padding: 0; } } .breadcrumbs { - padding: var(--spacer-big) var(--spacer-extra-big) var(--spacer-extra-big) - var(--spacer-extra-big); + padding: var(--spacer-xl) var(--spacer-2xl) var(--spacer-2xl) + var(--spacer-2xl); } .navbar { position: relative; display: flex; - font: 300 var(--font-size-small) / 1.6 var(--body-font-family-primary); + font: 300 var(--font-size-small) / 1.6 var(--font-family-primary); @include for-desktop { border: 1px solid var(--c-light); border-width: 1px 0 1px 0; @@ -498,8 +498,8 @@ export default { &::after { position: absolute; bottom: 0; - left: var(--spacer-big); - width: calc(100% - calc(var(--spacer-big) * 2)); + left: var(--spacer-xl); + width: calc(100% - calc(var(--spacer-xl) * 2)); height: 1px; background: var(--c-light); content: ""; @@ -511,16 +511,16 @@ export default { &__main { display: flex; align-items: center; - padding: var(--spacer-medium) 0; + padding: var(--spacer-lg) 0; font-size: var(--font-size-small); line-height: 1.6; @include for-desktop { - padding: var(--spacer-big) 0; + padding: var(--spacer-xl) 0; } } &__aside { flex: 0 0 15%; - padding: var(--spacer-big) var(--spacer-extra-big); + padding: var(--spacer-xl) var(--spacer-2xl); border: 1px solid var(--c-light); border-width: 0 1px 0 0; } @@ -542,7 +542,7 @@ export default { display: flex; align-items: center; @include for-desktop { - margin: 0 0 0 var(--spacer-extra-big); + margin: 0 0 0 var(--spacer-2xl); } svg { fill: var(--c-text-muted); @@ -560,7 +560,7 @@ export default { &__sort { display: flex; align-items: center; - margin: 0 auto 0 var(--spacer-extra-big); + margin: 0 auto 0 var(--spacer-2xl); --select-font-size: var(--font-size-small); } &__counter { @@ -572,9 +572,9 @@ export default { &__view { display: flex; align-items: center; - margin: 0 var(--spacer-extra-big); + margin: 0 var(--spacer-2xl); @include for-desktop { - margin: var(--spacer-big); + margin: var(--spacer-xl); } &-icon { margin: 0 0 0 0.625rem; @@ -593,7 +593,7 @@ export default { } .sidebar { flex: 0 0 15%; - padding: var(--spacer-extra-big); + padding: var(--spacer-2xl); border: 1px solid var(--c-light); border-width: 0 1px 0 0; } @@ -602,7 +602,7 @@ export default { flex: 1; margin: 0 calc(var(--spacer) * -1); @include for-desktop { - margin: var(--spacer-big); + margin: var(--spacer-xl); } @include for-mobile { display: flex; @@ -624,7 +624,7 @@ export default { --product-card-padding: var(--spacer); flex: 1 1 50%; @include for-desktop { - --product-card-padding: var(--spacer-big); + --product-card-padding: var(--spacer-xl); flex: 1 1 25%; } } @@ -648,7 +648,7 @@ export default { --product-card-horizontal-padding: var(--spacer); flex: 0 0 100%; @include for-desktop { - --product-card-horizontal-padding: var(--spacer-big); + --product-card-horizontal-padding: var(--spacer-xl); } } &__slide-enter { @@ -663,18 +663,18 @@ export default { @include for-desktop { display: flex; justify-content: center; - margin: var(--spacer-extra-big) 0 0 0; + margin: var(--spacer-2xl) 0 0 0; } } } .filters { - padding: var(--spacer-big); + padding: var(--spacer-xl); &__title { - margin: calc(var(--spacer-big) * 3) 0 var(--spacer-big) 0; + margin: calc(var(--spacer-xl) * 3) 0 var(--spacer-xl) 0; font: 400 var(--font-size-extra-big) / 1.6 var(--body-font-family-secondary); line-height: 1.6; &:first-child { - margin: 0 0 var(--spacer-big) 0; + margin: 0 0 var(--spacer-xl) 0; } } &__colors { @@ -687,7 +687,7 @@ export default { margin: var(--spacer) 0; } &__buttons { - margin: calc(var(--spacer-big) * 3) 0 0 0; + margin: calc(var(--spacer-xl) * 3) 0 0 0; } &__button-clear { --button-background: var(--c-light); diff --git a/packages/core/theme-module/theme/pages/Checkout.vue b/packages/core/theme-module/theme/pages/Checkout.vue index 10099bda4..f148a2923 100644 --- a/packages/core/theme-module/theme/pages/Checkout.vue +++ b/packages/core/theme-module/theme/pages/Checkout.vue @@ -84,7 +84,7 @@ export default { #checkout { box-sizing: border-box; - padding: 0 var(--spacer-big); + padding: 0 var(--spacer-xl); @include for-desktop { max-width: 1240px; margin: 0 auto; diff --git a/packages/core/theme-module/theme/pages/Checkout/OrderReview.vue b/packages/core/theme-module/theme/pages/Checkout/OrderReview.vue index 8c25209e8..c64cb3f82 100644 --- a/packages/core/theme-module/theme/pages/Checkout/OrderReview.vue +++ b/packages/core/theme-module/theme/pages/Checkout/OrderReview.vue @@ -240,7 +240,7 @@ export default { @import "~@storefront-ui/vue/styles"; .title { - margin: 0 0 var(--spacer-extra-big); + margin: 0 0 var(--spacer-2xl); } .form { @include for-desktop { @@ -249,7 +249,7 @@ export default { align-items: center; } &__element { - margin: 0 0 var(--spacer-extra-big) 0; + margin: 0 0 var(--spacer-2xl) 0; @include for-desktop { flex: 0 0 100%; } @@ -259,7 +259,7 @@ export default { } &-even { @include for-desktop { - padding: 0 0 0 var(--spacer-extra-big); + padding: 0 0 0 var(--spacer-2xl); } } } @@ -276,7 +276,7 @@ export default { } &__action-button { &--secondary { - --button-margin: var(--spacer-big) 0; + --button-margin: var(--spacer-xl) 0; @include for-desktop { order: -1; --button-margin: 0; @@ -292,11 +292,11 @@ export default { } &__radio-group { flex: 0 0 100%; - margin: 0 0 var(--spacer-extra-big) 0; + margin: 0 0 var(--spacer-2xl) 0; } } .table { - margin: 0 0 var(--spacer-big) 0; + margin: 0 0 var(--spacer-xl) 0; &__header { font: 300 var(--font-size-regular) / 1.6 var(--body-font-family-secondary); @include for-desktop { @@ -335,25 +335,25 @@ export default { } .summary { background: var(--c-light); - margin: 0 calc(var(--spacer-big) * -1); - padding: var(--spacer-big); + margin: 0 calc(var(--spacer-xl) * -1); + padding: var(--spacer-xl); @include for-desktop { background: transparent; } &__group { @include for-desktop { display: flex; - margin: 0 0 var(--spacer-extra-big) 0; + margin: 0 0 var(--spacer-2xl) 0; } } &__terms { flex: 1; order: -1; - margin: 0 0 var(--spacer-big) 0; + margin: 0 0 var(--spacer-xl) 0; } &__total { - margin: 0 0 var(--spacer-extra-big) 0; - padding: 0 var(--spacer-big); + margin: 0 0 var(--spacer-2xl) 0; + padding: 0 var(--spacer-xl); flex: 0 0 16.875rem; @include for-desktop { padding: 0; @@ -361,7 +361,7 @@ export default { } &__action-button { &--secondary { - margin: var(--spacer-big) 0; + margin: var(--spacer-xl) 0; @include for-desktop { order: -1; margin: 0; @@ -374,20 +374,20 @@ export default { var(--body-font-family-secondary); --property-value-font: 500 var(--font-size-big) / 1.6 var(--body-font-family-secondary); - margin: var(--spacer-big) 0 0 0; + margin: var(--spacer-xl) 0 0 0; text-transform: uppercase; font: 500 var(--font-size-big) / 1.6 var(--body-font-family-secondary); } } .property { - margin: 0 0 var(--spacer-big) 0; + margin: 0 0 var(--spacer-xl) 0; font: 400 var(--font-size-regular) / 1.6 var(--body-font-family-secondary); &__name { color: var(--c-text-muted); } } .accordion { - margin: 0 0 var(--spacer-extra-big) 0; + margin: 0 0 var(--spacer-2xl) 0; &__item { display: flex; align-items: flex-start; @@ -400,7 +400,7 @@ export default { } } .content { - margin: 0 0 var(--spacer-big) 0; + margin: 0 0 var(--spacer-xl) 0; font: 300 var(--font-size-mall) / 1.6 var(--body-font-family-secondary); color: var(--c-text); &:last-child { diff --git a/packages/core/theme-module/theme/pages/Checkout/Payment.vue b/packages/core/theme-module/theme/pages/Checkout/Payment.vue index 895792f6a..034dbe0cd 100644 --- a/packages/core/theme-module/theme/pages/Checkout/Payment.vue +++ b/packages/core/theme-module/theme/pages/Checkout/Payment.vue @@ -188,7 +188,7 @@ export default { diff --git a/packages/core/theme-module/theme/pages/Checkout/Shipping.vue b/packages/core/theme-module/theme/pages/Checkout/Shipping.vue index 6dc1ad7f5..7e30aea17 100644 --- a/packages/core/theme-module/theme/pages/Checkout/Shipping.vue +++ b/packages/core/theme-module/theme/pages/Checkout/Shipping.vue @@ -176,7 +176,7 @@ export default { diff --git a/packages/core/theme-module/theme/pages/MyAccount/LoyaltyCard.vue b/packages/core/theme-module/theme/pages/MyAccount/LoyaltyCard.vue index 74c75fd08..0f2d7acc0 100644 --- a/packages/core/theme-module/theme/pages/MyAccount/LoyaltyCard.vue +++ b/packages/core/theme-module/theme/pages/MyAccount/LoyaltyCard.vue @@ -29,7 +29,7 @@ export default { } } .message { - margin: 0 0 var(--spacer-extra-big) 0; + margin: 0 0 var(--spacer-2xl) 0; font: 300 var(--font-size-regular) / 1.6 var(--body-font-family-secondary); &__label { font-weight: 500; diff --git a/packages/core/theme-module/theme/pages/MyAccount/MyNewsletter.vue b/packages/core/theme-module/theme/pages/MyAccount/MyNewsletter.vue index 68c0ba417..d13948fb8 100644 --- a/packages/core/theme-module/theme/pages/MyAccount/MyNewsletter.vue +++ b/packages/core/theme-module/theme/pages/MyAccount/MyNewsletter.vue @@ -54,11 +54,11 @@ export default { diff --git a/packages/core/theme-module/theme/pages/MyAccount/MyReviews.vue b/packages/core/theme-module/theme/pages/MyAccount/MyReviews.vue index f8075c517..c25170f66 100644 --- a/packages/core/theme-module/theme/pages/MyAccount/MyReviews.vue +++ b/packages/core/theme-module/theme/pages/MyAccount/MyReviews.vue @@ -30,7 +30,7 @@ export default { } .message { margin: 0 0 var(--spacer-2xl) 0; - font: 300 var(--font-size-regular) / 1.6 var(--body-font-family-secondary); + font: 300 var(--font-base) / 1.6 var(--font-family-secondary); &__label { font-weight: 500; } diff --git a/packages/core/theme-module/theme/pages/MyAccount/OrderHistory.vue b/packages/core/theme-module/theme/pages/MyAccount/OrderHistory.vue index 5106d0fac..208cc9996 100644 --- a/packages/core/theme-module/theme/pages/MyAccount/OrderHistory.vue +++ b/packages/core/theme-module/theme/pages/MyAccount/OrderHistory.vue @@ -105,10 +105,10 @@ export default { .no-orders { &__title { margin: 0 0 var(--spacer-xl) 0; - font: 500 var(--font-size-regular) / 1.6 var(--body-font-family-secondary); + font: 500 var(--font-base) / 1.6 var(--font-family-secondary); } &__content { - font: 300 var(--font-size-regular) / 1.6 var(--body-font-family-secondary); + font: 300 var(--font-base) / 1.6 var(--font-family-secondary); } &__button { --button-width: 100%; @@ -120,7 +120,7 @@ export default { .orders { &__download-all { --button-padding: 0.625rem var(--spacer-xl); - --button-font-size: var(--font-size-extra-small); + --button-font-size: var(--font-xs); white-space: nowrap; } &__view { @@ -131,7 +131,7 @@ export default { } .message { margin: 0 0 var(--spacer-2xl) 0; - font: 300 var(--font-size-regular) / 1.6 var(--body-font-family-secondary); + font: 300 var(--font-base) / 1.6 var(--font-family-secondary); &__label { font-weight: 500; } diff --git a/packages/core/theme-module/theme/pages/MyAccount/ShippingDetails.vue b/packages/core/theme-module/theme/pages/MyAccount/ShippingDetails.vue index 3bc76ed32..1fd2c7340 100644 --- a/packages/core/theme-module/theme/pages/MyAccount/ShippingDetails.vue +++ b/packages/core/theme-module/theme/pages/MyAccount/ShippingDetails.vue @@ -370,12 +370,11 @@ export default { } .message { margin: 0 0 var(--spacer-2xl) 0; - font-family: var(--body-font-family-primary); - font-weight: var(--body-font-weight-primary); + font-family: var(--font-family-primary); line-height: 1.6; - font-size: var(--font-size-regular-mobile); + font-size: var(--font-base-mobile); @include for-desktop { - font-size: var(--font-size-regular-desktop); + font-size: var(--font-base-desktop); } } .shipping-list { @@ -391,11 +390,11 @@ export default { &__content { flex: 1; color: var(--c-text); - font-size: var(--font-size-small-mobile); + font-size: var(--font-sm-mobile); font-weight: 300; line-height: 1.6; @include for-desktop { - font-size: var(--font-size-small-desktop); + font-size: var(--font-sm-desktop); } } &__actions { @@ -424,7 +423,7 @@ export default { } } &__client-name { - font-size: var(--font-size-regular-desktop); + font-size: var(--font-base-desktop); font-weight: 500; } } diff --git a/packages/core/theme-module/theme/pages/Product.vue b/packages/core/theme-module/theme/pages/Product.vue index d54df8213..0535182dc 100644 --- a/packages/core/theme-module/theme/pages/Product.vue +++ b/packages/core/theme-module/theme/pages/Product.vue @@ -391,12 +391,10 @@ export default { } .product-details { &__heading { - --heading-title-font-size: var(--font-size-big); - --heading-title-font-weight: var(--body-font-weight-primary); + --heading-title-font-size: var(--font-lg); margin: var(--spacer-xl) 0 0 0; @include for-desktop { --heading-title-font-size: var(--h1-font-size); - --heading-title-font-weight: var(--body-font-weight-secondary); margin: 0; } } @@ -409,7 +407,7 @@ export default { } } &__sub-price { - --price-font-size: 1.5rem; + --price-font-size: var(--font-xl); } &__sub-rating { display: flex; @@ -421,7 +419,7 @@ export default { } &__sub-reviews { margin: 0 0 0 0.625rem; - font-size: var(--font-size-extra-small); + font-size: var(--font-xs); } &__section { border: 1px solid var(--c-light); @@ -440,24 +438,24 @@ export default { } } &__add-to-cart { - margin: 1.5rem 0 0 0; + margin: var(--spacer-base) 0 0 0; @include for-desktop { margin: var(--spacer-2xl) 0 0 0; } } &__alert { - margin: 1.5rem 0 0 0; + margin: var(--spacer-base) 0 0 0; } &__attribute { margin: 0 0 var(--spacer-xl) 0; } &__description { margin: var(--spacer-2xl) 0 calc(var(--spacer-xl) * 3) 0; - font-family: var(--body-font-family-secondary); - font-size: var(--font-size-regular); + font-family: var(--font-family-secondary); + font-size: var(--font-base); line-height: 1.6; @include for-desktop { - font-size: var(--font-size-regular); + font-size: var(--font-base); } } &__properties { @@ -517,9 +515,7 @@ export default { .banner-app { --banner-title-margin: var(--spacer-xl) 0 0 0; --banner-title-font-size: var(--h1-font-size); - --banner-title-font-weight: var(--h1-font-weight); --banner-subtitle-font-size: var(--font-size-extra-big); - --banner-subtitle-font-weight: var(--body-font-weight-primary); min-height: 26.25rem; max-width: 65rem; margin: 0 auto; diff --git a/packages/core/theme-module/theme/pages/index.vue b/packages/core/theme-module/theme/pages/index.vue index 3f7429cd9..30d285991 100644 --- a/packages/core/theme-module/theme/pages/index.vue +++ b/packages/core/theme-module/theme/pages/index.vue @@ -94,6 +94,7 @@ @@ -81,6 +77,7 @@ export default { } &__lang { --image-width: 20px; + --button-box-shadow: none; background: none; padding: 0 5px; display: flex; diff --git a/packages/core/theme-module/theme/components/TopBar.vue b/packages/core/theme-module/theme/components/TopBar.vue index 7e8bc81ae..4ea250cc2 100644 --- a/packages/core/theme-module/theme/components/TopBar.vue +++ b/packages/core/theme-module/theme/components/TopBar.vue @@ -8,7 +8,6 @@ Find out more From 9d0a91fab473bc331882f78f7921769a0ae6b367 Mon Sep 17 00:00:00 2001 From: Ania Date: Fri, 17 Apr 2020 11:53:56 +0200 Subject: [PATCH 08/28] refactor: fixed issues with bottom navigation overflowing the content --- .../theme-module/theme/assets/css/reset.scss | 5 +++ .../theme/components/AppHeader.vue | 1 + .../theme/components/BottomNavigation.vue | 38 ++++++++++--------- .../theme-module/theme/layouts/account.vue | 2 +- .../theme-module/theme/layouts/default.vue | 2 +- .../core/theme-module/theme/pages/Home.vue | 2 +- 6 files changed, 30 insertions(+), 20 deletions(-) diff --git a/packages/core/theme-module/theme/assets/css/reset.scss b/packages/core/theme-module/theme/assets/css/reset.scss index 8e1b2deb8..c09f0c9c7 100644 --- a/packages/core/theme-module/theme/assets/css/reset.scss +++ b/packages/core/theme-module/theme/assets/css/reset.scss @@ -1,5 +1,10 @@ // Reset CSS +html { + width: auto; + overflow-x: hidden; +} body { + overflow-x: hidden; color: var(--c-text); font-size: var(--font-base); font-family: var(--font-family-primary); diff --git a/packages/core/theme-module/theme/components/AppHeader.vue b/packages/core/theme-module/theme/components/AppHeader.vue index 3ca56cc88..6bef1370c 100644 --- a/packages/core/theme-module/theme/components/AppHeader.vue +++ b/packages/core/theme-module/theme/components/AppHeader.vue @@ -5,6 +5,7 @@ @click:account="onAccountClicked" :cartItemsQty="cartTotalItems" > +