Please include:
- Library version: "com.github.Dimezis:BlurView:version-3.2.0"
In BlurViewFacade.setBlurRadius, the default value is noted:
|
/** |
|
* @param radius sets the blur radius. The real blur radius is radius * scaleFactor. |
|
* Default value is {@link BlurController#DEFAULT_BLUR_RADIUS} |
|
* @return {@link BlurViewFacade} |
|
*/ |
|
BlurViewFacade setBlurRadius(float radius); |
and is defined in
|
float DEFAULT_BLUR_RADIUS = 16f; |
However, in RenderNodeBlurController.java it is not used, instead it is set to 1f
|
private float blurRadius = 1f; |
So
binding.blurView.setupWith(binding.blurTarget)
.setBlurRadius(BlurController.DEFAULT_BLUR_RADIUS)
gives a very different result to
binding.blurView.setupWith(binding.blurTarget)
on systems where RenderNodeBlurController is used (i.e., where hardware rendering is available).
Fixing this to use the same default in both should probably be considered a breaking change in the library, warranting a major version bump, as it will cause the externally-visible default behaviour to change.
Please include:
In
BlurViewFacade.setBlurRadius, the default value is noted:BlurView/library/src/main/java/eightbitlab/com/blurview/BlurViewFacade.java
Lines 34 to 39 in fbd355b
and is defined in
BlurView/library/src/main/java/eightbitlab/com/blurview/BlurController.java
Line 8 in fbd355b
However, in
RenderNodeBlurController.javait is not used, instead it is set to1fBlurView/library/src/main/java/eightbitlab/com/blurview/RenderNodeBlurController.java
Line 34 in fbd355b
So
binding.blurView.setupWith(binding.blurTarget) .setBlurRadius(BlurController.DEFAULT_BLUR_RADIUS)gives a very different result to
on systems where RenderNodeBlurController is used (i.e., where hardware rendering is available).
Fixing this to use the same default in both should probably be considered a breaking change in the library, warranting a major version bump, as it will cause the externally-visible default behaviour to change.