From 13b1d4fde976a1d9392db4ff36172671a7eee129 Mon Sep 17 00:00:00 2001 From: detachhead Date: Thu, 25 Jun 2026 11:29:36 +1000 Subject: [PATCH 1/3] bump playwright --- .github/workflows/test and publish.yaml | 2 +- package-lock.json | 24 ++++++++++++------------ package.json | 4 ++-- 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/.github/workflows/test and publish.yaml b/.github/workflows/test and publish.yaml index 5e941fd..3f325eb 100644 --- a/.github/workflows/test and publish.yaml +++ b/.github/workflows/test and publish.yaml @@ -10,7 +10,7 @@ jobs: build-and-test: runs-on: ubuntu-latest container: - image: mcr.microsoft.com/playwright:v1.53.1 + image: mcr.microsoft.com/playwright:v1.61.1 options: --user 1001 steps: - uses: actions/checkout@v4 diff --git a/package-lock.json b/package-lock.json index c204594..0328839 100644 --- a/package-lock.json +++ b/package-lock.json @@ -18,7 +18,7 @@ }, "devDependencies": { "@detachhead/eslint-config": "^1.5.0", - "@playwright/test": "1.53.1", + "@playwright/test": "1.61.1", "@sapui5/ts-types-esm": "^1.123.1", "@trivago/prettier-plugin-sort-imports": "^4.1.1", "@types/eslint": "^8.4.6", @@ -756,13 +756,13 @@ } }, "node_modules/@playwright/test": { - "version": "1.53.1", - "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.53.1.tgz", - "integrity": "sha512-Z4c23LHV0muZ8hfv4jw6HngPJkbbtZxTkxPNIg7cJcTc9C28N/p2q7g3JZS2SiKBBHJ3uM1dgDye66bB7LEk5w==", + "version": "1.61.1", + "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.61.1.tgz", + "integrity": "sha512-8nKv6+0RJSL9FE4jYOEGXnPeM/Hg12qZpmqzZjRh3qM0Y7c3z1mrOTfFLids72RDQYVh9WpLEfR5WdpNX4fkig==", "dev": true, "license": "Apache-2.0", "dependencies": { - "playwright": "1.53.1" + "playwright": "1.61.1" }, "bin": { "playwright": "cli.js" @@ -4457,13 +4457,13 @@ } }, "node_modules/playwright": { - "version": "1.53.1", - "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.53.1.tgz", - "integrity": "sha512-LJ13YLr/ocweuwxyGf1XNFWIU4M2zUSo149Qbp+A4cpwDjsxRPj7k6H25LBrEHiEwxvRbD8HdwvQmRMSvquhYw==", + "version": "1.61.1", + "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.61.1.tgz", + "integrity": "sha512-DWnY5o3YbLWK4GovuAVwpqL+1VwGNdUGrRr++8j8PtQQzvAVZUIMjKQ90fY689sEJZJBbZVw1rXaOKSTitkzPQ==", "dev": true, "license": "Apache-2.0", "dependencies": { - "playwright-core": "1.53.1" + "playwright-core": "1.61.1" }, "bin": { "playwright": "cli.js" @@ -4476,9 +4476,9 @@ } }, "node_modules/playwright-core": { - "version": "1.53.1", - "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.53.1.tgz", - "integrity": "sha512-Z46Oq7tLAyT0lGoFx4DOuB1IA9D1TPj0QkYxpPVUnGDqHHvDpCftu1J2hM2PiWsNMoZh8+LQaarAWcDfPBc6zg==", + "version": "1.61.1", + "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.61.1.tgz", + "integrity": "sha512-h7Qlt6m4REp25qvIdvbDtVmD4LqVXfpRxhORv9L0jzETM05p4fuPJ3dKyuSXQxDSbXnmS79HAgi9589lGSpLkg==", "license": "Apache-2.0", "bin": { "playwright-core": "cli.js" diff --git a/package.json b/package.json index 1311ab9..e3aece6 100644 --- a/package.json +++ b/package.json @@ -28,7 +28,7 @@ }, "devDependencies": { "@detachhead/eslint-config": "^1.5.0", - "@playwright/test": "1.53.1", + "@playwright/test": "1.61.1", "@sapui5/ts-types-esm": "^1.123.1", "@trivago/prettier-plugin-sort-imports": "^4.1.1", "@types/eslint": "^8.4.6", @@ -51,7 +51,7 @@ "xmlbuilder2": "^3.1.1" }, "devEngines": { - "runtime": {"name": "node", "version": "24.14.1"} + "runtime": {"name": "node", "version": "26.3.1"} }, "//": [ "https://github.com/trivago/prettier-plugin-sort-imports/issues/204#issuecomment-1431287240", From 1dd33502461c736e111a1c76dc228fbd86cfaa8a Mon Sep 17 00:00:00 2001 From: detachhead Date: Thu, 25 Jun 2026 10:14:15 +1000 Subject: [PATCH 2/3] update vscode settings --- .vscode/settings.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.vscode/settings.json b/.vscode/settings.json index bd171ff..3ab22e7 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -29,5 +29,7 @@ }, "terminal.integrated.env.linux": { "PATH": "${workspaceFolder}/node_modules/.bin:${env:PATH}" - } + }, + "chat.disableAIFeatures": true, + "telemetry.feedback.enabled": false } From 2c75b9da08efd541e0da2fac3c276d0a3ee81e90 Mon Sep 17 00:00:00 2001 From: detachhead Date: Thu, 25 Jun 2026 12:15:39 +1000 Subject: [PATCH 3/3] update the ui5 version used in the tests --- tests/testUtils.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/testUtils.ts b/tests/testUtils.ts index 658412e..9f8c50a 100644 --- a/tests/testUtils.ts +++ b/tests/testUtils.ts @@ -11,7 +11,9 @@ export class Ui5Tester { this.selectorEngineId = `ui5_${selectorEngineName}` } navigateToUi5DocsPage = async (page: Page, path: `/${string}`) => { - await page.goto(`https://ui5.sap.com/1.127.7${path}`) + // TODO: we have no control over this site, and versions get removed from it regularly. + // should host our version or make our own minimal ui5 test app or something + await page.goto(`https://ui5.sap.com/1.130.11${path}`) await page.waitForSelector( `${this.selectorEngineId}=${ this.selectorEngineName === 'css' ? '*' : '//*'