From 31859fab28709c7a2b0c77f23c9361d96b3f7681 Mon Sep 17 00:00:00 2001 From: detachhead Date: Mon, 13 Apr 2026 19:01:19 +1000 Subject: [PATCH 1/6] fix missing `async` in readme example --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index a344d6c..c8690d1 100644 --- a/README.md +++ b/README.md @@ -32,7 +32,7 @@ test.beforeAll(async () => { await selectors.register('ui5', css) }) -test('ui5 example', ({ page }) => { +test('ui5 example', async ({ page }) => { await page.goto('https://ui5.sap.com/') await page.click("ui5=sap.m.Button[text='Get Started with UI5']") }) From bfd65a80c1308393c39ec93dc05a3996cf380158 Mon Sep 17 00:00:00 2001 From: detachhead Date: Mon, 13 Apr 2026 19:01:41 +1000 Subject: [PATCH 2/6] remove abandoned git graph vscode extension from recommendations --- .vscode/extensions.json | 1 - 1 file changed, 1 deletion(-) diff --git a/.vscode/extensions.json b/.vscode/extensions.json index 50e3e56..62e2e73 100644 --- a/.vscode/extensions.json +++ b/.vscode/extensions.json @@ -2,7 +2,6 @@ "recommendations": [ "esbenp.prettier-vscode", "dbaeumer.vscode-eslint", - "mhutchie.git-graph", "ms-playwright.playwright", "github.vscode-github-actions" ] From 551d9a0771156ad39ca18fadd9d9d16369026e03 Mon Sep 17 00:00:00 2001 From: detachhead Date: Mon, 13 Apr 2026 19:03:02 +1000 Subject: [PATCH 3/6] update vscode config to no longer use deprecated typescript settings --- .vscode/settings.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.vscode/settings.json b/.vscode/settings.json index 886e6ca..5f45512 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -1,5 +1,6 @@ { - "typescript.tsdk": "node_modules/typescript/lib", + "js/ts.tsdk.path": "node_modules/typescript/lib", + "js/ts.tsdk.promptToUseWorkspaceVersion": true, "editor.formatOnSave": true, "prettier.configPath": ".prettierrc.json", "editor.defaultFormatter": "esbenp.prettier-vscode", @@ -18,7 +19,6 @@ "git.useCommitInputAsStashMessage": true, "diffEditor.ignoreTrimWhitespace": false, "files.eol": "\n", - "typescript.enablePromptUseWorkspaceTsdk": true, "editor.acceptSuggestionOnCommitCharacter": false, "git.useEditorAsCommitInput": false } From 255d850dd3f7d849aefa1ac4e32d5f5db9a03eb6 Mon Sep 17 00:00:00 2001 From: detachhead Date: Mon, 13 Apr 2026 19:03:45 +1000 Subject: [PATCH 4/6] add `node_modules/.bin` to `PATH` in vscode terminal --- .vscode/settings.json | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/.vscode/settings.json b/.vscode/settings.json index 5f45512..bd171ff 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -20,5 +20,14 @@ "diffEditor.ignoreTrimWhitespace": false, "files.eol": "\n", "editor.acceptSuggestionOnCommitCharacter": false, - "git.useEditorAsCommitInput": false + "git.useEditorAsCommitInput": false, + "terminal.integrated.env.windows": { + "PATH": "${workspaceFolder}/node_modules/.bin;${env:PATH}" + }, + "terminal.integrated.env.osx": { + "PATH": "${workspaceFolder}/node_modules/.bin:${env:PATH}" + }, + "terminal.integrated.env.linux": { + "PATH": "${workspaceFolder}/node_modules/.bin:${env:PATH}" + } } From 357a07da98ea1617a403df6ac9e8953ea63a28bd Mon Sep 17 00:00:00 2001 From: detachhead Date: Mon, 13 Apr 2026 19:03:57 +1000 Subject: [PATCH 5/6] update package-lock.json --- package-lock.json | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index cf2f4ff..c204594 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "playwright-ui5", - "version": "1.6.5", + "version": "1.6.9", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "playwright-ui5", - "version": "1.6.5", + "version": "1.6.9", "license": "ISC", "dependencies": { "css-selector-parser": "^2", @@ -289,6 +289,19 @@ "node": ">=6.9.0" } }, + "node_modules/@babel/traverse/node_modules/@babel/generator/node_modules/@babel/parser": { + "version": "7.20.15", + "resolved": "https://registry.npmjs.org/@babel/parser/-/parser-7.20.15.tgz", + "integrity": "sha512-DI4a1oZuf8wC+oAJA9RW6ga3Zbe8RZFt7kD9i4qAspz3I/yHet1VvC3DiSy/fsUvv5pvJuNPh0LPOdCcqinDPg==", + "dev": true, + "license": "MIT", + "bin": { + "parser": "bin/babel-parser.js" + }, + "engines": { + "node": ">=6.0.0" + } + }, "node_modules/@babel/traverse/node_modules/@babel/parser": { "version": "7.27.5", "resolved": "https://registry.npmjs.org/@babel/parser/-/parser-7.27.5.tgz", From 5a8949029095d2553cf134d39701b8a5d26655eb Mon Sep 17 00:00:00 2001 From: detachhead Date: Mon, 13 Apr 2026 19:13:51 +1000 Subject: [PATCH 6/6] why does ths ci fucking break on its own every time i revisit this project --- .github/workflows/test and publish.yaml | 7 +++++-- package.json | 3 +++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test and publish.yaml b/.github/workflows/test and publish.yaml index 01dedb2..5e941fd 100644 --- a/.github/workflows/test and publish.yaml +++ b/.github/workflows/test and publish.yaml @@ -14,6 +14,9 @@ jobs: options: --user 1001 steps: - uses: actions/checkout@v4 + - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f + with: + node-version-file: package.json - run: npm ci - run: npm run check - name: upload compiled code @@ -61,9 +64,9 @@ jobs: pull-requests: read steps: - uses: actions/checkout@v4 - - uses: actions/setup-node@v4 + - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f with: - node-version: 16.9.1 + node-version-file: package.json - run: echo ::set-output name=CURRENT_VERSION::$(node -p "require(\"./package.json\").version") id: current-version - if: github.ref == 'refs/heads/master' diff --git a/package.json b/package.json index b0d0fc4..1311ab9 100644 --- a/package.json +++ b/package.json @@ -50,6 +50,9 @@ "throw-expression": "^1.0.2", "xmlbuilder2": "^3.1.1" }, + "devEngines": { + "runtime": {"name": "node", "version": "24.14.1"} + }, "//": [ "https://github.com/trivago/prettier-plugin-sort-imports/issues/204#issuecomment-1431287240", "https://github.com/DetachHead/eslint-plugin-detachhead/blob/master/docs/rules/suggestions-as-errors.md#troubleshooting"