From c852b6ec8075636bea6a9e76921e860d275807e2 Mon Sep 17 00:00:00 2001 From: detachhead Date: Wed, 2 Jul 2025 12:18:42 +1000 Subject: [PATCH 1/2] better fix for the playwright hanging issues --- src/node/main.ts | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/src/node/main.ts b/src/node/main.ts index 91044af..c682ffe 100644 --- a/src/node/main.ts +++ b/src/node/main.ts @@ -7,18 +7,8 @@ export type SelectorEngine = Parameters[1] const selectorEngine = (fileName: string): SelectorEngine => ({ // https://github.com/microsoft/playwright/issues/36448 content: `(() => { - const useFakeModule = typeof module === 'undefined' - if (useFakeModule) { - window.module = {exports: {}}; - } - try { - ${readFileSync(join(__dirname, `../../dist/browser/${fileName}.js`), 'utf8')}; - return module.exports.default - } finally { - if (useFakeModule) { - delete module - } - } + const module = {exports: {}}; + ${readFileSync(join(__dirname, `../../dist/browser/${fileName}.js`), 'utf8')}; return module.exports.default })()`, }) From e2f03be87a5386249fc242423e98109752f36b2f Mon Sep 17 00:00:00 2001 From: detachhead Date: Mon, 20 Oct 2025 11:14:11 +1000 Subject: [PATCH 2/2] bump the ui5 version used by unit tests since 1.125 was deleted from the site --- tests/testUtils.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/testUtils.ts b/tests/testUtils.ts index 443d104..658412e 100644 --- a/tests/testUtils.ts +++ b/tests/testUtils.ts @@ -11,7 +11,7 @@ export class Ui5Tester { this.selectorEngineId = `ui5_${selectorEngineName}` } navigateToUi5DocsPage = async (page: Page, path: `/${string}`) => { - await page.goto(`https://ui5.sap.com/1.125.1${path}`) + await page.goto(`https://ui5.sap.com/1.127.7${path}`) await page.waitForSelector( `${this.selectorEngineId}=${ this.selectorEngineName === 'css' ? '*' : '//*'