feat(lint): Add configurable rtlActiveValues and invalid-rtl-variant-value rule (#81)

* feat(lint): add configurable rtlActiveValues and invalid-rtl-variant-value rule

Add `rtlActiveValues` PKL config field (default `["On"]`) that controls
which RTL variant values are skipped during export. Previously hardcoded
to `"On"`, now designers using `true/false` or other conventions can
configure this per-entry.

New lint rule `invalid-rtl-variant-value` validates that RTL variant
property values match the configured active values and their known
counterparts (On↔Off, true↔false, True↔False, Yes↔No, 0↔1).

Also improves the empty component error message to show both the icon
name and variant name: `car (RTL=true)` instead of just `RTL=true`.

* docs: add rtlActiveValues documentation to Configuration.md, examples, and rules

* fix(lint): address review findings for rtlActiveValues

- Fix hardcoded "RTL=On" in ImageLoaderBase log message and comments
- Include rtlActiveValues in dedup key for InvalidRTLVariantValueRule
- Add tests for shouldSkipAsRTLVariant with custom activeValues
- Add rtlActiveValues pass-through assertion in IconsLoaderConfigTests
- Test validValues with custom value not in knownPairs
- Fix doc comment accuracy in InvalidRTLVariantValueRule
- Improve Configuration.md example with separate default/alternative

* fix(lint): address Gemini review — nil rtlProperty, images entries, fallbacks

- Skip entries with nil rtlProperty (user explicitly disabled RTL)
- Collect both icons and images entries for validation
- Apply common.icons/images frame/page name fallbacks
- Pre-calculate validValues outside component loop
- Add test for nil rtlProperty skipping

Author: alexey1312

.claude/rules/lint-patterns.md

@@ -26,3 +26,4 @@ Uses `FigmaAPI.Client.request(SomeEndpoint(...))` directly (no convenience metho
 - `LintEngineTests.defaultEngineHasAllRules` checks exact set of rule IDs — must add new rule ID when registering in `LintEngine.default`
 - `NodesEndpoint` supports `geometry: .paths` parameter — returns `fillGeometry`/`strokeGeometry` with SVG path data on vector nodes. **Not suitable for pathData validation** — Figma's SVG export flattens masks/booleans into different paths than raw geometry
 - `PathDataLengthRule` checks ALL platform icon entries (iOS/Android/Flutter/Web), deduplicates by fileId+frame+page. Downloads SVGs via `ImageEndpoint` + `URLSession`, parses with `SVGParser`, validates with `PathDataValidator`. Only reports critical >32,767 byte errors (800-char threshold removed as too noisy). Groups by fileId, batches ImageEndpoint by 50, parallelizes SVG downloads (max 10 concurrent) and fileIds
+- `InvalidRTLVariantValueRule` validates RTL variant property values against configured `rtlActiveValues` (default `["On"]`) and their known counterpart pairs (On↔Off, true↔false, True↔False, Yes↔No, 0↔1). Uses Components API only (no ImageEndpoint). Collects icon entries from all platforms with `rtlProperty` and `rtlActiveValues`, deduplicates by fileId+frame+page+rtlProperty. `validateRTLValues` and `validValues(for:)` are internal for testability. Suggests either renaming in Figma or adding value to `rtlActiveValues` config

.claude/rules/source-patterns.md

@@ -28,6 +28,7 @@ Do NOT inject `colorsSource` at context construction time — it breaks multi-so
 - `Component.iconName`: uses `containingComponentSet.name` for variants, own `name` otherwise
 - `Component.codeConnectNodeId`: uses `containingComponentSet.nodeId` for variants, own `nodeId` otherwise (Figma Code Connect rejects variant node IDs)
 - `Component.defaultRTLProperty = "RTL"`: shared constant in ExFigCLI for the magic string
+- `rtlActiveValues: Listing<String>? = new { "On" }`: configurable per-entry list of variant values that mean "active RTL" (skipped during export). `shouldSkipAsRTLVariant(propertyName:activeValues:)` checks against this list. Known pairs (case-sensitive): Off↔On, off↔on, false↔true, False↔True, No↔Yes, no↔yes, 0↔1
 - PNG images intentionally do NOT carry `isRTL` — raster images skip mirroring by design
 - `buildPairedComponents` must use `iconName` (not `name`) — variant `name` is `"RTL=Off"`, not the icon name
 

Sources/ExFig-Android/Config/AndroidIconsEntry.swift

@@ -23,6 +23,7 @@ public extension Android.IconsEntry {
             useSingleFile: darkFileId == nil && variablesDarkMode == nil,
             darkModeSuffix: "_dark",
             rtlProperty: rtlProperty,
+            rtlActiveValues: rtlActiveValues,
             nameValidateRegexp: nameValidateRegexp,
             nameReplaceRegexp: nameReplaceRegexp,
             penpotBaseURL: resolvedPenpotBaseURL,

Sources/ExFig-Android/Config/AndroidImagesEntry.swift

@@ -41,6 +41,7 @@ public extension Android.ImagesEntry {
             useSingleFile: darkFileId == nil,
             darkModeSuffix: "_dark",
             rtlProperty: rtlProperty,
+            rtlActiveValues: rtlActiveValues,
             nameValidateRegexp: nameValidateRegexp,
             nameReplaceRegexp: nameReplaceRegexp,
             penpotBaseURL: resolvedPenpotBaseURL

Sources/ExFig-Android/Export/AndroidImagesExporter.swift

@@ -446,6 +446,7 @@ private extension AndroidImagesExporter {
                 useSingleFile: true,
                 darkModeSuffix: "_dark",
                 rtlProperty: entry.rtlProperty,
+                rtlActiveValues: entry.rtlActiveValues,
                 nameValidateRegexp: entry.nameValidateRegexp,
                 nameReplaceRegexp: entry.nameReplaceRegexp
             )

Sources/ExFig-Flutter/Config/FlutterIconsEntry.swift

@@ -19,6 +19,7 @@ public extension Flutter.IconsEntry {
             useSingleFile: darkFileId == nil && variablesDarkMode == nil,
             darkModeSuffix: "_dark",
             rtlProperty: rtlProperty,
+            rtlActiveValues: rtlActiveValues,
             nameValidateRegexp: nameValidateRegexp,
             nameReplaceRegexp: nameReplaceRegexp,
             penpotBaseURL: resolvedPenpotBaseURL,

Sources/ExFig-Flutter/Config/FlutterImagesEntry.swift

@@ -24,6 +24,7 @@ public extension Flutter.ImagesEntry {
             useSingleFile: darkFileId == nil,
             darkModeSuffix: "_dark",
             rtlProperty: rtlProperty,
+            rtlActiveValues: rtlActiveValues,
             nameValidateRegexp: nameValidateRegexp,
             nameReplaceRegexp: nameReplaceRegexp,
             penpotBaseURL: resolvedPenpotBaseURL
@@ -55,6 +56,7 @@ public extension Flutter.ImagesEntry {
             useSingleFile: darkFileId == nil,
             darkModeSuffix: "_dark",
             rtlProperty: rtlProperty,
+            rtlActiveValues: rtlActiveValues,
             nameValidateRegexp: nameValidateRegexp,
             nameReplaceRegexp: nameReplaceRegexp,
             penpotBaseURL: resolvedPenpotBaseURL

Sources/ExFig-Web/Config/WebIconsEntry.swift

@@ -19,6 +19,7 @@ public extension Web.IconsEntry {
             useSingleFile: darkFileId == nil && variablesDarkMode == nil,
             darkModeSuffix: "_dark",
             rtlProperty: rtlProperty,
+            rtlActiveValues: rtlActiveValues,
             nameValidateRegexp: nameValidateRegexp,
             nameReplaceRegexp: nameReplaceRegexp,
             penpotBaseURL: resolvedPenpotBaseURL,

Sources/ExFig-Web/Config/WebImagesEntry.swift

@@ -21,6 +21,7 @@ public extension Web.ImagesEntry {
             useSingleFile: darkFileId == nil,
             darkModeSuffix: "_dark",
             rtlProperty: rtlProperty,
+            rtlActiveValues: rtlActiveValues,
             nameValidateRegexp: nameValidateRegexp,
             nameReplaceRegexp: nameReplaceRegexp,
             penpotBaseURL: resolvedPenpotBaseURL

Sources/ExFig-iOS/Config/iOSIconsEntry.swift

@@ -26,6 +26,7 @@ public extension iOS.IconsEntry {
             renderModeOriginalSuffix: renderModeOriginalSuffix,
             renderModeTemplateSuffix: renderModeTemplateSuffix,
             rtlProperty: rtlProperty,
+            rtlActiveValues: rtlActiveValues,
             nameValidateRegexp: nameValidateRegexp,
             nameReplaceRegexp: nameReplaceRegexp,
             penpotBaseURL: resolvedPenpotBaseURL,