BWM: null-guard shortcut-bar button derefs (fix >11 crash)

Author: Denkos-DS

GeneralsMD/Code/GameEngine/Source/GameClient/GUI/ControlBar/ControlBar.cpp

@@ -3502,8 +3502,8 @@ void ControlBar::populateSpecialPowerShortcut( Player *player)
 				}
 			}
 
-			DEBUG_ASSERTCRASH(m_specialPowerShortcutButtons[ currentButton ] != nullptr, ("m_specialPowerShortcutButtons[%d] is null", currentButton));
-			DEBUG_ASSERTCRASH(m_specialPowerShortcutButtonParents[ currentButton ] != nullptr, ("m_specialPowerShortcutButtonParents[%d] is null", currentButton));
+			if( m_specialPowerShortcutButtons[ currentButton ] == nullptr || m_specialPowerShortcutButtonParents[ currentButton ] == nullptr ) break;
+			// parent null-checked above
 
 			// make sure the window is not hidden
 			m_specialPowerShortcutButtons[ currentButton ]->winHide( FALSE );
@@ -3537,6 +3537,7 @@ Bool ControlBar::hasAnyShortcutSelection() const
 		const CommandButton *command;
 
 		win = m_specialPowerShortcutButtons[ i ];
+		if( win == nullptr ) continue;
 		if( win->winIsHidden() == TRUE )
 			continue;
 
@@ -3614,6 +3615,7 @@ void ControlBar::updateSpecialPowerShortcut()
 		const CommandButton *command;
 		// get the window
 		win = m_specialPowerShortcutButtons[ i ];
+		if( win == nullptr ) continue;
 
 		if( win->winIsHidden() == TRUE )
 			continue;
@@ -3706,6 +3708,7 @@ void ControlBar::drawSpecialPowerShortcutMultiplierText()
 		const CommandButton *command;
 		// get the window
 		win = m_specialPowerShortcutButtons[ i ];
+		if( win == nullptr ) continue;
 
 		if( win->winIsHidden() == TRUE )
 			continue;
@@ -3758,7 +3761,7 @@ void ControlBar::animateSpecialPowerShortcut( Bool isOn )
 	Bool dontAnimate = TRUE;
 	for( Int i = 0; i < m_currentlyUsedSpecialPowersButtons; ++i )
 	{
-		if (m_specialPowerShortcutButtons[i]->winGetUserData())
+		if (m_specialPowerShortcutButtons[i] && m_specialPowerShortcutButtons[i]->winGetUserData())
 		{
 			dontAnimate = FALSE;
 			break;
@@ -3786,7 +3789,7 @@ void ControlBar::showSpecialPowerShortcut()
 	Bool dontAnimate = TRUE;
 	for( Int i = 0; i < m_currentlyUsedSpecialPowersButtons; ++i )
 	{
-		if (m_specialPowerShortcutButtons[i]->winGetUserData())
+		if (m_specialPowerShortcutButtons[i] && m_specialPowerShortcutButtons[i]->winGetUserData())
 		{
 			dontAnimate = FALSE;
 			break;