FlwdirRaster.basins(xy=(X, Y)): with output Basin + Ldd

[AquaPore]

Kind of request

Adding new functionality

Enhancement Description

Hi,

basins is an amazing tool as I am using it to deliminate basins for the Wflow model. I also require to provide Wflow model with flw.

Therefore It will be usefull when using xy option that it also returns flw.

As my understanding when utilizing the xy option you are also modifying `flw

Ldd_FlwdirRaster.add_pits(xy=(X, Y))

PROPOSED OUTPUT

XY=[146661.436,42179.926]
 X, Y = np.array([XY[0]]), np.array([XY[1]])
subcatchment, flw = flw .basins!(xy=(X, Y))

With Kindness,
Joseph

Use case

No response

Additional Context

No response

[DirkEilander]

Hi @AquaPore,

In it's current form FlwDirRaster.basins does not actually modify the FlwDirRaster object but basically looks up all the cells upstream for the point locations given. If that's usefull we could add a keyword argument, e.g. "set_pits_in_flowdir" to also update the FlwDirRaster object itself inplace.

PS. I'll try to plan a round of maintenance and feature request soon.

[AquaPore]

Dear @DirkEilander,

A great thanks for proposing this modification, this will simplify considerably my code and hopefully for future users.
Yes indeed the option set_pits_in_flwdir and modify FlwDirRaster object to include the new pit will be amazing.

A great thanks for your support,
Joseph