M2 review follow-ups — consolidated tracker for #185–#189

[db-tycoon-stephen]

Consolidates the five findings from the Claude-assisted review of the M2 schema_version work (PRs #169, #171, #172, #178) into one place, per the 8/4 sync: @JesuFemi-O works from the GitHub board, so this issue carries all the context needed to evaluate what's critical before v0.1.11 ships and what rolls forward.

Each finding already has its own issue with full detail (repro, verification, suggested fix). This tracker adds a criticality read against the v0.1.11 freeze this week.

Issue	Finding	Criticality for v0.1.11
#188	tycoon init --upgrade and schema_version are user-facing and undocumented — and --upgrade is the remedy named in the warning users actually see	Highest — v0.1.11 is the release that starts printing that warning; shipping it with nowhere to read what --upgrade does is a rough edge for the exact users who hit it
#185	scaffold_from_template flattens the template tycoon.yml (drops blank lines, buries schema_version at the bottom) — the first file a new user opens	Low–medium — cosmetic but user-visible on every init --template; fix is small (reuse migrate_project after the copy)
#187	No subprocess-layer regression test for import-time CLI breakage — the "future schema_version bricks --help" class is unobservable in-process by construction	Medium value, not blocking — ~6 lines in the existing subprocess layer
#186	save_project's re-added schema_version lines are a verified no-op	Trivial cleanup, not blocking
#189	schema_version enforcement reaches only 4 of ~18 command modules — doctor says nothing while data sources list hard-exits on the same project	Deliberately unscheduled — scoping call between hoisting the check into the Typer root callback now vs. letting coverage arrive with the rest of the singleton removal

None of these are release-blockers in the "ship is broken" sense — the July 31 review round already fixed the one genuine bricker. #188 is the only one I'd argue for squeezing into v0.1.11; your call whether it makes the freeze or rolls to v0.1.12.

Jira mirrors, all under PTC-84 (M2): PTC-113 (#188), PTC-110 (#185), PTC-112 (#187), PTC-111 (#186), PTC-114 (#189).