Skip to content

Properly implement Codesmith (Blacksmith) as the repo's AI PR reviewer #173

Description

@db-tycoon-stephen

Context

Codesmith (Blacksmith's AI PR agent) was installed opportunistically — org-wide on Database-Tycoon with access to all repos (installation 139583274) — and never actually configured for this repo. Current footprint:

So it is neither working for us nor deliberately switched off. Meanwhile Gemini Code Assist was reviewing every PR unasked (silenced separately via .gemini/config.yaml), which is what surfaced the fact that nobody had decided what our AI-review setup actually is.

Relevant constraint: Codesmith auto-commits suggestions to the PR branch when autofix is enabled (co-author Codesmith) — observed in another repo, where it pushed changes that were invalid for that platform. That behavior needs an explicit decision, not a default.

Goal

Decide Codesmith's role on tycoon-cli, configure it to match, and document it — so its behavior is intentional and reviewers know how much to trust it.

Tasks

  • Identify Codesmith's actual configuration surface (repo config file vs. dashboard-only settings at app.blacksmith.sh/Database-Tycoon). Record what is configurable and where.
  • Decide scope: does Codesmith review all PRs, only PRs where it's tagged with /codesmith, or none?
  • Decide on autofix explicitly. Default recommendation: keep it disabled — auto-commits to a PR branch conflict with our review flow and cause rejected pushes.
  • Decide whether Codesmith runs org-wide or per-repo, and narrow the installation from "all repos" if per-repo is the answer.
  • Apply the configuration (committed to the repo if a config file exists; otherwise document the dashboard settings).
  • Document the outcome in docs/ (OKF page + index.md entry + docs/log.md) covering: which bots act on PRs, what each is allowed to do, how much a reviewer should trust them, and how to turn each off.
  • Note in CONTRIBUTING.md that a bot may act on PRs and to git pull before pushing if autofix is ever enabled.

Acceptance criteria

  • Every AI agent acting on tycoon-cli PRs is there by an explicit, recorded decision.
  • Autofix state is deliberate and documented.
  • A contributor can tell from docs/ alone which PR comments come from a bot and how much weight to give them.
  • No unasked-for bot review comments on PRs.

Notes

  • Related: .gemini/config.yaml opt-out (Gemini Code Assist, disabled for this repo).
  • Milestone intentionally unset — Emmanuel owns roadmap placement. Suggest slotting into v0.1.11 alongside the other repo-hygiene work, or the backlog if AI-review policy isn't near-term.

Metadata

Metadata

Assignees

No one assigned

    Labels

    tech-debtTest infrastructure, refactors, quality work that isn't a bug or featuretype: taskIndividual implementation tasks

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions