Skip to content

Commit e85d394

Browse files
committed
refactor(l10n): rename locale methods for clarity and update related tests
1 parent 23e5ba0 commit e85d394

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

src/Helpers/L10nHelper.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ class L10nHelper
1313
* @return string[]
1414
* @throws InvalidConfigurationException
1515
*/
16-
public static function getAvailable(): array
16+
public static function getAvailableLocales(): array
1717
{
1818
$config = config('eclipse-common.available_locales');
1919

@@ -40,9 +40,9 @@ public static function getAvailable(): array
4040
* @return string[]
4141
* @throws InvalidConfigurationException
4242
*/
43-
public static function getOptions(): array
43+
public static function getLocaleOptions(): array
4444
{
45-
return array_map(fn ($locale) => static::getLanguageName($locale, true), static::getAvailable());
45+
return array_map(fn ($locale) => static::getLanguageName($locale, true), static::getAvailableLocales());
4646
}
4747

4848
/**

tests/Unit/Helpers/L10nHelperTest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
test('it can get available locales from array config', function () {
6161
Config::set('eclipse-common.available_locales', ['en', 'sl']);
6262

63-
$locales = Helper::getAvailable();
63+
$locales = Helper::getAvailableLocales();
6464

6565
expect($locales)->toBeArray()
6666
->and($locales)->toHaveCount(2)
@@ -70,7 +70,7 @@
7070
test('it can get available locales from callable config', function () {
7171
Config::set('eclipse-common.available_locales', fn () => ['en', 'de']);
7272

73-
$locales = Helper::getAvailable();
73+
$locales = Helper::getAvailableLocales();
7474

7575
expect($locales)->toBeArray()
7676
->and($locales)->toHaveCount(2)
@@ -80,21 +80,21 @@
8080
test('it throws exception for invalid locales configuration', function () {
8181
Config::set('eclipse-common.available_locales', 'invalid');
8282

83-
expect(fn () => Helper::getAvailable())
83+
expect(fn () => Helper::getAvailableLocales())
8484
->toThrow(InvalidConfigurationException::class, 'Configuration "eclipse-common.available_locales" must be an array or a callable that returns an array.');
8585
});
8686

8787
test('it throws exception for empty locales configuration', function () {
8888
Config::set('eclipse-common.available_locales', []);
8989

90-
expect(fn () => Helper::getAvailable())
90+
expect(fn () => Helper::getAvailableLocales())
9191
->toThrow(InvalidConfigurationException::class, 'Configuration "eclipse-common.available_locales" must contain at least one locale.');
9292
});
9393

9494
test('it can get options for locales', function () {
9595
Config::set('eclipse-common.available_locales', ['en', 'sl']);
9696

97-
$options = Helper::getOptions();
97+
$options = Helper::getLocaleOptions();
9898

9999
expect($options)->toBeArray()
100100
->and($options)->toHaveCount(2)

0 commit comments

Comments
 (0)