Skip to content

Errors in the typed config system do not have a way to report the key path. #2199

Description

@webern

If we have an error during typed config translation, we do not have a way to report the key. Right now we have to hard code the key path in an error string. @thieman pointed this out in a PR and it's a good catch, but not with a quick fix.

For Datadog keys I think we can somehow gen the key paths and have them travel with the trait somehow. For Saluki-only it's not as clear but maybe we can ride serde like we already are for the environment variables.

This error seems like something that should be handled in the config system somewhere? Or is that coming later

edit: also seems wrong that the config path is hardcoded here since it's an opportunity for drift

Originally posted by @thieman in #2171 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions