Do not download unsynchronized lyrics if synchronized lyrics are available

[shark0151]

When downloading lyrics, the application should prefer synchronized lyrics whenever they are available.
If synchronized lyrics are not available for a track, the application should fall back to downloading unsynchronized lyrics instead.

If a track previously had unsynchronized lyrics downloaded but synchronized lyrics become available later, download the synchronized lyrics and delete the previously downloaded unsynchronized lyrics so that only the synchronized version remains.

[DRAZY]

Good catch, and you've read the behaviour correctly. Right now the .txt is written whenever plain lyrics come back, regardless of whether an .lrc got written alongside it. So you end up with both, and the synced one is almost always the one you actually want.

The first half of what you're asking for is straightforward. Prefer the .lrc, only write the .txt when there's no synced version, and put it behind a setting so anyone who deliberately wants both keeps them.

The second half is the part I want to think about. Deleting a .txt when synced lyrics turn up later means the app removing a file it wrote on a previous run, and that's the kind of thing that's fine ninety-nine times and infuriating the once someone had edited that file by hand. If I do it, it'll be opt-in rather than automatic.

Leaving this open while I look at it. Thanks for writing it up clearly.

[shark0151]

Cheers

[DRAZY]

Half of this shipped in 2.6.0.

There's a new setting under Save lyrics that skips the .txt when an .lrc gets written, so you get one file instead of two. It's off by default, since turning it on changes what an existing library gets. Tracks with no synced version still get their .txt as before.

The delete half, cleaning up a .txt written on an earlier run when synced lyrics turn up later, isn't in. That one deletes a file the app wrote previously, which is fine right up until someone had edited it by hand, so it needs its own opt-in. Tracking it in #141.

Closing this since the discussion's done its job. #141 is the place to follow the rest.