Skip to content

Commit aff8159

Browse files
committed
[clang-format] Update format rules and did a quick checkup on files
1 parent c55e98c commit aff8159

6 files changed

Lines changed: 59 additions & 34 deletions

File tree

‎.clang-format‎

Lines changed: 20 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,30 @@
11
---
22
AccessModifierOffset: '-4'
33
AlignEscapedNewlines: Right
4+
AlignTrailingComments:
5+
Kind: Leave
46
AllowShortBlocksOnASingleLine: 'false'
57
AllowShortFunctionsOnASingleLine: All
68
AllowShortIfStatementsOnASingleLine: Never
9+
AllowShortLambdasOnASingleLine: Inline
710
AllowShortLoopsOnASingleLine: 'false'
811
AlwaysBreakAfterReturnType: None
912
AlwaysBreakTemplateDeclarations: 'Yes'
10-
BreakBeforeBraces: Allman
13+
BraceWrapping:
14+
BeforeLambdaBody: false
15+
AfterNamespace: true
16+
AfterStruct: true
17+
AfterEnum: true
18+
AfterObjCDeclaration: false
19+
AfterClass: true
20+
AfterFunction: true
21+
BeforeWhile: true
22+
AfterUnion: true
23+
AfterExternBlock: true
24+
BeforeCatch: true
25+
BeforeElse: true
26+
AfterControlStatement: Always
27+
BreakBeforeBraces: Custom
1128
BreakBeforeTernaryOperators: 'true'
1229
BreakConstructorInitializers: BeforeComma
1330
BreakInheritanceList: BeforeComma
@@ -25,8 +42,7 @@ MaxEmptyLinesToKeep: '1'
2542
NamespaceIndentation: All
2643
PointerAlignment: Left
2744
ReflowComments: 'false'
28-
SortIncludes: 'true'
29-
SortUsingDeclarations: 'true'
45+
SortIncludes: 'false'
3046
SpaceAfterCStyleCast: 'false'
3147
SpaceAfterLogicalNot: 'false'
3248
SpaceAfterTemplateKeyword: 'false'
@@ -45,5 +61,4 @@ SpacesInSquareBrackets: 'false'
4561
Standard: Cpp11
4662
TabWidth: '4'
4763
UseTab: Never
48-
49-
...
64+
...

‎src/audioPlayer/Audio_System.cpp‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ Audio_System::~Audio_System()
3535
{
3636
m_pEngine->StopEngine();
3737
m_pMaster->DestroyVoice();
38-
38+
3939
for (auto [name, voice] : m_subVoices)
4040
{
4141
voice->DestroyVoice();
@@ -222,8 +222,7 @@ void Audio_System::removeChannel(const Channel& channel)
222222
const std::string Target_Mixer = channel.getMixerName();
223223

224224
auto it = std::find_if(std::begin(m_activeChannelPtrs[Target_Mixer]), std::end(m_activeChannelPtrs[Target_Mixer]),
225-
[&channel](const std::unique_ptr<Channel>& pChan)
226-
{
225+
[&channel](const std::unique_ptr<Channel>& pChan) {
227226
return &channel == pChan.get();
228227
});
229228

‎src/audioPlayer/Channel.cpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,8 @@ Channel::~Channel()
9898
}
9999
}
100100
}
101-
102-
} while (!DeactivatedEveryWhere);
101+
}
102+
while (!DeactivatedEveryWhere);
103103

104104
m_pSource->Stop();
105105
m_pSource->DestroyVoice();

‎src/audioPlayer/FileProcessing_MP3.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#if (!MINIMP3_ONLY_SIMD) && _MSC_VER
22
/* x64 always have SSE2, arm64 always have neon, no need for generic code */
3-
#define MINIMP3_ONLY_SIMD // error in x86 platform if not defined
3+
#define MINIMP3_ONLY_SIMD // error in x86 platform if not defined
44
#endif // (!MINIMP3_ONLY_SIMD) && _MSC_VER
55

66
#define MINIMP3_IMPLEMENTATION

‎src/audioPlayer/FileProcessing_WAV.cpp‎

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -150,8 +150,10 @@ bool FileProcessing_WAV::collectData(const BYTE* _fileData, int _fileSize)
150150
bool FileProcessing_WAV::onBufferEnd(Channel& channel)
151151
{
152152
std::lock_guard<std::mutex> lock(m_timeChanging_mutex);
153-
auto it = std::find_if(std::begin(m_timeChanging), std::end(m_timeChanging), [&channel](Channel& _channel)
154-
{ return &channel == &_channel; });
153+
auto it = std::find_if(std::begin(m_timeChanging), std::end(m_timeChanging), [&channel](Channel& _channel) {
154+
return &channel == &_channel;
155+
});
156+
155157
bool TimeChange = it != std::end(m_timeChanging);
156158

157159
if (channel.getSound().isLooping() && !channel.isForcedStop())
@@ -213,10 +215,9 @@ void FileProcessing_WAV::setPlayTime(Channel& channel, double time)
213215
{
214216
std::this_thread::sleep_for(std::chrono::milliseconds(5));
215217
std::lock_guard<std::mutex> lock(m_timeChanging_mutex);
216-
waitingReset = std::find_if(std::begin(m_timeChanging), std::end(m_timeChanging), [&channel](Channel& _channel)
217-
{ return &channel == &_channel; }) != std::end(m_timeChanging);
218-
219-
} while (waitingReset);
218+
waitingReset = std::find_if(std::begin(m_timeChanging), std::end(m_timeChanging), [&channel](Channel& _channel) { return &channel == &_channel; }) != std::end(m_timeChanging);
219+
}
220+
while (waitingReset);
220221

221222
{
222223
std::lock_guard<std::mutex> lock(channel.getSourceVoiceMutex());

‎src/audioPlayer/Sound.cpp‎

Lines changed: 27 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -131,16 +131,18 @@ Sound::~Sound()
131131
{
132132
std::lock_guard<std::mutex> lock(m_channelHandles_mutex);
133133

134-
std::for_each(std::begin(m_channelHandles), std::end(m_channelHandles), [](Channel& channel)
135-
{ channel.stop(); });
134+
std::for_each(std::begin(m_channelHandles), std::end(m_channelHandles), [](Channel& channel) {
135+
channel.stop();
136+
});
136137
}
137138

138139
bool allChannelsDeactivated = false;
139140
do
140141
{
141142
std::lock_guard<std::mutex> lock(m_channelHandles_mutex);
142143
allChannelsDeactivated = m_channelHandles.empty();
143-
} while (!allChannelsDeactivated);
144+
}
145+
while (!allChannelsDeactivated);
144146

145147
this->m_file.reset();
146148

@@ -210,22 +212,25 @@ void Sound::play()
210212
void Sound::resume()
211213
{
212214
std::lock_guard<std::mutex> lock(m_channelHandles_mutex);
213-
std::for_each(std::begin(m_channelHandles), std::end(m_channelHandles), [](Channel& channel)
214-
{ channel.resume(); });
215+
std::for_each(std::begin(m_channelHandles), std::end(m_channelHandles), [](Channel& channel) {
216+
channel.resume();
217+
});
215218
}
216219

217220
void Sound::pause()
218221
{
219222
std::lock_guard<std::mutex> lock(m_channelHandles_mutex);
220-
std::for_each(std::begin(m_channelHandles), std::end(m_channelHandles), [](Channel& channel)
221-
{ channel.pause(); });
223+
std::for_each(std::begin(m_channelHandles), std::end(m_channelHandles), [](Channel& channel) {
224+
channel.pause();
225+
});
222226
}
223227

224228
void Sound::stop()
225229
{
226230
std::lock_guard<std::mutex> lock(m_channelHandles_mutex);
227-
std::for_each(std::begin(m_channelHandles), std::end(m_channelHandles), [](Channel& channel)
228-
{ channel.stop(); });
231+
std::for_each(std::begin(m_channelHandles), std::end(m_channelHandles), [](Channel& channel) {
232+
channel.stop();
233+
});
229234
}
230235

231236
void Sound::setMixer(std::string _mixerName)
@@ -239,17 +244,19 @@ void Sound::setVolume(float volume)
239244
m_volume = std::clamp(volume, 0.f, 100.f);
240245

241246
std::lock_guard<std::mutex> lock(m_channelHandles_mutex);
242-
std::for_each(std::begin(m_channelHandles), std::end(m_channelHandles), [this](Channel& channel)
243-
{ channel.setVolume(m_volume); });
247+
std::for_each(std::begin(m_channelHandles), std::end(m_channelHandles), [this](Channel& channel) {
248+
channel.setVolume(m_volume);
249+
});
244250
}
245251

246252
void Sound::setSpeed(float speed)
247253
{
248254
m_speed = std::clamp(speed, 0.1f, 200.f);
249255

250256
std::lock_guard<std::mutex> lock(m_channelHandles_mutex);
251-
std::for_each(std::begin(m_channelHandles), std::end(m_channelHandles), [this](Channel& channel)
252-
{ channel.setSpeed(m_speed); });
257+
std::for_each(std::begin(m_channelHandles), std::end(m_channelHandles), [this](Channel& channel) {
258+
channel.setSpeed(m_speed);
259+
});
253260
}
254261

255262
double Sound::getAudioDuration() const
@@ -367,8 +374,10 @@ void Sound::addChannel(Channel& channel)
367374
void Sound::removeChannel(Channel& channel)
368375
{
369376
std::lock_guard<std::mutex> lock(m_channelHandles_mutex);
370-
auto it = std::find_if(std::begin(m_channelHandles), std::end(m_channelHandles), [&channel](Channel& _channel)
371-
{ return &channel == &_channel; });
377+
auto it = std::find_if(std::begin(m_channelHandles), std::end(m_channelHandles), [&channel](Channel& _channel) {
378+
return &channel == &_channel;
379+
});
380+
372381
if (it != std::end(m_channelHandles))
373382
{
374383
m_channelHandles.erase(it);
@@ -389,8 +398,9 @@ Sound::Statut Sound::getStatus() const
389398
}
390399
else
391400
{
392-
auto num_paused = std::count_if(std::begin(m_channelHandles), std::end(m_channelHandles), [](Channel& channel)
393-
{ return channel.getSpeed() <= 0.05f; });
401+
auto num_paused = std::count_if(std::begin(m_channelHandles), std::end(m_channelHandles), [](Channel& channel) {
402+
return channel.getSpeed() <= 0.05f;
403+
});
394404

395405
if (num_paused == 0)
396406
{

0 commit comments

Comments
 (0)